All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: kyungmin.park@samsung.com, richard@nod.at, vigneshr@ti.com,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mtd: onenand: Check for error irq
Date: Sun, 23 Jan 2022 16:44:41 +0100	[thread overview]
Message-ID: <20220123164441.4ac98b08@xps13> (raw)
In-Reply-To: <20220104162658.1988142-1-jiasheng@iscas.ac.cn>

Hi Jiasheng,

jiasheng@iscas.ac.cn wrote on Wed,  5 Jan 2022 00:26:58 +0800:

> For the possible failure of the platform_get_irq(), the returned irq
> could be error number and will finally cause the failure of the
> request_irq().
> Consider that platform_get_irq() can now in certain cases return
> -EPROBE_DEFER, and the consequences of letting request_irq() effectively
> convert that into -EINVAL, even at probe time rather than later on.
> So it might be better to check just now.
> 
> Fixes: 2c22120fbd01 ("MTD: OneNAND: interrupt based wait support")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---

Applied to nand/next.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: kyungmin.park@samsung.com, richard@nod.at, vigneshr@ti.com,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mtd: onenand: Check for error irq
Date: Sun, 23 Jan 2022 16:44:41 +0100	[thread overview]
Message-ID: <20220123164441.4ac98b08@xps13> (raw)
In-Reply-To: <20220104162658.1988142-1-jiasheng@iscas.ac.cn>

Hi Jiasheng,

jiasheng@iscas.ac.cn wrote on Wed,  5 Jan 2022 00:26:58 +0800:

> For the possible failure of the platform_get_irq(), the returned irq
> could be error number and will finally cause the failure of the
> request_irq().
> Consider that platform_get_irq() can now in certain cases return
> -EPROBE_DEFER, and the consequences of letting request_irq() effectively
> convert that into -EINVAL, even at probe time rather than later on.
> So it might be better to check just now.
> 
> Fixes: 2c22120fbd01 ("MTD: OneNAND: interrupt based wait support")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---

Applied to nand/next.

Thanks,
Miquèl

  reply	other threads:[~2022-01-23 15:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04 16:26 [PATCH v3] mtd: onenand: Check for error irq Jiasheng Jiang
2022-01-04 16:26 ` Jiasheng Jiang
2022-01-23 15:44 ` Miquel Raynal [this message]
2022-01-23 15:44   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220123164441.4ac98b08@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=jiasheng@iscas.ac.cn \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.