From: kernel test robot <lkp@intel.com>
To: Phillip Potter <phil@philpotter.co.uk>, gregkh@linuxfoundation.org
Cc: kbuild-all@lists.01.org, dan.carpenter@oracle.com,
Larry.Finger@lwfinger.net, straube.linux@gmail.com,
martin@kaiser.cx, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, paskripkin@gmail.com
Subject: Re: [PATCH 06/10] staging: r8188eu: remove DBG_88E calls from os_dep/ioctl_linux.c
Date: Tue, 25 Jan 2022 17:31:25 +0800 [thread overview]
Message-ID: <202201251730.AgK9qxSH-lkp@intel.com> (raw)
In-Reply-To: <20220124224415.831-7-phil@philpotter.co.uk>
Hi Phillip,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v5.17-rc1 next-20220124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Phillip-Potter/Cleanup-and-removal-of-DBG_88E-macro/20220125-125206
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git fa783154524a71ab74e293cd8251155e5971952b
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220125/202201251730.AgK9qxSH-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/1724ade2c1f2fa95e0e314ed9229700d6158fbbc
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Phillip-Potter/Cleanup-and-removal-of-DBG_88E-macro/20220125-125206
git checkout 1724ade2c1f2fa95e0e314ed9229700d6158fbbc
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/staging/r8188eu/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/staging/r8188eu/os_dep/ioctl_linux.c: In function 'rtw_wx_set_mlme':
>> drivers/staging/r8188eu/os_dep/ioctl_linux.c:1022:13: warning: variable 'reason' set but not used [-Wunused-but-set-variable]
1022 | u16 reason;
| ^~~~~~
vim +/reason +1022 drivers/staging/r8188eu/os_dep/ioctl_linux.c
2b42bd58b32155 Phillip Potter 2021-07-28 1016
2b42bd58b32155 Phillip Potter 2021-07-28 1017 static int rtw_wx_set_mlme(struct net_device *dev,
2b42bd58b32155 Phillip Potter 2021-07-28 1018 struct iw_request_info *info,
2b42bd58b32155 Phillip Potter 2021-07-28 1019 union iwreq_data *wrqu, char *extra)
2b42bd58b32155 Phillip Potter 2021-07-28 1020 {
2b42bd58b32155 Phillip Potter 2021-07-28 1021 int ret = 0;
2b42bd58b32155 Phillip Potter 2021-07-28 @1022 u16 reason;
2b42bd58b32155 Phillip Potter 2021-07-28 1023 struct adapter *padapter = (struct adapter *)rtw_netdev_priv(dev);
2b42bd58b32155 Phillip Potter 2021-07-28 1024 struct iw_mlme *mlme = (struct iw_mlme *)extra;
2b42bd58b32155 Phillip Potter 2021-07-28 1025
d8062f6adca1ef Michael Straube 2021-07-30 1026 if (!mlme)
2b42bd58b32155 Phillip Potter 2021-07-28 1027 return -1;
2b42bd58b32155 Phillip Potter 2021-07-28 1028
2b42bd58b32155 Phillip Potter 2021-07-28 1029 reason = mlme->reason_code;
2b42bd58b32155 Phillip Potter 2021-07-28 1030
2b42bd58b32155 Phillip Potter 2021-07-28 1031 switch (mlme->cmd) {
2b42bd58b32155 Phillip Potter 2021-07-28 1032 case IW_MLME_DEAUTH:
2b42bd58b32155 Phillip Potter 2021-07-28 1033 if (!rtw_set_802_11_disassociate(padapter))
2b42bd58b32155 Phillip Potter 2021-07-28 1034 ret = -1;
2b42bd58b32155 Phillip Potter 2021-07-28 1035 break;
2b42bd58b32155 Phillip Potter 2021-07-28 1036 case IW_MLME_DISASSOC:
2b42bd58b32155 Phillip Potter 2021-07-28 1037 if (!rtw_set_802_11_disassociate(padapter))
2b42bd58b32155 Phillip Potter 2021-07-28 1038 ret = -1;
2b42bd58b32155 Phillip Potter 2021-07-28 1039 break;
2b42bd58b32155 Phillip Potter 2021-07-28 1040 default:
2b42bd58b32155 Phillip Potter 2021-07-28 1041 return -EOPNOTSUPP;
2b42bd58b32155 Phillip Potter 2021-07-28 1042 }
2b42bd58b32155 Phillip Potter 2021-07-28 1043 return ret;
2b42bd58b32155 Phillip Potter 2021-07-28 1044 }
2b42bd58b32155 Phillip Potter 2021-07-28 1045
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 06/10] staging: r8188eu: remove DBG_88E calls from os_dep/ioctl_linux.c
Date: Tue, 25 Jan 2022 17:31:25 +0800 [thread overview]
Message-ID: <202201251730.AgK9qxSH-lkp@intel.com> (raw)
In-Reply-To: <20220124224415.831-7-phil@philpotter.co.uk>
[-- Attachment #1: Type: text/plain, Size: 4198 bytes --]
Hi Phillip,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v5.17-rc1 next-20220124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Phillip-Potter/Cleanup-and-removal-of-DBG_88E-macro/20220125-125206
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git fa783154524a71ab74e293cd8251155e5971952b
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220125/202201251730.AgK9qxSH-lkp(a)intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/1724ade2c1f2fa95e0e314ed9229700d6158fbbc
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Phillip-Potter/Cleanup-and-removal-of-DBG_88E-macro/20220125-125206
git checkout 1724ade2c1f2fa95e0e314ed9229700d6158fbbc
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/staging/r8188eu/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/staging/r8188eu/os_dep/ioctl_linux.c: In function 'rtw_wx_set_mlme':
>> drivers/staging/r8188eu/os_dep/ioctl_linux.c:1022:13: warning: variable 'reason' set but not used [-Wunused-but-set-variable]
1022 | u16 reason;
| ^~~~~~
vim +/reason +1022 drivers/staging/r8188eu/os_dep/ioctl_linux.c
2b42bd58b32155 Phillip Potter 2021-07-28 1016
2b42bd58b32155 Phillip Potter 2021-07-28 1017 static int rtw_wx_set_mlme(struct net_device *dev,
2b42bd58b32155 Phillip Potter 2021-07-28 1018 struct iw_request_info *info,
2b42bd58b32155 Phillip Potter 2021-07-28 1019 union iwreq_data *wrqu, char *extra)
2b42bd58b32155 Phillip Potter 2021-07-28 1020 {
2b42bd58b32155 Phillip Potter 2021-07-28 1021 int ret = 0;
2b42bd58b32155 Phillip Potter 2021-07-28 @1022 u16 reason;
2b42bd58b32155 Phillip Potter 2021-07-28 1023 struct adapter *padapter = (struct adapter *)rtw_netdev_priv(dev);
2b42bd58b32155 Phillip Potter 2021-07-28 1024 struct iw_mlme *mlme = (struct iw_mlme *)extra;
2b42bd58b32155 Phillip Potter 2021-07-28 1025
d8062f6adca1ef Michael Straube 2021-07-30 1026 if (!mlme)
2b42bd58b32155 Phillip Potter 2021-07-28 1027 return -1;
2b42bd58b32155 Phillip Potter 2021-07-28 1028
2b42bd58b32155 Phillip Potter 2021-07-28 1029 reason = mlme->reason_code;
2b42bd58b32155 Phillip Potter 2021-07-28 1030
2b42bd58b32155 Phillip Potter 2021-07-28 1031 switch (mlme->cmd) {
2b42bd58b32155 Phillip Potter 2021-07-28 1032 case IW_MLME_DEAUTH:
2b42bd58b32155 Phillip Potter 2021-07-28 1033 if (!rtw_set_802_11_disassociate(padapter))
2b42bd58b32155 Phillip Potter 2021-07-28 1034 ret = -1;
2b42bd58b32155 Phillip Potter 2021-07-28 1035 break;
2b42bd58b32155 Phillip Potter 2021-07-28 1036 case IW_MLME_DISASSOC:
2b42bd58b32155 Phillip Potter 2021-07-28 1037 if (!rtw_set_802_11_disassociate(padapter))
2b42bd58b32155 Phillip Potter 2021-07-28 1038 ret = -1;
2b42bd58b32155 Phillip Potter 2021-07-28 1039 break;
2b42bd58b32155 Phillip Potter 2021-07-28 1040 default:
2b42bd58b32155 Phillip Potter 2021-07-28 1041 return -EOPNOTSUPP;
2b42bd58b32155 Phillip Potter 2021-07-28 1042 }
2b42bd58b32155 Phillip Potter 2021-07-28 1043 return ret;
2b42bd58b32155 Phillip Potter 2021-07-28 1044 }
2b42bd58b32155 Phillip Potter 2021-07-28 1045
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2022-01-25 9:31 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 22:44 [PATCH 00/10] Cleanup and removal of DBG_88E macro Phillip Potter
2022-01-24 22:44 ` [PATCH 01/10] staging: r8188eu: remove previously added dev_dbg and netdev_dbg calls Phillip Potter
2022-01-24 22:44 ` [PATCH 02/10] staging: r8188eu: remove smaller sets of DBG_88E calls from core dir Phillip Potter
2022-01-25 9:02 ` Dan Carpenter
2022-01-26 0:54 ` Phillip Potter
2022-01-26 6:00 ` Dan Carpenter
2022-01-25 18:17 ` Pavel Skripkin
2022-01-26 1:00 ` Phillip Potter
2022-01-24 22:44 ` [PATCH 03/10] staging: r8188eu: remove DBG_88E calls from core/rtw_mlme_ext.c Phillip Potter
2022-01-25 7:22 ` kernel test robot
2022-01-25 7:22 ` kernel test robot
2022-01-25 18:31 ` Pavel Skripkin
2022-01-26 1:02 ` Phillip Potter
2022-01-24 22:44 ` [PATCH 04/10] staging: r8188eu: remove all DBG_88E calls from hal dir Phillip Potter
2022-01-25 8:27 ` kernel test robot
2022-01-25 8:27 ` kernel test robot
2022-01-24 22:44 ` [PATCH 05/10] staging: r8188eu: remove smaller sets of DBG_88E calls from os_dep dir Phillip Potter
2022-01-25 12:48 ` Pavel Skripkin
2022-01-25 12:59 ` Dan Carpenter
2022-01-25 13:04 ` Pavel Skripkin
2022-01-25 13:07 ` Dan Carpenter
2022-01-26 0:58 ` Phillip Potter
2022-01-24 22:44 ` [PATCH 06/10] staging: r8188eu: remove DBG_88E calls from os_dep/ioctl_linux.c Phillip Potter
2022-01-25 9:31 ` kernel test robot [this message]
2022-01-25 9:31 ` kernel test robot
2022-01-25 19:03 ` Pavel Skripkin
2022-01-26 1:13 ` Phillip Potter
2022-01-26 10:26 ` Pavel Skripkin
2022-01-26 10:48 ` Greg KH
2022-01-26 10:58 ` Pavel Skripkin
2022-01-26 11:14 ` Greg KH
2022-01-27 8:53 ` Phillip Potter
2022-01-24 22:44 ` [PATCH 07/10] staging: r8188eu: remove DBG_88E call from include/usb_ops.h Phillip Potter
2022-01-24 22:44 ` [PATCH 08/10] staging: r8188eu: remove all remaining aliased DBG_88E calls Phillip Potter
2022-01-24 22:44 ` [PATCH 09/10] staging: r8188eu: remove DBG_88E macro definition Phillip Potter
2022-01-24 22:44 ` [PATCH 10/10] staging: r8188eu: remove GlobalDebugLevel flag Phillip Potter
2022-01-25 15:33 ` [PATCH 00/10] Cleanup and removal of DBG_88E macro Greg KH
2022-01-26 0:45 ` Phillip Potter
-- strict thread matches above, loose matches on Subject: below --
2022-01-24 22:50 [RESENT PATCH 00/10] staging: r8188eu: " Phillip Potter
2022-01-24 22:50 ` [PATCH 06/10] staging: r8188eu: remove DBG_88E calls from os_dep/ioctl_linux.c Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202201251730.AgK9qxSH-lkp@intel.com \
--to=lkp@intel.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.