* [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings
2022-01-25 13:10 drivers/staging/wfx/bus_sdio.c:133:8-33: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
@ 2022-01-25 13:03 ` kernel test robot
2022-01-25 13:03 ` kernel test robot
2022-01-25 13:03 ` kernel test robot
2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2022-01-25 13:03 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1774 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Krzysztof Kozlowski <krzk@kernel.org>
CC: Julia Lawall <Julia.Lawall@inria.fr>
CC: Lee Jones <lee.jones@linaro.org>
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/mfd/htc-i2cpld.c:546:8-28: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)
Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
threaded IRQs without a primary handler need to be requested with
IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
CC: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: a08b41ab9e2e468647f78eb17c28e29b93006394
commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: reduce the severity due to false positives
:::::: branch date: 7 hours ago
:::::: commit date: 9 months ago
Please take the patch only if it's a positive warning. Thanks!
htc-i2cpld.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/mfd/htc-i2cpld.c
+++ b/drivers/mfd/htc-i2cpld.c
@@ -545,7 +545,8 @@ static int htcpld_core_probe(struct plat
IRQF_ONESHOT;
ret = request_threaded_irq(htcpld->chained_irq,
NULL, htcpld_handler,
- flags, pdev->name, htcpld);
+ flags | IRQF_ONESHOT, pdev->name,
+ htcpld);
if (ret) {
dev_warn(dev, "Unable to setup chained irq handler: %d\n", ret);
return ret;
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings
2022-01-25 13:10 drivers/staging/wfx/bus_sdio.c:133:8-33: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2022-01-25 13:03 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
@ 2022-01-25 13:03 ` kernel test robot
2022-01-25 13:03 ` kernel test robot
2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2022-01-25 13:03 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1980 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Krzysztof Kozlowski <krzk@kernel.org>
CC: Julia Lawall <Julia.Lawall@inria.fr>
CC: Chanwoo Choi <cw00.choi@samsung.com>
CC: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
CC: Alessandro Zummo <a.zummo@towertech.it>
CC: Alexandre Belloni <alexandre.belloni@bootlin.com>
CC: linux-kernel(a)vger.kernel.org
CC: linux-rtc(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/rtc/rtc-max77686.c:779:7-27: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)
Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
threaded IRQs without a primary handler need to be requested with
IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
CC: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: a08b41ab9e2e468647f78eb17c28e29b93006394
commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: reduce the severity due to false positives
:::::: branch date: 7 hours ago
:::::: commit date: 9 months ago
Please take the patch only if it's a positive warning. Thanks!
rtc-max77686.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/rtc/rtc-max77686.c
+++ b/drivers/rtc/rtc-max77686.c
@@ -776,7 +776,8 @@ static int max77686_rtc_probe(struct pla
goto err_rtc;
}
- ret = request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq, 0,
+ ret = request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq,
+ IRQF_ONESHOT,
"rtc-alarm1", info);
if (ret < 0) {
dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n",
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings
2022-01-25 13:10 drivers/staging/wfx/bus_sdio.c:133:8-33: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2022-01-25 13:03 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2022-01-25 13:03 ` kernel test robot
@ 2022-01-25 13:03 ` kernel test robot
2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2022-01-25 13:03 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1832 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Krzysztof Kozlowski <krzk@kernel.org>
CC: Julia Lawall <Julia.Lawall@inria.fr>
CC: Alessandro Zummo <a.zummo@towertech.it>
CC: Alexandre Belloni <alexandre.belloni@bootlin.com>
CC: linux-rtc(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/rtc/rtc-max8997.c:495:7-32: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)
Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
threaded IRQs without a primary handler need to be requested with
IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
CC: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: a08b41ab9e2e468647f78eb17c28e29b93006394
commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: reduce the severity due to false positives
:::::: branch date: 7 hours ago
:::::: commit date: 9 months ago
Please take the patch only if it's a positive warning. Thanks!
rtc-max8997.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/rtc/rtc-max8997.c
+++ b/drivers/rtc/rtc-max8997.c
@@ -493,7 +493,7 @@ static int max8997_rtc_probe(struct plat
info->virq = virq;
ret = devm_request_threaded_irq(&pdev->dev, virq, NULL,
- max8997_rtc_alarm_irq, 0,
+ max8997_rtc_alarm_irq, IRQF_ONESHOT,
"rtc-alarm0", info);
if (ret < 0)
dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n",
^ permalink raw reply [flat|nested] 4+ messages in thread