From: Zhu Lingshan <lingshan.zhu@intel.com>
To: mst@redhat.com, jasowang@redhat.com
Cc: netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Zhu Lingshan <lingshan.zhu@intel.com>
Subject: [PATCH V3 3/4] vhost_vdpa: don't setup irq offloading when irq_num < 0
Date: Wed, 26 Jan 2022 20:49:11 +0800 [thread overview]
Message-ID: <20220126124912.90205-4-lingshan.zhu@intel.com> (raw)
In-Reply-To: <20220126124912.90205-1-lingshan.zhu@intel.com>
When irq number is negative(e.g., -EINVAL), the virtqueue
may be disabled or the virtqueues are sharing a device irq.
In such case, we should not setup irq offloading for a virtqueue.
Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
---
drivers/vhost/vdpa.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
index 851539807bc9..c4fcacb0de3a 100644
--- a/drivers/vhost/vdpa.c
+++ b/drivers/vhost/vdpa.c
@@ -96,6 +96,10 @@ static void vhost_vdpa_setup_vq_irq(struct vhost_vdpa *v, u16 qid)
if (!ops->get_vq_irq)
return;
+ irq = ops->get_vq_irq(vdpa, qid);
+ if (irq < 0)
+ return;
+
irq = ops->get_vq_irq(vdpa, qid);
irq_bypass_unregister_producer(&vq->call_ctx.producer);
if (!vq->call_ctx.ctx || irq < 0)
--
2.27.0
next prev parent reply other threads:[~2022-01-26 12:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 12:49 [PATCH V3 0/4] vDPA/ifcvf: implement shared IRQ feature Zhu Lingshan
2022-01-26 12:49 ` [PATCH V3 1/4] vDPA/ifcvf: implement IO read/write helpers in the header file Zhu Lingshan
2022-01-26 12:49 ` [PATCH V3 2/4] vDPA/ifcvf: implement device MSIX vector allocator Zhu Lingshan
2022-01-26 12:49 ` Zhu Lingshan [this message]
2022-01-26 12:49 ` [PATCH V3 4/4] vDPA/ifcvf: implement shared IRQ feature Zhu Lingshan
2022-01-31 6:40 ` kernel test robot
2022-01-26 14:14 ` [PATCH V3 0/4] " Michael S. Tsirkin
2022-01-26 14:14 ` Michael S. Tsirkin
2022-01-27 4:31 ` Zhu, Lingshan
2022-01-27 8:27 ` Zhu, Lingshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126124912.90205-4-lingshan.zhu@intel.com \
--to=lingshan.zhu@intel.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.