From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Pankaj Raghav <p.raghav@samsung.com>,
Pankaj Raghav <pankydev8@gmail.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: Use pci_iomap instead of ioremap
Date: Wed, 26 Jan 2022 18:26:38 +0100 [thread overview]
Message-ID: <20220126172638.GA32649@lst.de> (raw)
In-Reply-To: <20220126172204.GE1885300@dhcp-10-100-145-180.wdc.com>
On Wed, Jan 26, 2022 at 09:22:04AM -0800, Keith Busch wrote:
> On Wed, Jan 26, 2022 at 05:33:06PM +0100, Christoph Hellwig wrote:
> > pci_iomap goes with the ioread/iowrite accessors which we absolutely
> > do not want in nvme.
>
> It looks like the action pci_iomap() uses is based on the
> pci_resource_flags(), and should call the same "ioremap()" function we
> currently use.
Yes. But the rule is: use ioremap when you use read*/write*, and use
pci_iomap when using ioread/iowrite. But they should never be mixed.
next prev parent reply other threads:[~2022-01-26 17:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220121143539eucas1p20202376f83b0b499143c18b1434ff000@eucas1p2.samsung.com>
2022-01-21 14:35 ` [PATCH] nvme: Use pci_iomap instead of ioremap Pankaj Raghav
2022-01-26 16:33 ` Christoph Hellwig
2022-01-26 17:22 ` Keith Busch
2022-01-26 17:26 ` Christoph Hellwig [this message]
2022-01-27 13:16 ` Pankaj Raghav
2022-01-27 13:05 ` Pankaj Raghav
2022-01-27 14:45 ` Christoph Hellwig
2022-01-27 15:56 ` Pankaj Raghav
2022-01-27 16:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126172638.GA32649@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=p.raghav@samsung.com \
--cc=pankydev8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.