From: Christoph Hellwig <hch@lst.de>
To: Pankaj Raghav <p.raghav@samsung.com>
Cc: Christoph Hellwig <hch@lst.de>,
Pankaj Raghav <pankydev8@gmail.com>,
Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: Use pci_iomap instead of ioremap
Date: Thu, 27 Jan 2022 17:01:29 +0100 [thread overview]
Message-ID: <20220127160129.GA21421@lst.de> (raw)
In-Reply-To: <af495f19-b060-42bb-f22c-430dd79b98c0@samsung.com>
On Thu, Jan 27, 2022 at 09:26:28PM +0530, Pankaj Raghav wrote:
> `ioremap` has a comment to prefer pci_iomap if the area we are trying
> to map is a PCI BAR. Does it makes sense then to have a comment in
> the nvme pci driver as to why ioremap is preferred over pci_iomap?
I don't think that comment is correct. pci_iomap is not a replacement
for ioremap, but an interface that helps drivers that need to
transparently deal with MMIO and Port I/O - something that is mostly
of historic interest these days.
prev parent reply other threads:[~2022-01-27 16:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220121143539eucas1p20202376f83b0b499143c18b1434ff000@eucas1p2.samsung.com>
2022-01-21 14:35 ` [PATCH] nvme: Use pci_iomap instead of ioremap Pankaj Raghav
2022-01-26 16:33 ` Christoph Hellwig
2022-01-26 17:22 ` Keith Busch
2022-01-26 17:26 ` Christoph Hellwig
2022-01-27 13:16 ` Pankaj Raghav
2022-01-27 13:05 ` Pankaj Raghav
2022-01-27 14:45 ` Christoph Hellwig
2022-01-27 15:56 ` Pankaj Raghav
2022-01-27 16:01 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220127160129.GA21421@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=p.raghav@samsung.com \
--cc=pankydev8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.