* [PATCH 1/2] drm/amdgpu: convert code name to ip version for athub
@ 2022-01-27 1:48 Aaron Liu
2022-01-27 1:48 ` [PATCH 2/2] drm/amdgpu: add 1.3.1/2.4.0 athub CG support Aaron Liu
2022-01-27 3:06 ` [PATCH 1/2] drm/amdgpu: convert code name to ip version for athub Alex Deucher
0 siblings, 2 replies; 5+ messages in thread
From: Aaron Liu @ 2022-01-27 1:48 UTC (permalink / raw)
To: amd-gfx; +Cc: Alexander.Deucher, Ray.Huang, Aaron Liu
Use IP version rather than codename for athub.
Signed-off-by: Aaron Liu <aaron.liu@amd.com>
---
drivers/gpu/drm/amd/amdgpu/athub_v1_0.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/athub_v1_0.c b/drivers/gpu/drm/amd/amdgpu/athub_v1_0.c
index 3ea557864320..88642e7ecdf4 100644
--- a/drivers/gpu/drm/amd/amdgpu/athub_v1_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/athub_v1_0.c
@@ -68,12 +68,13 @@ int athub_v1_0_set_clockgating(struct amdgpu_device *adev,
if (amdgpu_sriov_vf(adev))
return 0;
- switch (adev->asic_type) {
- case CHIP_VEGA10:
- case CHIP_VEGA12:
- case CHIP_VEGA20:
- case CHIP_RAVEN:
- case CHIP_RENOIR:
+ switch (adev->ip_versions[ATHUB_HWIP][0]) {
+ case IP_VERSION(9, 0, 0):
+ case IP_VERSION(9, 1, 0):
+ case IP_VERSION(9, 2, 0):
+ case IP_VERSION(9, 3, 0):
+ case IP_VERSION(9, 4, 0):
+ case IP_VERSION(1, 5, 0):
athub_update_medium_grain_clock_gating(adev,
state == AMD_CG_STATE_GATE);
athub_update_medium_grain_light_sleep(adev,
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] drm/amdgpu: add 1.3.1/2.4.0 athub CG support
2022-01-27 1:48 [PATCH 1/2] drm/amdgpu: convert code name to ip version for athub Aaron Liu
@ 2022-01-27 1:48 ` Aaron Liu
2022-01-27 2:07 ` Huang Rui
2022-01-27 3:06 ` [PATCH 1/2] drm/amdgpu: convert code name to ip version for athub Alex Deucher
1 sibling, 1 reply; 5+ messages in thread
From: Aaron Liu @ 2022-01-27 1:48 UTC (permalink / raw)
To: amd-gfx; +Cc: Alexander.Deucher, Ray.Huang, Aaron Liu
This patch adds 1.3.1/2.4.0 athub clock gating support.
Signed-off-by: Aaron Liu <aaron.liu@amd.com>
---
drivers/gpu/drm/amd/amdgpu/athub_v2_0.c | 1 +
drivers/gpu/drm/amd/amdgpu/athub_v2_1.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/athub_v2_0.c b/drivers/gpu/drm/amd/amdgpu/athub_v2_0.c
index ab6a07e5e8c4..a720436857b4 100644
--- a/drivers/gpu/drm/amd/amdgpu/athub_v2_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/athub_v2_0.c
@@ -78,6 +78,7 @@ int athub_v2_0_set_clockgating(struct amdgpu_device *adev,
return 0;
switch (adev->ip_versions[ATHUB_HWIP][0]) {
+ case IP_VERSION(1, 3, 1):
case IP_VERSION(2, 0, 0):
case IP_VERSION(2, 0, 2):
athub_v2_0_update_medium_grain_clock_gating(adev,
diff --git a/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c b/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c
index 2edefd10e56c..ad8e87d3d2cb 100644
--- a/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c
+++ b/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c
@@ -74,6 +74,7 @@ int athub_v2_1_set_clockgating(struct amdgpu_device *adev,
case IP_VERSION(2, 1, 0):
case IP_VERSION(2, 1, 1):
case IP_VERSION(2, 1, 2):
+ case IP_VERSION(2, 4, 0):
athub_v2_1_update_medium_grain_clock_gating(adev, state == AMD_CG_STATE_GATE);
athub_v2_1_update_medium_grain_light_sleep(adev, state == AMD_CG_STATE_GATE);
break;
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] drm/amdgpu: add 1.3.1/2.4.0 athub CG support
2022-01-27 1:48 ` [PATCH 2/2] drm/amdgpu: add 1.3.1/2.4.0 athub CG support Aaron Liu
@ 2022-01-27 2:07 ` Huang Rui
2022-01-27 3:07 ` Alex Deucher
0 siblings, 1 reply; 5+ messages in thread
From: Huang Rui @ 2022-01-27 2:07 UTC (permalink / raw)
To: Liu, Aaron; +Cc: Deucher, Alexander, amd-gfx@lists.freedesktop.org
On Thu, Jan 27, 2022 at 09:48:06AM +0800, Liu, Aaron wrote:
> This patch adds 1.3.1/2.4.0 athub clock gating support.
>
> Signed-off-by: Aaron Liu <aaron.liu@amd.com>
Series are Reviewed-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/athub_v2_0.c | 1 +
> drivers/gpu/drm/amd/amdgpu/athub_v2_1.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/athub_v2_0.c b/drivers/gpu/drm/amd/amdgpu/athub_v2_0.c
> index ab6a07e5e8c4..a720436857b4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/athub_v2_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/athub_v2_0.c
> @@ -78,6 +78,7 @@ int athub_v2_0_set_clockgating(struct amdgpu_device *adev,
> return 0;
>
> switch (adev->ip_versions[ATHUB_HWIP][0]) {
> + case IP_VERSION(1, 3, 1):
> case IP_VERSION(2, 0, 0):
> case IP_VERSION(2, 0, 2):
> athub_v2_0_update_medium_grain_clock_gating(adev,
> diff --git a/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c b/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c
> index 2edefd10e56c..ad8e87d3d2cb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c
> +++ b/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c
> @@ -74,6 +74,7 @@ int athub_v2_1_set_clockgating(struct amdgpu_device *adev,
> case IP_VERSION(2, 1, 0):
> case IP_VERSION(2, 1, 1):
> case IP_VERSION(2, 1, 2):
> + case IP_VERSION(2, 4, 0):
> athub_v2_1_update_medium_grain_clock_gating(adev, state == AMD_CG_STATE_GATE);
> athub_v2_1_update_medium_grain_light_sleep(adev, state == AMD_CG_STATE_GATE);
> break;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] drm/amdgpu: convert code name to ip version for athub
2022-01-27 1:48 [PATCH 1/2] drm/amdgpu: convert code name to ip version for athub Aaron Liu
2022-01-27 1:48 ` [PATCH 2/2] drm/amdgpu: add 1.3.1/2.4.0 athub CG support Aaron Liu
@ 2022-01-27 3:06 ` Alex Deucher
1 sibling, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2022-01-27 3:06 UTC (permalink / raw)
To: Aaron Liu; +Cc: Deucher, Alexander, Huang Rui, amd-gfx list
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
On Wed, Jan 26, 2022 at 8:49 PM Aaron Liu <aaron.liu@amd.com> wrote:
>
> Use IP version rather than codename for athub.
>
> Signed-off-by: Aaron Liu <aaron.liu@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/athub_v1_0.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/athub_v1_0.c b/drivers/gpu/drm/amd/amdgpu/athub_v1_0.c
> index 3ea557864320..88642e7ecdf4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/athub_v1_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/athub_v1_0.c
> @@ -68,12 +68,13 @@ int athub_v1_0_set_clockgating(struct amdgpu_device *adev,
> if (amdgpu_sriov_vf(adev))
> return 0;
>
> - switch (adev->asic_type) {
> - case CHIP_VEGA10:
> - case CHIP_VEGA12:
> - case CHIP_VEGA20:
> - case CHIP_RAVEN:
> - case CHIP_RENOIR:
> + switch (adev->ip_versions[ATHUB_HWIP][0]) {
> + case IP_VERSION(9, 0, 0):
> + case IP_VERSION(9, 1, 0):
> + case IP_VERSION(9, 2, 0):
> + case IP_VERSION(9, 3, 0):
> + case IP_VERSION(9, 4, 0):
> + case IP_VERSION(1, 5, 0):
> athub_update_medium_grain_clock_gating(adev,
> state == AMD_CG_STATE_GATE);
> athub_update_medium_grain_light_sleep(adev,
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] drm/amdgpu: add 1.3.1/2.4.0 athub CG support
2022-01-27 2:07 ` Huang Rui
@ 2022-01-27 3:07 ` Alex Deucher
0 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2022-01-27 3:07 UTC (permalink / raw)
To: Huang Rui; +Cc: Deucher, Alexander, Liu, Aaron, amd-gfx@lists.freedesktop.org
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
On Wed, Jan 26, 2022 at 9:07 PM Huang Rui <ray.huang@amd.com> wrote:
>
> On Thu, Jan 27, 2022 at 09:48:06AM +0800, Liu, Aaron wrote:
> > This patch adds 1.3.1/2.4.0 athub clock gating support.
> >
> > Signed-off-by: Aaron Liu <aaron.liu@amd.com>
>
> Series are Reviewed-by: Huang Rui <ray.huang@amd.com>
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/athub_v2_0.c | 1 +
> > drivers/gpu/drm/amd/amdgpu/athub_v2_1.c | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/athub_v2_0.c b/drivers/gpu/drm/amd/amdgpu/athub_v2_0.c
> > index ab6a07e5e8c4..a720436857b4 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/athub_v2_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/athub_v2_0.c
> > @@ -78,6 +78,7 @@ int athub_v2_0_set_clockgating(struct amdgpu_device *adev,
> > return 0;
> >
> > switch (adev->ip_versions[ATHUB_HWIP][0]) {
> > + case IP_VERSION(1, 3, 1):
> > case IP_VERSION(2, 0, 0):
> > case IP_VERSION(2, 0, 2):
> > athub_v2_0_update_medium_grain_clock_gating(adev,
> > diff --git a/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c b/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c
> > index 2edefd10e56c..ad8e87d3d2cb 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c
> > @@ -74,6 +74,7 @@ int athub_v2_1_set_clockgating(struct amdgpu_device *adev,
> > case IP_VERSION(2, 1, 0):
> > case IP_VERSION(2, 1, 1):
> > case IP_VERSION(2, 1, 2):
> > + case IP_VERSION(2, 4, 0):
> > athub_v2_1_update_medium_grain_clock_gating(adev, state == AMD_CG_STATE_GATE);
> > athub_v2_1_update_medium_grain_light_sleep(adev, state == AMD_CG_STATE_GATE);
> > break;
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-27 3:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-27 1:48 [PATCH 1/2] drm/amdgpu: convert code name to ip version for athub Aaron Liu
2022-01-27 1:48 ` [PATCH 2/2] drm/amdgpu: add 1.3.1/2.4.0 athub CG support Aaron Liu
2022-01-27 2:07 ` Huang Rui
2022-01-27 3:07 ` Alex Deucher
2022-01-27 3:06 ` [PATCH 1/2] drm/amdgpu: convert code name to ip version for athub Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.