From: kernel test robot <lkp@intel.com>
To: Kui-Feng Lee <kuifeng@fb.com>,
bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org
Cc: kbuild-all@lists.01.org, Kui-Feng Lee <kuifeng@fb.com>
Subject: Re: [PATCH bpf-next 5/5] bpf: Implement bpf_get_attach_cookie() for tracing programs.
Date: Thu, 27 Jan 2022 07:38:10 +0800 [thread overview]
Message-ID: <202201270704.kcMiWFUK-lkp@intel.com> (raw)
In-Reply-To: <20220126214809.3868787-6-kuifeng@fb.com>
Hi Kui-Feng,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Kui-Feng-Lee/Attach-a-cookie-to-a-tracing-program/20220127-054929
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: mips-allmodconfig (https://download.01.org/0day-ci/archive/20220127/202201270704.kcMiWFUK-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/6dffffc1fe68f386715b4ee396fb6a5c738fb065
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kui-Feng-Lee/Attach-a-cookie-to-a-tracing-program/20220127-054929
git checkout 6dffffc1fe68f386715b4ee396fb6a5c738fb065
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash kernel/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
kernel/trace/bpf_trace.c: In function '____bpf_get_attach_cookie_tracing':
>> kernel/trace/bpf_trace.c:1095:16: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
1095 | prog = (const struct bpf_prog *)((u64 *)ctx)[-off];
| ^
vim +1095 kernel/trace/bpf_trace.c
1086
1087 BPF_CALL_1(bpf_get_attach_cookie_tracing, void *, ctx)
1088 {
1089 const struct bpf_prog *prog;
1090 int off = get_trampo_var_off(ctx, BPF_TRAMP_F_PROG_ID);
1091
1092 if (off < 0)
1093 return 0;
1094
> 1095 prog = (const struct bpf_prog *)((u64 *)ctx)[-off];
1096
1097 return prog->aux->cookie;
1098 }
1099
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH bpf-next 5/5] bpf: Implement bpf_get_attach_cookie() for tracing programs.
Date: Thu, 27 Jan 2022 07:38:10 +0800 [thread overview]
Message-ID: <202201270704.kcMiWFUK-lkp@intel.com> (raw)
In-Reply-To: <20220126214809.3868787-6-kuifeng@fb.com>
[-- Attachment #1: Type: text/plain, Size: 2171 bytes --]
Hi Kui-Feng,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Kui-Feng-Lee/Attach-a-cookie-to-a-tracing-program/20220127-054929
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: mips-allmodconfig (https://download.01.org/0day-ci/archive/20220127/202201270704.kcMiWFUK-lkp(a)intel.com/config)
compiler: mips-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/6dffffc1fe68f386715b4ee396fb6a5c738fb065
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kui-Feng-Lee/Attach-a-cookie-to-a-tracing-program/20220127-054929
git checkout 6dffffc1fe68f386715b4ee396fb6a5c738fb065
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash kernel/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
kernel/trace/bpf_trace.c: In function '____bpf_get_attach_cookie_tracing':
>> kernel/trace/bpf_trace.c:1095:16: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
1095 | prog = (const struct bpf_prog *)((u64 *)ctx)[-off];
| ^
vim +1095 kernel/trace/bpf_trace.c
1086
1087 BPF_CALL_1(bpf_get_attach_cookie_tracing, void *, ctx)
1088 {
1089 const struct bpf_prog *prog;
1090 int off = get_trampo_var_off(ctx, BPF_TRAMP_F_PROG_ID);
1091
1092 if (off < 0)
1093 return 0;
1094
> 1095 prog = (const struct bpf_prog *)((u64 *)ctx)[-off];
1096
1097 return prog->aux->cookie;
1098 }
1099
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2022-01-26 23:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 21:48 [PATCH bpf-next 0/5] Attach a cookie to a tracing program Kui-Feng Lee
2022-01-26 21:48 ` [PATCH bpf-next 1/5] bpf: Add a flags value on trampoline frames Kui-Feng Lee
2022-01-26 21:48 ` [PATCH bpf-next 2/5] bpf: Detect if a program needs its program ID Kui-Feng Lee
2022-01-26 21:48 ` [PATCH bpf-next 3/5] bpf, x86: Store program ID to trampoline frames Kui-Feng Lee
2022-01-26 21:48 ` [PATCH bpf-next 4/5] bpf: Attach a cookie to a BPF program Kui-Feng Lee
2022-02-01 6:46 ` Andrii Nakryiko
2022-02-01 20:17 ` Alexei Starovoitov
2022-02-02 1:24 ` Andrii Nakryiko
2022-01-26 21:48 ` [PATCH bpf-next 5/5] bpf: Implement bpf_get_attach_cookie() for tracing programs Kui-Feng Lee
2022-01-26 23:38 ` kernel test robot [this message]
2022-01-26 23:38 ` kernel test robot
2022-01-27 5:17 ` [PATCH bpf-next 0/5] Attach a cookie to a tracing program Alexei Starovoitov
2022-01-31 16:56 ` Jiri Olsa
2022-02-01 6:45 ` Andrii Nakryiko
2022-02-01 17:37 ` Kui-Feng Lee
2022-02-02 1:06 ` Andrii Nakryiko
2022-02-01 19:32 ` Alexei Starovoitov
2022-02-02 1:15 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202201270704.kcMiWFUK-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kbuild-all@lists.01.org \
--cc=kuifeng@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.