From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v4 3/7] dm: make dm aware of target's DAXDEV_RECOVERY capability
Date: Thu, 27 Jan 2022 09:00:41 +0800 [thread overview]
Message-ID: <202201270825.tnq9gZBS-lkp@intel.com> (raw)
In-Reply-To: <20220126211116.860012-4-jane.chu@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 7431 bytes --]
Hi Jane,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on nvdimm/libnvdimm-for-next]
[also build test WARNING on linus/master v5.17-rc1 next-20220125]
[cannot apply to device-mapper-dm/for-next tip/x86/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jane-Chu/DAX-poison-recovery/20220127-051422
base: https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git libnvdimm-for-next
config: sparc-randconfig-r016-20220124 (https://download.01.org/0day-ci/archive/20220127/202201270825.tnq9gZBS-lkp(a)intel.com/config)
compiler: sparc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/d0d9fe574c3407067bc83410d0eaf8a89e21454c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jane-Chu/DAX-poison-recovery/20220127-051422
git checkout d0d9fe574c3407067bc83410d0eaf8a89e21454c
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sparc SHELL=/bin/bash drivers/md/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/md/dm-table.c:24:
include/linux/dax.h:93:1: error: expected identifier or '(' before '{' token
93 | {
| ^
>> include/linux/dax.h:92:20: warning: 'set_dax_recovery' used but never defined
92 | static inline void set_dax_recovery(struct dax_device *dax_dev);
| ^~~~~~~~~~~~~~~~
vim +/set_dax_recovery +92 include/linux/dax.h
a254e568128804 Christoph Hellwig 2016-09-19 34
f5705aa8cfed14 Dan Williams 2017-05-13 35 #if IS_ENABLED(CONFIG_DAX)
30c6828a17a572 Christoph Hellwig 2021-12-15 36 struct dax_device *alloc_dax(void *private, const struct dax_operations *ops);
f5705aa8cfed14 Dan Williams 2017-05-13 37 void put_dax(struct dax_device *dax_dev);
976431b02c2ef9 Dan Williams 2018-03-29 38 void kill_dax(struct dax_device *dax_dev);
976431b02c2ef9 Dan Williams 2018-03-29 39 void dax_write_cache(struct dax_device *dax_dev, bool wc);
976431b02c2ef9 Dan Williams 2018-03-29 40 bool dax_write_cache_enabled(struct dax_device *dax_dev);
fd1d00ec92002d Christoph Hellwig 2021-12-15 41 bool dax_synchronous(struct dax_device *dax_dev);
fd1d00ec92002d Christoph Hellwig 2021-12-15 42 void set_dax_synchronous(struct dax_device *dax_dev);
bd070965ec17cd Jane Chu 2022-01-26 43 void set_dax_recovery(struct dax_device *dax_dev);
bd070965ec17cd Jane Chu 2022-01-26 44 bool dax_recovery_capable(struct dax_device *dax_dev);
32de1484648a83 Pankaj Gupta 2019-07-05 45 /*
32de1484648a83 Pankaj Gupta 2019-07-05 46 * Check if given mapping is supported by the file / underlying device.
32de1484648a83 Pankaj Gupta 2019-07-05 47 */
32de1484648a83 Pankaj Gupta 2019-07-05 48 static inline bool daxdev_mapping_supported(struct vm_area_struct *vma,
32de1484648a83 Pankaj Gupta 2019-07-05 49 struct dax_device *dax_dev)
32de1484648a83 Pankaj Gupta 2019-07-05 50 {
32de1484648a83 Pankaj Gupta 2019-07-05 51 if (!(vma->vm_flags & VM_SYNC))
32de1484648a83 Pankaj Gupta 2019-07-05 52 return true;
32de1484648a83 Pankaj Gupta 2019-07-05 53 if (!IS_DAX(file_inode(vma->vm_file)))
32de1484648a83 Pankaj Gupta 2019-07-05 54 return false;
32de1484648a83 Pankaj Gupta 2019-07-05 55 return dax_synchronous(dax_dev);
32de1484648a83 Pankaj Gupta 2019-07-05 56 }
f5705aa8cfed14 Dan Williams 2017-05-13 57 #else
fb08a1908cb119 Christoph Hellwig 2021-11-29 58 static inline struct dax_device *alloc_dax(void *private,
30c6828a17a572 Christoph Hellwig 2021-12-15 59 const struct dax_operations *ops)
976431b02c2ef9 Dan Williams 2018-03-29 60 {
976431b02c2ef9 Dan Williams 2018-03-29 61 /*
976431b02c2ef9 Dan Williams 2018-03-29 62 * Callers should check IS_ENABLED(CONFIG_DAX) to know if this
976431b02c2ef9 Dan Williams 2018-03-29 63 * NULL is an error or expected.
976431b02c2ef9 Dan Williams 2018-03-29 64 */
976431b02c2ef9 Dan Williams 2018-03-29 65 return NULL;
976431b02c2ef9 Dan Williams 2018-03-29 66 }
f5705aa8cfed14 Dan Williams 2017-05-13 67 static inline void put_dax(struct dax_device *dax_dev)
f5705aa8cfed14 Dan Williams 2017-05-13 68 {
f5705aa8cfed14 Dan Williams 2017-05-13 69 }
976431b02c2ef9 Dan Williams 2018-03-29 70 static inline void kill_dax(struct dax_device *dax_dev)
976431b02c2ef9 Dan Williams 2018-03-29 71 {
976431b02c2ef9 Dan Williams 2018-03-29 72 }
976431b02c2ef9 Dan Williams 2018-03-29 73 static inline void dax_write_cache(struct dax_device *dax_dev, bool wc)
976431b02c2ef9 Dan Williams 2018-03-29 74 {
976431b02c2ef9 Dan Williams 2018-03-29 75 }
976431b02c2ef9 Dan Williams 2018-03-29 76 static inline bool dax_write_cache_enabled(struct dax_device *dax_dev)
976431b02c2ef9 Dan Williams 2018-03-29 77 {
976431b02c2ef9 Dan Williams 2018-03-29 78 return false;
976431b02c2ef9 Dan Williams 2018-03-29 79 }
fefc1d97fa4b5e Pankaj Gupta 2019-07-05 80 static inline bool dax_synchronous(struct dax_device *dax_dev)
fefc1d97fa4b5e Pankaj Gupta 2019-07-05 81 {
fefc1d97fa4b5e Pankaj Gupta 2019-07-05 82 return true;
fefc1d97fa4b5e Pankaj Gupta 2019-07-05 83 }
fefc1d97fa4b5e Pankaj Gupta 2019-07-05 84 static inline void set_dax_synchronous(struct dax_device *dax_dev)
fefc1d97fa4b5e Pankaj Gupta 2019-07-05 85 {
fefc1d97fa4b5e Pankaj Gupta 2019-07-05 86 }
32de1484648a83 Pankaj Gupta 2019-07-05 87 static inline bool daxdev_mapping_supported(struct vm_area_struct *vma,
32de1484648a83 Pankaj Gupta 2019-07-05 88 struct dax_device *dax_dev)
32de1484648a83 Pankaj Gupta 2019-07-05 89 {
32de1484648a83 Pankaj Gupta 2019-07-05 90 return !(vma->vm_flags & VM_SYNC);
32de1484648a83 Pankaj Gupta 2019-07-05 91 }
bd070965ec17cd Jane Chu 2022-01-26 @92 static inline void set_dax_recovery(struct dax_device *dax_dev);
bd070965ec17cd Jane Chu 2022-01-26 93 {
bd070965ec17cd Jane Chu 2022-01-26 94 }
bd070965ec17cd Jane Chu 2022-01-26 95 static inline bool dax_recovery_capable(struct dax_device *dax_dev)
bd070965ec17cd Jane Chu 2022-01-26 96 {
bd070965ec17cd Jane Chu 2022-01-26 97 return false;
bd070965ec17cd Jane Chu 2022-01-26 98 }
f5705aa8cfed14 Dan Williams 2017-05-13 99 #endif
f5705aa8cfed14 Dan Williams 2017-05-13 100
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2022-01-27 1:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 21:11 [dm-devel] [PATCH v4 0/7] DAX poison recovery Jane Chu
2022-01-26 21:11 ` Jane Chu
2022-01-26 21:11 ` [dm-devel] [PATCH v4 1/7] mce: fix set_mce_nospec to always unmap the whole page Jane Chu
2022-01-26 21:11 ` Jane Chu
2022-01-26 21:11 ` [dm-devel] [PATCH v4 2/7] dax: introduce dax device flag DAXDEV_RECOVERY Jane Chu
2022-01-26 21:11 ` Jane Chu
2022-01-27 0:19 ` kernel test robot
2022-01-27 0:19 ` kernel test robot
2022-01-26 21:11 ` [dm-devel] [PATCH v4 3/7] dm: make dm aware of target's DAXDEV_RECOVERY capability Jane Chu
2022-01-26 21:11 ` Jane Chu
2022-01-27 1:00 ` kernel test robot [this message]
2022-01-26 21:11 ` [dm-devel] [PATCH v4 4/7] dax: add dax_recovery_write to dax_op and dm target type Jane Chu
2022-01-26 21:11 ` Jane Chu
2022-01-26 21:11 ` [dm-devel] [PATCH v4 5/7] pmem: add pmem_recovery_write() dax op Jane Chu
2022-01-26 21:11 ` Jane Chu
2022-01-26 21:11 ` [dm-devel] [PATCH v4 6/7] dax: add recovery_write to dax_iomap_iter in failure path Jane Chu
2022-01-26 21:11 ` Jane Chu
2022-01-26 21:11 ` [dm-devel] [PATCH v4 7/7] pmem: fix pmem_do_write() avoid writing to 'np' page Jane Chu
2022-01-26 21:11 ` Jane Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202201270825.tnq9gZBS-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.