Re: [PATCH v4 2/7] dax: introduce dax device flag DAXDEV_RECOVERY

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4561 bytes --]

Hi Jane,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on nvdimm/libnvdimm-for-next]
[also build test ERROR on linus/master v5.17-rc1 next-20220125]
[cannot apply to device-mapper-dm/for-next tip/x86/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jane-Chu/DAX-poison-recovery/20220127-051422
base:   https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git libnvdimm-for-next
config: nds32-randconfig-r014-20220126 (https://download.01.org/0day-ci/archive/20220127/202201270832.QbtGQhvr-lkp(a)intel.com/config)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/bd070965ec17cd8d846ff43321aef2c9f34bba5a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jane-Chu/DAX-poison-recovery/20220127-051422
        git checkout bd070965ec17cd8d846ff43321aef2c9f34bba5a
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nds32 SHELL=/bin/bash drivers/md/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from drivers/md/dm-log-writes.c:13:
>> include/linux/dax.h:93:1: error: expected identifier or '(' before '{' token
      93 | {
         | ^
   include/linux/dax.h:92:20: warning: 'set_dax_recovery' declared 'static' but never defined [-Wunused-function]
      92 | static inline void set_dax_recovery(struct dax_device *dax_dev);
         |                    ^~~~~~~~~~~~~~~~


vim +93 include/linux/dax.h

    34	
    35	#if IS_ENABLED(CONFIG_DAX)
    36	struct dax_device *alloc_dax(void *private, const struct dax_operations *ops);
    37	void put_dax(struct dax_device *dax_dev);
    38	void kill_dax(struct dax_device *dax_dev);
    39	void dax_write_cache(struct dax_device *dax_dev, bool wc);
    40	bool dax_write_cache_enabled(struct dax_device *dax_dev);
    41	bool dax_synchronous(struct dax_device *dax_dev);
    42	void set_dax_synchronous(struct dax_device *dax_dev);
    43	void set_dax_recovery(struct dax_device *dax_dev);
    44	bool dax_recovery_capable(struct dax_device *dax_dev);
    45	/*
    46	 * Check if given mapping is supported by the file / underlying device.
    47	 */
    48	static inline bool daxdev_mapping_supported(struct vm_area_struct *vma,
    49						     struct dax_device *dax_dev)
    50	{
    51		if (!(vma->vm_flags & VM_SYNC))
    52			return true;
    53		if (!IS_DAX(file_inode(vma->vm_file)))
    54			return false;
    55		return dax_synchronous(dax_dev);
    56	}
    57	#else
    58	static inline struct dax_device *alloc_dax(void *private,
    59			const struct dax_operations *ops)
    60	{
    61		/*
    62		 * Callers should check IS_ENABLED(CONFIG_DAX) to know if this
    63		 * NULL is an error or expected.
    64		 */
    65		return NULL;
    66	}
    67	static inline void put_dax(struct dax_device *dax_dev)
    68	{
    69	}
    70	static inline void kill_dax(struct dax_device *dax_dev)
    71	{
    72	}
    73	static inline void dax_write_cache(struct dax_device *dax_dev, bool wc)
    74	{
    75	}
    76	static inline bool dax_write_cache_enabled(struct dax_device *dax_dev)
    77	{
    78		return false;
    79	}
    80	static inline bool dax_synchronous(struct dax_device *dax_dev)
    81	{
    82		return true;
    83	}
    84	static inline void set_dax_synchronous(struct dax_device *dax_dev)
    85	{
    86	}
    87	static inline bool daxdev_mapping_supported(struct vm_area_struct *vma,
    88					struct dax_device *dax_dev)
    89	{
    90		return !(vma->vm_flags & VM_SYNC);
    91	}
    92	static inline void set_dax_recovery(struct dax_device *dax_dev);
  > 93	{
    94	}
    95	static inline bool dax_recovery_capable(struct dax_device *dax_dev)
    96	{
    97		return false;
    98	}
    99	#endif
   100	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org