All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	Philipp Reisner <philipp.reisner@linbit.com>,
	Pavel Begunkov <asml.silence@gmail.com>,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	Lars Ellenberg <lars.ellenberg@linbit.com>,
	Christoph Hellwig <hch@lst.de>,
	drbd-dev@lists.linbit.com
Subject: Re: [dm-devel] improve the bio cloning interface
Date: Thu, 27 Jan 2022 20:58:34 +0100	[thread overview]
Message-ID: <20220127195834.GA25235@lst.de> (raw)
In-Reply-To: <YfLN4/2bYe4hebCy@redhat.com>

On Thu, Jan 27, 2022 at 11:52:51AM -0500, Mike Snitzer wrote:
> I'd like to take a closer look, do you happen to have this series
> available in a git branch?

git://git.infradead.org/users/hch/block.git bio_alloc-cleanup-part2

> 
> The changes generally look fine.  Any chance you could forecast what
> you're planning for follow-on changes?

Mostly cleaning up a bunch of submitter code that needs more work to
get at the bdev and op, and trying to figure out what to do about
bio_kmalloc.

> Or is it best to just wait for you to produce those follow-on changes?

There should be no follow ons required to make sense of this series.

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	Pavel Begunkov <asml.silence@gmail.com>,
	Philipp Reisner <philipp.reisner@linbit.com>,
	Lars Ellenberg <lars.ellenberg@linbit.com>,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	drbd-dev@lists.linbit.com
Subject: Re: improve the bio cloning interface
Date: Thu, 27 Jan 2022 20:58:34 +0100	[thread overview]
Message-ID: <20220127195834.GA25235@lst.de> (raw)
In-Reply-To: <YfLN4/2bYe4hebCy@redhat.com>

On Thu, Jan 27, 2022 at 11:52:51AM -0500, Mike Snitzer wrote:
> I'd like to take a closer look, do you happen to have this series
> available in a git branch?

git://git.infradead.org/users/hch/block.git bio_alloc-cleanup-part2

> 
> The changes generally look fine.  Any chance you could forecast what
> you're planning for follow-on changes?

Mostly cleaning up a bunch of submitter code that needs more work to
get at the bdev and op, and trying to figure out what to do about
bio_kmalloc.

> Or is it best to just wait for you to produce those follow-on changes?

There should be no follow ons required to make sense of this series.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	Philipp Reisner <philipp.reisner@linbit.com>,
	Pavel Begunkov <asml.silence@gmail.com>,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	Lars Ellenberg <lars.ellenberg@linbit.com>,
	Christoph Hellwig <hch@lst.de>,
	drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] improve the bio cloning interface
Date: Thu, 27 Jan 2022 20:58:34 +0100	[thread overview]
Message-ID: <20220127195834.GA25235@lst.de> (raw)
In-Reply-To: <YfLN4/2bYe4hebCy@redhat.com>

On Thu, Jan 27, 2022 at 11:52:51AM -0500, Mike Snitzer wrote:
> I'd like to take a closer look, do you happen to have this series
> available in a git branch?

git://git.infradead.org/users/hch/block.git bio_alloc-cleanup-part2

> 
> The changes generally look fine.  Any chance you could forecast what
> you're planning for follow-on changes?

Mostly cleaning up a bunch of submitter code that needs more work to
get at the bdev and op, and trying to figure out what to do about
bio_kmalloc.

> Or is it best to just wait for you to produce those follow-on changes?

There should be no follow ons required to make sense of this series.

  reply	other threads:[~2022-01-27 19:58 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27  6:35 [dm-devel] improve the bio cloning interface Christoph Hellwig
2022-01-27  6:35 ` [Drbd-dev] " Christoph Hellwig
2022-01-27  6:35 ` Christoph Hellwig
2022-01-27  6:35 ` [dm-devel] [PATCH 01/14] drbd: set ->bi_bdev in drbd_req_new Christoph Hellwig
2022-01-27  6:35   ` [Drbd-dev] " Christoph Hellwig
2022-01-27  6:35   ` Christoph Hellwig
2022-01-27  6:35 ` [dm-devel] [PATCH 02/14] dm: add a clone_to_tio helper Christoph Hellwig
2022-01-27  6:35   ` [Drbd-dev] " Christoph Hellwig
2022-01-27  6:35   ` Christoph Hellwig
2022-01-27  6:35 ` [dm-devel] [PATCH 03/14] dm: fold clone_bio into __clone_and_map_data_bio Christoph Hellwig
2022-01-27  6:35   ` [Drbd-dev] " Christoph Hellwig
2022-01-27  6:35   ` Christoph Hellwig
2022-01-27  6:35 ` [dm-devel] [PATCH 04/14] dm: fold __send_duplicate_bios into __clone_and_map_simple_bio Christoph Hellwig
2022-01-27  6:35   ` [Drbd-dev] " Christoph Hellwig
2022-01-27  6:35   ` Christoph Hellwig
2022-01-27  6:35 ` [dm-devel] [PATCH 05/14] dm: move cloning the bio into alloc_tio Christoph Hellwig
2022-01-27  6:35   ` [Drbd-dev] " Christoph Hellwig
2022-01-27  6:35   ` Christoph Hellwig
2022-01-27  6:35 ` [dm-devel] [PATCH 06/14] dm: pass the bio instead of tio to __map_bio Christoph Hellwig
2022-01-27  6:35   ` [Drbd-dev] " Christoph Hellwig
2022-01-27  6:35   ` Christoph Hellwig
2022-01-27  6:35 ` [dm-devel] [PATCH 07/14] dm: retun the clone bio from alloc_tio Christoph Hellwig
2022-01-27  6:35   ` [Drbd-dev] " Christoph Hellwig
2022-01-27  6:35   ` Christoph Hellwig
2022-01-27  6:35 ` [dm-devel] [PATCH 08/14] dm: simplify the single bio fast path in __send_duplicate_bios Christoph Hellwig
2022-01-27  6:35   ` [Drbd-dev] " Christoph Hellwig
2022-01-27  6:35   ` Christoph Hellwig
2022-01-27  6:35 ` [dm-devel] [PATCH 09/14] dm: add a missing bio initialization to alloc_tio Christoph Hellwig
2022-01-27  6:35   ` [Drbd-dev] " Christoph Hellwig
2022-01-27  6:35   ` Christoph Hellwig
2022-01-29  5:06   ` [dm-devel] [dm] 3826813630: BUG:KASAN:double-free_or_invalid-free_in_dm_io_dec_pending kernel test robot
2022-01-29  5:06     ` kernel test robot
2022-01-29  5:06     ` [Drbd-dev] " kernel test robot
2022-01-29  5:06     ` kernel test robot
2022-01-27  6:35 ` [dm-devel] [PATCH 10/14] dm-cache: remove __remap_to_origin_clear_discard Christoph Hellwig
2022-01-27  6:35   ` [Drbd-dev] " Christoph Hellwig
2022-01-27  6:35   ` Christoph Hellwig
2022-01-27  6:35 ` [dm-devel] [PATCH 11/14] block: clone crypto and integrity data in __bio_clone_fast Christoph Hellwig
2022-01-27  6:35   ` [Drbd-dev] " Christoph Hellwig
2022-01-27  6:35   ` Christoph Hellwig
2022-01-27  6:35 ` [dm-devel] [PATCH 12/14] dm: use bio_clone_fast in alloc_tio Christoph Hellwig
2022-01-27  6:35   ` [Drbd-dev] " Christoph Hellwig
2022-01-27  6:35   ` Christoph Hellwig
2022-01-27  6:35 ` [dm-devel] [PATCH 13/14] block: initialize the target bio in __bio_clone_fast Christoph Hellwig
2022-01-27  6:35   ` [Drbd-dev] " Christoph Hellwig
2022-01-27  6:35   ` Christoph Hellwig
2022-01-27  6:35 ` [dm-devel] [PATCH 14/14] block: pass a block_device to bio_clone_fast Christoph Hellwig
2022-01-27  6:35   ` [Drbd-dev] " Christoph Hellwig
2022-01-27  6:35   ` Christoph Hellwig
2022-01-27 16:52 ` [dm-devel] improve the bio cloning interface Mike Snitzer
2022-01-27 16:52   ` [Drbd-dev] " Mike Snitzer
2022-01-27 16:52   ` Mike Snitzer
2022-01-27 19:58   ` Christoph Hellwig [this message]
2022-01-27 19:58     ` [Drbd-dev] " Christoph Hellwig
2022-01-27 19:58     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220127195834.GA25235@lst.de \
    --to=hch@lst.de \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=lars.ellenberg@linbit.com \
    --cc=linux-block@vger.kernel.org \
    --cc=philipp.reisner@linbit.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.