From: kernel test robot <lkp@intel.com>
To: "D. Wythe" <alibuda@linux.alibaba.com>, kgraul@linux.ibm.com
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, kuba@kernel.org,
davem@davemloft.net, netdev@vger.kernel.org,
linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org,
"D. Wythe" <alibuda@linux.alibaba.com>
Subject: Re: [PATCH net-next 2/3] net/smc: Limits backlog connections
Date: Thu, 27 Jan 2022 23:52:55 +0800 [thread overview]
Message-ID: <202201272328.JtsPKLkq-lkp@intel.com> (raw)
In-Reply-To: <9b52fc3f11a2ae6f23224a178fd4cff9f9dd4eaa.1643284658.git.alibuda@linux.alibaba.com>
Hi Wythe",
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/D-Wythe/Optimizing-performance-in-short-lived/20220127-200912
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git fbb8295248e1d6f576d444309fcf79356008eac1
config: mips-buildonly-randconfig-r004-20220124 (https://download.01.org/0day-ci/archive/20220127/202201272328.JtsPKLkq-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project f32dccb9a43b02ce4e540d6ba5dbbdb188f2dc7d)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://github.com/0day-ci/linux/commit/718aff24f3fcc73ecb7bff17fcbe029b799c6624
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review D-Wythe/Optimizing-performance-in-short-lived/20220127-200912
git checkout 718aff24f3fcc73ecb7bff17fcbe029b799c6624
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash arch/mips/kernel/ net/smc/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> net/smc/af_smc.c:2202:18: error: assigning to 'struct inet_connection_sock_af_ops *' from 'const struct inet_connection_sock_af_ops *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
smc->ori_af_ops = inet_csk(smc->clcsock->sk)->icsk_af_ops;
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
vim +2202 net/smc/af_smc.c
2166
2167 static int smc_listen(struct socket *sock, int backlog)
2168 {
2169 struct sock *sk = sock->sk;
2170 struct smc_sock *smc;
2171 int rc;
2172
2173 smc = smc_sk(sk);
2174 lock_sock(sk);
2175
2176 rc = -EINVAL;
2177 if ((sk->sk_state != SMC_INIT && sk->sk_state != SMC_LISTEN) ||
2178 smc->connect_nonblock)
2179 goto out;
2180
2181 rc = 0;
2182 if (sk->sk_state == SMC_LISTEN) {
2183 sk->sk_max_ack_backlog = backlog;
2184 goto out;
2185 }
2186 /* some socket options are handled in core, so we could not apply
2187 * them to the clc socket -- copy smc socket options to clc socket
2188 */
2189 smc_copy_sock_settings_to_clc(smc);
2190 if (!smc->use_fallback)
2191 tcp_sk(smc->clcsock->sk)->syn_smc = 1;
2192
2193 /* save original sk_data_ready function and establish
2194 * smc-specific sk_data_ready function
2195 */
2196 smc->clcsk_data_ready = smc->clcsock->sk->sk_data_ready;
2197 smc->clcsock->sk->sk_data_ready = smc_clcsock_data_ready;
2198 smc->clcsock->sk->sk_user_data =
2199 (void *)((uintptr_t)smc | SK_USER_DATA_NOCOPY);
2200
2201 /* save origin ops */
> 2202 smc->ori_af_ops = inet_csk(smc->clcsock->sk)->icsk_af_ops;
2203
2204 smc->af_ops = *smc->ori_af_ops;
2205 smc->af_ops.syn_recv_sock = smc_tcp_syn_recv_sock;
2206
2207 inet_csk(smc->clcsock->sk)->icsk_af_ops = &smc->af_ops;
2208
2209 rc = kernel_listen(smc->clcsock, backlog);
2210 if (rc) {
2211 smc->clcsock->sk->sk_data_ready = smc->clcsk_data_ready;
2212 goto out;
2213 }
2214 sk->sk_max_ack_backlog = backlog;
2215 sk->sk_ack_backlog = 0;
2216 sk->sk_state = SMC_LISTEN;
2217
2218 out:
2219 release_sock(sk);
2220 return rc;
2221 }
2222
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH net-next 2/3] net/smc: Limits backlog connections
Date: Thu, 27 Jan 2022 23:52:55 +0800 [thread overview]
Message-ID: <202201272328.JtsPKLkq-lkp@intel.com> (raw)
In-Reply-To: <9b52fc3f11a2ae6f23224a178fd4cff9f9dd4eaa.1643284658.git.alibuda@linux.alibaba.com>
[-- Attachment #1: Type: text/plain, Size: 3981 bytes --]
Hi Wythe",
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/D-Wythe/Optimizing-performance-in-short-lived/20220127-200912
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git fbb8295248e1d6f576d444309fcf79356008eac1
config: mips-buildonly-randconfig-r004-20220124 (https://download.01.org/0day-ci/archive/20220127/202201272328.JtsPKLkq-lkp(a)intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project f32dccb9a43b02ce4e540d6ba5dbbdb188f2dc7d)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://github.com/0day-ci/linux/commit/718aff24f3fcc73ecb7bff17fcbe029b799c6624
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review D-Wythe/Optimizing-performance-in-short-lived/20220127-200912
git checkout 718aff24f3fcc73ecb7bff17fcbe029b799c6624
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash arch/mips/kernel/ net/smc/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> net/smc/af_smc.c:2202:18: error: assigning to 'struct inet_connection_sock_af_ops *' from 'const struct inet_connection_sock_af_ops *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
smc->ori_af_ops = inet_csk(smc->clcsock->sk)->icsk_af_ops;
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
vim +2202 net/smc/af_smc.c
2166
2167 static int smc_listen(struct socket *sock, int backlog)
2168 {
2169 struct sock *sk = sock->sk;
2170 struct smc_sock *smc;
2171 int rc;
2172
2173 smc = smc_sk(sk);
2174 lock_sock(sk);
2175
2176 rc = -EINVAL;
2177 if ((sk->sk_state != SMC_INIT && sk->sk_state != SMC_LISTEN) ||
2178 smc->connect_nonblock)
2179 goto out;
2180
2181 rc = 0;
2182 if (sk->sk_state == SMC_LISTEN) {
2183 sk->sk_max_ack_backlog = backlog;
2184 goto out;
2185 }
2186 /* some socket options are handled in core, so we could not apply
2187 * them to the clc socket -- copy smc socket options to clc socket
2188 */
2189 smc_copy_sock_settings_to_clc(smc);
2190 if (!smc->use_fallback)
2191 tcp_sk(smc->clcsock->sk)->syn_smc = 1;
2192
2193 /* save original sk_data_ready function and establish
2194 * smc-specific sk_data_ready function
2195 */
2196 smc->clcsk_data_ready = smc->clcsock->sk->sk_data_ready;
2197 smc->clcsock->sk->sk_data_ready = smc_clcsock_data_ready;
2198 smc->clcsock->sk->sk_user_data =
2199 (void *)((uintptr_t)smc | SK_USER_DATA_NOCOPY);
2200
2201 /* save origin ops */
> 2202 smc->ori_af_ops = inet_csk(smc->clcsock->sk)->icsk_af_ops;
2203
2204 smc->af_ops = *smc->ori_af_ops;
2205 smc->af_ops.syn_recv_sock = smc_tcp_syn_recv_sock;
2206
2207 inet_csk(smc->clcsock->sk)->icsk_af_ops = &smc->af_ops;
2208
2209 rc = kernel_listen(smc->clcsock, backlog);
2210 if (rc) {
2211 smc->clcsock->sk->sk_data_ready = smc->clcsk_data_ready;
2212 goto out;
2213 }
2214 sk->sk_max_ack_backlog = backlog;
2215 sk->sk_ack_backlog = 0;
2216 sk->sk_state = SMC_LISTEN;
2217
2218 out:
2219 release_sock(sk);
2220 return rc;
2221 }
2222
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2022-01-27 15:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 12:08 [PATCH net-next 0/3] Optimizing performance in short-lived D. Wythe
2022-01-27 12:08 ` [PATCH net-next 1/3] net/smc: Make smc_tcp_listen_work() independent D. Wythe
2022-01-27 12:08 ` [PATCH net-next 2/3] net/smc: Limits backlog connections D. Wythe
2022-01-27 15:52 ` kernel test robot
2022-01-27 15:52 ` kernel test robot
2022-01-27 15:52 ` kernel test robot [this message]
2022-01-27 15:52 ` kernel test robot
2022-01-27 23:23 ` kernel test robot
2022-01-27 23:23 ` kernel test robot
2022-01-27 12:08 ` [PATCH net-next 3/3] net/smc: Fallback when handshake workqueue congested D. Wythe
2022-01-27 17:09 ` Matthieu Baerts
2022-01-28 13:54 ` D. Wythe
2022-01-28 14:05 ` D. Wythe
2022-01-28 7:17 ` Tony Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202201272328.JtsPKLkq-lkp@intel.com \
--to=lkp@intel.com \
--cc=alibuda@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=kbuild-all@lists.01.org \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.