From: Christoph Hellwig <hch@lst.de>
To: Mike Snitzer <snitzer@redhat.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
dm-devel@redhat.com, hch@lst.de
Subject: Re: [dm-devel] [PATCH v3 1/3] block: add bio_start_io_acct_time() to control start_time
Date: Fri, 28 Jan 2022 07:13:08 +0100 [thread overview]
Message-ID: <20220128061308.GA1477@lst.de> (raw)
In-Reply-To: <20220128041753.32195-2-snitzer@redhat.com>
On Thu, Jan 27, 2022 at 11:17:51PM -0500, Mike Snitzer wrote:
> + __part_start_io_acct(bio->bi_bdev, bio_sectors(bio),
> + bio_op(bio), start_time);
> }
> +EXPORT_SYMBOL_GPL(bio_start_io_acct_time);
>
> /**
> * bio_start_io_acct - start I/O accounting for bio based drivers
> @@ -1084,14 +1096,15 @@ static unsigned long __part_start_io_acct(struct block_device *part,
> */
> unsigned long bio_start_io_acct(struct bio *bio)
> {
> - return __part_start_io_acct(bio->bi_bdev, bio_sectors(bio), bio_op(bio));
> + return __part_start_io_acct(bio->bi_bdev, bio_sectors(bio),
> + bio_op(bio), jiffies);
Is droppingthe READ_ONCE safe here? This is a honest question as these
helpers still confuse me.
The rest looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Mike Snitzer <snitzer@redhat.com>
Cc: axboe@kernel.dk, hch@lst.de, dm-devel@redhat.com,
linux-block@vger.kernel.org
Subject: Re: [PATCH v3 1/3] block: add bio_start_io_acct_time() to control start_time
Date: Fri, 28 Jan 2022 07:13:08 +0100 [thread overview]
Message-ID: <20220128061308.GA1477@lst.de> (raw)
In-Reply-To: <20220128041753.32195-2-snitzer@redhat.com>
On Thu, Jan 27, 2022 at 11:17:51PM -0500, Mike Snitzer wrote:
> + __part_start_io_acct(bio->bi_bdev, bio_sectors(bio),
> + bio_op(bio), start_time);
> }
> +EXPORT_SYMBOL_GPL(bio_start_io_acct_time);
>
> /**
> * bio_start_io_acct - start I/O accounting for bio based drivers
> @@ -1084,14 +1096,15 @@ static unsigned long __part_start_io_acct(struct block_device *part,
> */
> unsigned long bio_start_io_acct(struct bio *bio)
> {
> - return __part_start_io_acct(bio->bi_bdev, bio_sectors(bio), bio_op(bio));
> + return __part_start_io_acct(bio->bi_bdev, bio_sectors(bio),
> + bio_op(bio), jiffies);
Is droppingthe READ_ONCE safe here? This is a honest question as these
helpers still confuse me.
The rest looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-01-28 6:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 4:17 [dm-devel] [PATCH v3 0/3] block/dm: fix bio-based DM IO accounting Mike Snitzer
2022-01-28 4:17 ` Mike Snitzer
2022-01-28 4:17 ` [dm-devel] [PATCH v3 1/3] block: add bio_start_io_acct_time() to control start_time Mike Snitzer
2022-01-28 4:17 ` Mike Snitzer
2022-01-28 6:13 ` Christoph Hellwig [this message]
2022-01-28 6:13 ` Christoph Hellwig
2022-01-28 15:16 ` [dm-devel] " Mike Snitzer
2022-01-28 15:16 ` Mike Snitzer
2022-01-28 4:17 ` [dm-devel] [PATCH v3 2/3] dm: revert partial fix for redundant bio-based IO accounting Mike Snitzer
2022-01-28 4:17 ` Mike Snitzer
2022-01-28 4:17 ` [dm-devel] [PATCH v3 3/3] dm: properly fix " Mike Snitzer
2022-01-28 4:17 ` Mike Snitzer
2022-01-28 6:14 ` [dm-devel] " Christoph Hellwig
2022-01-28 6:14 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220128061308.GA1477@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.