From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH 1/2] ASoC: ops: fix signedness bug in snd_soc_put_volsw()
Date: Fri, 28 Jan 2022 16:31:47 +0300 [thread overview]
Message-ID: <20220128133147.GL1978@kadam> (raw)
In-Reply-To: <YfPknO6si9CpotgS@sirena.org.uk>
On Fri, Jan 28, 2022 at 12:42:04PM +0000, Mark Brown wrote:
> On Fri, Jan 28, 2022 at 02:20:07PM +0300, Dan Carpenter wrote:
> > The "val" and "val2" variables need to signed for the checking to work
> > as intended.
>
> This means that the helpers won't support controls that use the top bit
> of a 32 bit register.
Fine, I can delete the checks for negative instead (I'm surprised you
haven't already received a dozen bot emails about this).
I haven't been able to figure out where mc->min/max are set. In
snd_soc_get_xr_sx() it checks whether "mc->min" is negative.
if (min < 0 && val > max)
val |= ~mask;
Is that a bug? If mc->min is negative the math gets tricky.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: ops: fix signedness bug in snd_soc_put_volsw()
Date: Fri, 28 Jan 2022 16:31:47 +0300 [thread overview]
Message-ID: <20220128133147.GL1978@kadam> (raw)
In-Reply-To: <YfPknO6si9CpotgS@sirena.org.uk>
On Fri, Jan 28, 2022 at 12:42:04PM +0000, Mark Brown wrote:
> On Fri, Jan 28, 2022 at 02:20:07PM +0300, Dan Carpenter wrote:
> > The "val" and "val2" variables need to signed for the checking to work
> > as intended.
>
> This means that the helpers won't support controls that use the top bit
> of a 32 bit register.
Fine, I can delete the checks for negative instead (I'm surprised you
haven't already received a dozen bot emails about this).
I haven't been able to figure out where mc->min/max are set. In
snd_soc_get_xr_sx() it checks whether "mc->min" is negative.
if (min < 0 && val > max)
val |= ~mask;
Is that a bug? If mc->min is negative the math gets tricky.
regards,
dan carpenter
next prev parent reply other threads:[~2022-01-28 13:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 11:20 [PATCH 1/2] ASoC: ops: fix signedness bug in snd_soc_put_volsw() Dan Carpenter
2022-01-28 11:20 ` Dan Carpenter
2022-01-28 11:20 ` [PATCH 2/2] ASoC: ops: Fix signedness bug in snd_soc_put_volsw_sx() Dan Carpenter
2022-01-28 11:20 ` Dan Carpenter
2022-01-28 12:42 ` [PATCH 1/2] ASoC: ops: fix signedness bug in snd_soc_put_volsw() Mark Brown
2022-01-28 12:42 ` Mark Brown
2022-01-28 13:31 ` Dan Carpenter [this message]
2022-01-28 13:31 ` Dan Carpenter
2022-01-28 13:48 ` Mark Brown
2022-01-28 13:48 ` Mark Brown
2022-01-28 14:05 ` Dan Carpenter
2022-01-28 14:05 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220128133147.GL1978@kadam \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.