All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	GNU/Weeb Mailing List <gwml@gnuweeb.org>,
	linux-kernel@vger.kernel.org
Subject: [ammarfaizi2-block:paulmck/linux-rcu/dev 94/94] kernel/rcu/srcutree.c:313:6: warning: no previous prototype for function 'spin_lock_irqsave_ssp_contention'
Date: Fri, 28 Jan 2022 19:18:01 +0800	[thread overview]
Message-ID: <202201281904.qRllNV38-lkp@intel.com> (raw)

tree:   https://github.com/ammarfaizi2/linux-block paulmck/linux-rcu/dev
head:   903a93309e5a59497d3c178cabb67ecc6c843a69
commit: 903a93309e5a59497d3c178cabb67ecc6c843a69 [94/94] srcu: Add contention-triggered addition of srcu_node tree
config: hexagon-randconfig-r015-20220128 (https://download.01.org/0day-ci/archive/20220128/202201281904.qRllNV38-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 33b45ee44b1f32ffdbc995e6fec806271b4b3ba4)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/ammarfaizi2/linux-block/commit/903a93309e5a59497d3c178cabb67ecc6c843a69
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block paulmck/linux-rcu/dev
        git checkout 903a93309e5a59497d3c178cabb67ecc6c843a69
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/firewire/ kernel/rcu/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> kernel/rcu/srcutree.c:313:6: warning: no previous prototype for function 'spin_lock_irqsave_ssp_contention' [-Wmissing-prototypes]
   void spin_lock_irqsave_ssp_contention(struct srcu_struct *ssp, unsigned long *flags)
        ^
   kernel/rcu/srcutree.c:313:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void spin_lock_irqsave_ssp_contention(struct srcu_struct *ssp, unsigned long *flags)
   ^
   static 
   1 warning generated.


vim +/spin_lock_irqsave_ssp_contention +313 kernel/rcu/srcutree.c

   306	
   307	/*
   308	 * Acquire the specified srcu_struct structure's ->lock, but check for
   309	 * excessive contention, which results in initiation of a transition
   310	 * to SRCU_SIZE_BIG.  But only if the srcutree.convert_to_big module
   311	 * parameter permits this.
   312	 */
 > 313	void spin_lock_irqsave_ssp_contention(struct srcu_struct *ssp, unsigned long *flags)
   314	{
   315		unsigned long j;
   316	
   317		if (spin_trylock_irqsave_rcu_node(ssp, *flags))
   318			return;
   319		spin_lock_irqsave_rcu_node(ssp, *flags);
   320		if (!(convert_to_big & 0x10) || ssp->srcu_size_state)
   321			return;
   322		j = jiffies;
   323		if (ssp->srcu_size_jiffies != j) {
   324			ssp->srcu_size_jiffies = j;
   325			ssp->srcu_n_lock_retries = 0;
   326		}
   327		if (++ssp->srcu_n_lock_retries <= small_contention_lim)
   328			return;
   329		__srcu_transition_to_big(ssp);
   330	}
   331	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [ammarfaizi2-block:paulmck/linux-rcu/dev 94/94] kernel/rcu/srcutree.c:313:6: warning: no previous prototype for function 'spin_lock_irqsave_ssp_contention'
Date: Fri, 28 Jan 2022 19:18:01 +0800	[thread overview]
Message-ID: <202201281904.qRllNV38-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2992 bytes --]

tree:   https://github.com/ammarfaizi2/linux-block paulmck/linux-rcu/dev
head:   903a93309e5a59497d3c178cabb67ecc6c843a69
commit: 903a93309e5a59497d3c178cabb67ecc6c843a69 [94/94] srcu: Add contention-triggered addition of srcu_node tree
config: hexagon-randconfig-r015-20220128 (https://download.01.org/0day-ci/archive/20220128/202201281904.qRllNV38-lkp(a)intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 33b45ee44b1f32ffdbc995e6fec806271b4b3ba4)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/ammarfaizi2/linux-block/commit/903a93309e5a59497d3c178cabb67ecc6c843a69
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block paulmck/linux-rcu/dev
        git checkout 903a93309e5a59497d3c178cabb67ecc6c843a69
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/firewire/ kernel/rcu/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> kernel/rcu/srcutree.c:313:6: warning: no previous prototype for function 'spin_lock_irqsave_ssp_contention' [-Wmissing-prototypes]
   void spin_lock_irqsave_ssp_contention(struct srcu_struct *ssp, unsigned long *flags)
        ^
   kernel/rcu/srcutree.c:313:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void spin_lock_irqsave_ssp_contention(struct srcu_struct *ssp, unsigned long *flags)
   ^
   static 
   1 warning generated.


vim +/spin_lock_irqsave_ssp_contention +313 kernel/rcu/srcutree.c

   306	
   307	/*
   308	 * Acquire the specified srcu_struct structure's ->lock, but check for
   309	 * excessive contention, which results in initiation of a transition
   310	 * to SRCU_SIZE_BIG.  But only if the srcutree.convert_to_big module
   311	 * parameter permits this.
   312	 */
 > 313	void spin_lock_irqsave_ssp_contention(struct srcu_struct *ssp, unsigned long *flags)
   314	{
   315		unsigned long j;
   316	
   317		if (spin_trylock_irqsave_rcu_node(ssp, *flags))
   318			return;
   319		spin_lock_irqsave_rcu_node(ssp, *flags);
   320		if (!(convert_to_big & 0x10) || ssp->srcu_size_state)
   321			return;
   322		j = jiffies;
   323		if (ssp->srcu_size_jiffies != j) {
   324			ssp->srcu_size_jiffies = j;
   325			ssp->srcu_n_lock_retries = 0;
   326		}
   327		if (++ssp->srcu_n_lock_retries <= small_contention_lim)
   328			return;
   329		__srcu_transition_to_big(ssp);
   330	}
   331	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

             reply	other threads:[~2022-01-28 11:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-28 11:18 kernel test robot [this message]
2022-01-28 11:18 ` [ammarfaizi2-block:paulmck/linux-rcu/dev 94/94] kernel/rcu/srcutree.c:313:6: warning: no previous prototype for function 'spin_lock_irqsave_ssp_contention' kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2022-01-28 11:07 kernel test robot
2022-01-28 11:07 ` kernel test robot
2022-01-28 16:18 ` Paul E. McKenney
2022-01-28 16:18   ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202201281904.qRllNV38-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=gwml@gnuweeb.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=paulmck@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.