All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] mm: move page-writeback sysctls to is own file
Date: Sat, 29 Jan 2022 01:16:53 +0800	[thread overview]
Message-ID: <202201290051.7pu9CEMG-lkp@intel.com> (raw)
In-Reply-To: <20220128091901.18074-1-zhanglianjie@uniontech.com>

[-- Attachment #1: Type: text/plain, Size: 6733 bytes --]

Hi zhanglianjie,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.17-rc1 next-20220128]
[cannot apply to hnaz-mm/master linux/master kees/for-next/pstore]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/zhanglianjie/mm-move-page-writeback-sysctls-to-is-own-file/20220128-172052
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 23a46422c56144939c091c76cf389aa863ce9c18
config: i386-randconfig-a003 (https://download.01.org/0day-ci/archive/20220129/202201290051.7pu9CEMG-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/d24502aa729978894feb2de10481cd139ae5bb42
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review zhanglianjie/mm-move-page-writeback-sysctls-to-is-own-file/20220128-172052
        git checkout d24502aa729978894feb2de10481cd139ae5bb42
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> mm/page-writeback.c:509:5: warning: no previous prototype for 'dirty_background_ratio_handler' [-Wmissing-prototypes]
     509 | int dirty_background_ratio_handler(struct ctl_table *table, int write,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> mm/page-writeback.c:520:5: warning: no previous prototype for 'dirty_background_bytes_handler' [-Wmissing-prototypes]
     520 | int dirty_background_bytes_handler(struct ctl_table *table, int write,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> mm/page-writeback.c:531:5: warning: no previous prototype for 'dirty_ratio_handler' [-Wmissing-prototypes]
     531 | int dirty_ratio_handler(struct ctl_table *table, int write, void *buffer,
         |     ^~~~~~~~~~~~~~~~~~~
>> mm/page-writeback.c:545:5: warning: no previous prototype for 'dirty_bytes_handler' [-Wmissing-prototypes]
     545 | int dirty_bytes_handler(struct ctl_table *table, int write,
         |     ^~~~~~~~~~~~~~~~~~~
>> mm/page-writeback.c:2002:5: warning: no previous prototype for 'dirty_writeback_centisecs_handler' [-Wmissing-prototypes]
    2002 | int dirty_writeback_centisecs_handler(struct ctl_table *table, int write,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/dirty_background_ratio_handler +509 mm/page-writeback.c

a756cf5908530e Johannes Weiner   2012-01-10  508  
2da02997e08d3e David Rientjes    2009-01-06 @509  int dirty_background_ratio_handler(struct ctl_table *table, int write,
32927393dc1ccd Christoph Hellwig 2020-04-24  510  		void *buffer, size_t *lenp, loff_t *ppos)
2da02997e08d3e David Rientjes    2009-01-06  511  {
2da02997e08d3e David Rientjes    2009-01-06  512  	int ret;
2da02997e08d3e David Rientjes    2009-01-06  513  
8d65af789f3e2c Alexey Dobriyan   2009-09-23  514  	ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos);
2da02997e08d3e David Rientjes    2009-01-06  515  	if (ret == 0 && write)
2da02997e08d3e David Rientjes    2009-01-06  516  		dirty_background_bytes = 0;
2da02997e08d3e David Rientjes    2009-01-06  517  	return ret;
2da02997e08d3e David Rientjes    2009-01-06  518  }
2da02997e08d3e David Rientjes    2009-01-06  519  
2da02997e08d3e David Rientjes    2009-01-06 @520  int dirty_background_bytes_handler(struct ctl_table *table, int write,
32927393dc1ccd Christoph Hellwig 2020-04-24  521  		void *buffer, size_t *lenp, loff_t *ppos)
2da02997e08d3e David Rientjes    2009-01-06  522  {
2da02997e08d3e David Rientjes    2009-01-06  523  	int ret;
2da02997e08d3e David Rientjes    2009-01-06  524  
8d65af789f3e2c Alexey Dobriyan   2009-09-23  525  	ret = proc_doulongvec_minmax(table, write, buffer, lenp, ppos);
2da02997e08d3e David Rientjes    2009-01-06  526  	if (ret == 0 && write)
2da02997e08d3e David Rientjes    2009-01-06  527  		dirty_background_ratio = 0;
2da02997e08d3e David Rientjes    2009-01-06  528  	return ret;
2da02997e08d3e David Rientjes    2009-01-06  529  }
2da02997e08d3e David Rientjes    2009-01-06  530  
32927393dc1ccd Christoph Hellwig 2020-04-24 @531  int dirty_ratio_handler(struct ctl_table *table, int write, void *buffer,
32927393dc1ccd Christoph Hellwig 2020-04-24  532  		size_t *lenp, loff_t *ppos)
04fbfdc14e5f48 Peter Zijlstra    2007-10-16  533  {
04fbfdc14e5f48 Peter Zijlstra    2007-10-16  534  	int old_ratio = vm_dirty_ratio;
2da02997e08d3e David Rientjes    2009-01-06  535  	int ret;
2da02997e08d3e David Rientjes    2009-01-06  536  
8d65af789f3e2c Alexey Dobriyan   2009-09-23  537  	ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos);
04fbfdc14e5f48 Peter Zijlstra    2007-10-16  538  	if (ret == 0 && write && vm_dirty_ratio != old_ratio) {
eb608e3a344b3a Jan Kara          2012-05-24  539  		writeback_set_ratelimit();
2da02997e08d3e David Rientjes    2009-01-06  540  		vm_dirty_bytes = 0;
2da02997e08d3e David Rientjes    2009-01-06  541  	}
2da02997e08d3e David Rientjes    2009-01-06  542  	return ret;
2da02997e08d3e David Rientjes    2009-01-06  543  }
2da02997e08d3e David Rientjes    2009-01-06  544  
2da02997e08d3e David Rientjes    2009-01-06 @545  int dirty_bytes_handler(struct ctl_table *table, int write,
32927393dc1ccd Christoph Hellwig 2020-04-24  546  		void *buffer, size_t *lenp, loff_t *ppos)
2da02997e08d3e David Rientjes    2009-01-06  547  {
fc3501d411d348 Sven Wegener      2009-02-11  548  	unsigned long old_bytes = vm_dirty_bytes;
2da02997e08d3e David Rientjes    2009-01-06  549  	int ret;
2da02997e08d3e David Rientjes    2009-01-06  550  
8d65af789f3e2c Alexey Dobriyan   2009-09-23  551  	ret = proc_doulongvec_minmax(table, write, buffer, lenp, ppos);
2da02997e08d3e David Rientjes    2009-01-06  552  	if (ret == 0 && write && vm_dirty_bytes != old_bytes) {
eb608e3a344b3a Jan Kara          2012-05-24  553  		writeback_set_ratelimit();
2da02997e08d3e David Rientjes    2009-01-06  554  		vm_dirty_ratio = 0;
04fbfdc14e5f48 Peter Zijlstra    2007-10-16  555  	}
04fbfdc14e5f48 Peter Zijlstra    2007-10-16  556  	return ret;
04fbfdc14e5f48 Peter Zijlstra    2007-10-16  557  }
04fbfdc14e5f48 Peter Zijlstra    2007-10-16  558  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: zhanglianjie <zhanglianjie@uniontech.com>, keescook@chromium.org
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	yzaikin@google.com, mcgrof@kernel.org, akpm@linux-foundation.org,
	zhanglianjie <zhanglianjie@uniontech.com>
Subject: Re: [PATCH] mm: move page-writeback sysctls to is own file
Date: Sat, 29 Jan 2022 01:16:53 +0800	[thread overview]
Message-ID: <202201290051.7pu9CEMG-lkp@intel.com> (raw)
In-Reply-To: <20220128091901.18074-1-zhanglianjie@uniontech.com>

Hi zhanglianjie,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.17-rc1 next-20220128]
[cannot apply to hnaz-mm/master linux/master kees/for-next/pstore]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/zhanglianjie/mm-move-page-writeback-sysctls-to-is-own-file/20220128-172052
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 23a46422c56144939c091c76cf389aa863ce9c18
config: i386-randconfig-a003 (https://download.01.org/0day-ci/archive/20220129/202201290051.7pu9CEMG-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/d24502aa729978894feb2de10481cd139ae5bb42
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review zhanglianjie/mm-move-page-writeback-sysctls-to-is-own-file/20220128-172052
        git checkout d24502aa729978894feb2de10481cd139ae5bb42
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> mm/page-writeback.c:509:5: warning: no previous prototype for 'dirty_background_ratio_handler' [-Wmissing-prototypes]
     509 | int dirty_background_ratio_handler(struct ctl_table *table, int write,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> mm/page-writeback.c:520:5: warning: no previous prototype for 'dirty_background_bytes_handler' [-Wmissing-prototypes]
     520 | int dirty_background_bytes_handler(struct ctl_table *table, int write,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> mm/page-writeback.c:531:5: warning: no previous prototype for 'dirty_ratio_handler' [-Wmissing-prototypes]
     531 | int dirty_ratio_handler(struct ctl_table *table, int write, void *buffer,
         |     ^~~~~~~~~~~~~~~~~~~
>> mm/page-writeback.c:545:5: warning: no previous prototype for 'dirty_bytes_handler' [-Wmissing-prototypes]
     545 | int dirty_bytes_handler(struct ctl_table *table, int write,
         |     ^~~~~~~~~~~~~~~~~~~
>> mm/page-writeback.c:2002:5: warning: no previous prototype for 'dirty_writeback_centisecs_handler' [-Wmissing-prototypes]
    2002 | int dirty_writeback_centisecs_handler(struct ctl_table *table, int write,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/dirty_background_ratio_handler +509 mm/page-writeback.c

a756cf5908530e Johannes Weiner   2012-01-10  508  
2da02997e08d3e David Rientjes    2009-01-06 @509  int dirty_background_ratio_handler(struct ctl_table *table, int write,
32927393dc1ccd Christoph Hellwig 2020-04-24  510  		void *buffer, size_t *lenp, loff_t *ppos)
2da02997e08d3e David Rientjes    2009-01-06  511  {
2da02997e08d3e David Rientjes    2009-01-06  512  	int ret;
2da02997e08d3e David Rientjes    2009-01-06  513  
8d65af789f3e2c Alexey Dobriyan   2009-09-23  514  	ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos);
2da02997e08d3e David Rientjes    2009-01-06  515  	if (ret == 0 && write)
2da02997e08d3e David Rientjes    2009-01-06  516  		dirty_background_bytes = 0;
2da02997e08d3e David Rientjes    2009-01-06  517  	return ret;
2da02997e08d3e David Rientjes    2009-01-06  518  }
2da02997e08d3e David Rientjes    2009-01-06  519  
2da02997e08d3e David Rientjes    2009-01-06 @520  int dirty_background_bytes_handler(struct ctl_table *table, int write,
32927393dc1ccd Christoph Hellwig 2020-04-24  521  		void *buffer, size_t *lenp, loff_t *ppos)
2da02997e08d3e David Rientjes    2009-01-06  522  {
2da02997e08d3e David Rientjes    2009-01-06  523  	int ret;
2da02997e08d3e David Rientjes    2009-01-06  524  
8d65af789f3e2c Alexey Dobriyan   2009-09-23  525  	ret = proc_doulongvec_minmax(table, write, buffer, lenp, ppos);
2da02997e08d3e David Rientjes    2009-01-06  526  	if (ret == 0 && write)
2da02997e08d3e David Rientjes    2009-01-06  527  		dirty_background_ratio = 0;
2da02997e08d3e David Rientjes    2009-01-06  528  	return ret;
2da02997e08d3e David Rientjes    2009-01-06  529  }
2da02997e08d3e David Rientjes    2009-01-06  530  
32927393dc1ccd Christoph Hellwig 2020-04-24 @531  int dirty_ratio_handler(struct ctl_table *table, int write, void *buffer,
32927393dc1ccd Christoph Hellwig 2020-04-24  532  		size_t *lenp, loff_t *ppos)
04fbfdc14e5f48 Peter Zijlstra    2007-10-16  533  {
04fbfdc14e5f48 Peter Zijlstra    2007-10-16  534  	int old_ratio = vm_dirty_ratio;
2da02997e08d3e David Rientjes    2009-01-06  535  	int ret;
2da02997e08d3e David Rientjes    2009-01-06  536  
8d65af789f3e2c Alexey Dobriyan   2009-09-23  537  	ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos);
04fbfdc14e5f48 Peter Zijlstra    2007-10-16  538  	if (ret == 0 && write && vm_dirty_ratio != old_ratio) {
eb608e3a344b3a Jan Kara          2012-05-24  539  		writeback_set_ratelimit();
2da02997e08d3e David Rientjes    2009-01-06  540  		vm_dirty_bytes = 0;
2da02997e08d3e David Rientjes    2009-01-06  541  	}
2da02997e08d3e David Rientjes    2009-01-06  542  	return ret;
2da02997e08d3e David Rientjes    2009-01-06  543  }
2da02997e08d3e David Rientjes    2009-01-06  544  
2da02997e08d3e David Rientjes    2009-01-06 @545  int dirty_bytes_handler(struct ctl_table *table, int write,
32927393dc1ccd Christoph Hellwig 2020-04-24  546  		void *buffer, size_t *lenp, loff_t *ppos)
2da02997e08d3e David Rientjes    2009-01-06  547  {
fc3501d411d348 Sven Wegener      2009-02-11  548  	unsigned long old_bytes = vm_dirty_bytes;
2da02997e08d3e David Rientjes    2009-01-06  549  	int ret;
2da02997e08d3e David Rientjes    2009-01-06  550  
8d65af789f3e2c Alexey Dobriyan   2009-09-23  551  	ret = proc_doulongvec_minmax(table, write, buffer, lenp, ppos);
2da02997e08d3e David Rientjes    2009-01-06  552  	if (ret == 0 && write && vm_dirty_bytes != old_bytes) {
eb608e3a344b3a Jan Kara          2012-05-24  553  		writeback_set_ratelimit();
2da02997e08d3e David Rientjes    2009-01-06  554  		vm_dirty_ratio = 0;
04fbfdc14e5f48 Peter Zijlstra    2007-10-16  555  	}
04fbfdc14e5f48 Peter Zijlstra    2007-10-16  556  	return ret;
04fbfdc14e5f48 Peter Zijlstra    2007-10-16  557  }
04fbfdc14e5f48 Peter Zijlstra    2007-10-16  558  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

  parent reply	other threads:[~2022-01-28 17:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-28  9:19 [PATCH] mm: move page-writeback sysctls to is own file zhanglianjie
2022-01-28 17:06 ` kernel test robot
2022-01-28 17:06   ` kernel test robot
2022-01-28 17:16 ` kernel test robot [this message]
2022-01-28 17:16   ` kernel test robot
2022-02-02  2:41   ` Luis Chamberlain
2022-02-02  2:41     ` Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202201290051.7pu9CEMG-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.