* [Buildroot] [PATCH 1/1] package/pkg-cargo: fix debug build
@ 2022-01-29 9:42 Fabrice Fontaine
2022-01-30 14:55 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2022-01-29 9:42 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine
There is no --debug mode for cargo resulting in the following build
failure in ripgrep since its conversion to cargo infrastructure in
commit 342fd3e7350479dc368541ac77a5130ebb53194c:
error: Found argument '--debug' which wasn't expected, or isn't valid in this context
Fixes:
- http://autobuild.buildroot.org/results/772ebdd6a39950457a59419bdc1376cb0e0a3611
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/pkg-cargo.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/pkg-cargo.mk b/package/pkg-cargo.mk
index 614d46ad64..e74a8358bc 100644
--- a/package/pkg-cargo.mk
+++ b/package/pkg-cargo.mk
@@ -104,7 +104,7 @@ define $(2)_BUILD_CMDS
$$($(2)_CARGO_ENV) \
cargo build \
--offline \
- $$(if $$(BR2_ENABLE_DEBUG),--debug,--release) \
+ $$(if $$(BR2_ENABLE_DEBUG),,--release) \
--manifest-path Cargo.toml \
--locked \
$$($(2)_CARGO_BUILD_OPTS)
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/pkg-cargo: fix debug build
2022-01-29 9:42 [Buildroot] [PATCH 1/1] package/pkg-cargo: fix debug build Fabrice Fontaine
@ 2022-01-30 14:55 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-01-30 14:55 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
On Sat, 29 Jan 2022 10:42:22 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> There is no --debug mode for cargo resulting in the following build
> failure in ripgrep since its conversion to cargo infrastructure in
> commit 342fd3e7350479dc368541ac77a5130ebb53194c:
>
> error: Found argument '--debug' which wasn't expected, or isn't valid in this context
>
> Fixes:
> - http://autobuild.buildroot.org/results/772ebdd6a39950457a59419bdc1376cb0e0a3611
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/pkg-cargo.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
However, I'm wondering if we shouldn't instead use:
--profile=release
and
--profile=dev
See https://doc.rust-lang.org/cargo/reference/profiles.html
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-30 14:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-29 9:42 [Buildroot] [PATCH 1/1] package/pkg-cargo: fix debug build Fabrice Fontaine
2022-01-30 14:55 ` Thomas Petazzoni via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.