* [Buildroot] [PATCH] package/kf5/kf5-kcoreaddons: add missing comment dependency for binutils-bug-27597 @ 2022-01-28 11:05 Giulio Benetti 2022-01-28 11:05 ` [Buildroot] [PATCH] package/libcamera: fix missing comment " Giulio Benetti 2022-01-28 11:05 ` [Buildroot] [PATCH] package/pistache: disable package if affected by BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 Giulio Benetti 0 siblings, 2 replies; 6+ messages in thread From: Giulio Benetti @ 2022-01-28 11:05 UTC (permalink / raw) To: buildroot; +Cc: Giulio Benetti, Kieran Bingham, Pierre Ducroquet Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- package/kf5/kf5-kcoreaddons/Config.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/package/kf5/kf5-kcoreaddons/Config.in b/package/kf5/kf5-kcoreaddons/Config.in index 02bd38e395..eef43101a2 100644 --- a/package/kf5/kf5-kcoreaddons/Config.in +++ b/package/kf5/kf5-kcoreaddons/Config.in @@ -13,3 +13,6 @@ config BR2_PACKAGE_KF5_KCOREADDONS on top of QtCore to perform various tasks. https://api.kde.org/frameworks/kcoreaddons/html/index.html + +comment "kf5-kcoreaddons needs a toolchain w/o bug 27597" + depends on BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 -- 2.25.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/libcamera: fix missing comment for binutils-bug-27597 2022-01-28 11:05 [Buildroot] [PATCH] package/kf5/kf5-kcoreaddons: add missing comment dependency for binutils-bug-27597 Giulio Benetti @ 2022-01-28 11:05 ` Giulio Benetti 2022-02-12 16:49 ` Yann E. MORIN 2022-01-28 11:05 ` [Buildroot] [PATCH] package/pistache: disable package if affected by BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 Giulio Benetti 1 sibling, 1 reply; 6+ messages in thread From: Giulio Benetti @ 2022-01-28 11:05 UTC (permalink / raw) To: buildroot; +Cc: Giulio Benetti, Kieran Bingham, Pierre Ducroquet Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- package/libcamera/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in index 23a0040abf..88db054975 100644 --- a/package/libcamera/Config.in +++ b/package/libcamera/Config.in @@ -92,7 +92,7 @@ comment "lc-compliance test application needs a toolchain w/ C++, wchar, threads endif # BR2_PACKAGE_LIBCAMERA -comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7" +comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7, not binutils bug 27597" depends on BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \ !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || BR2_STATIC_LIBS || !BR2_USE_WCHAR -- 2.25.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/libcamera: fix missing comment for binutils-bug-27597 2022-01-28 11:05 ` [Buildroot] [PATCH] package/libcamera: fix missing comment " Giulio Benetti @ 2022-02-12 16:49 ` Yann E. MORIN 2022-02-12 16:56 ` Giulio Benetti 0 siblings, 1 reply; 6+ messages in thread From: Yann E. MORIN @ 2022-02-12 16:49 UTC (permalink / raw) To: Giulio Benetti; +Cc: Kieran Bingham, Pierre Ducroquet, buildroot Giulio, All, On 2022-01-28 12:05 +0100, Giulio Benetti spake thusly: > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > --- > package/libcamera/Config.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in > index 23a0040abf..88db054975 100644 > --- a/package/libcamera/Config.in > +++ b/package/libcamera/Config.in > @@ -92,7 +92,7 @@ comment "lc-compliance test application needs a toolchain w/ C++, wchar, threads > > endif # BR2_PACKAGE_LIBCAMERA > > -comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7" > +comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7, not binutils bug 27597" Bug 27597 is inherently an architecture-speific bug, which is always set for NIOS2, so there is nothing the user can do about it except switch to another architecture... The comments are meant for when the user has an alternative option, like chossing a different version of a component. In this case, there is nothing the user can do, so we don't add it to the comment. Regards, Yann E. MORIN. > depends on BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS > depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \ > !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || BR2_STATIC_LIBS || !BR2_USE_WCHAR > -- > 2.25.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/libcamera: fix missing comment for binutils-bug-27597 2022-02-12 16:49 ` Yann E. MORIN @ 2022-02-12 16:56 ` Giulio Benetti 0 siblings, 0 replies; 6+ messages in thread From: Giulio Benetti @ 2022-02-12 16:56 UTC (permalink / raw) To: Yann E. MORIN; +Cc: Kieran Bingham, Pierre Ducroquet, buildroot On 12/02/22 17:49, Yann E. MORIN wrote: > Giulio, All, > > On 2022-01-28 12:05 +0100, Giulio Benetti spake thusly: >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >> --- >> package/libcamera/Config.in | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in >> index 23a0040abf..88db054975 100644 >> --- a/package/libcamera/Config.in >> +++ b/package/libcamera/Config.in >> @@ -92,7 +92,7 @@ comment "lc-compliance test application needs a toolchain w/ C++, wchar, threads >> >> endif # BR2_PACKAGE_LIBCAMERA >> >> -comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7" >> +comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7, not binutils bug 27597" > > Bug 27597 is inherently an architecture-speific bug, which is always set > for NIOS2, so there is nothing the user can do about it except switch to > another architecture... > > The comments are meant for when the user has an alternative option, like > chossing a different version of a component. > > In this case, there is nothing the user can do, so we don't add it to > the comment. Aaah, right, like hidden options. Ok, so let's drop this patch. Thank you! Best regards -- Giulio Benetti Benetti Engineering sas > Regards, > Yann E. MORIN. > >> depends on BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS >> depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \ >> !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || BR2_STATIC_LIBS || !BR2_USE_WCHAR >> -- >> 2.25.1 >> >> _______________________________________________ >> buildroot mailing list >> buildroot@buildroot.org >> https://lists.buildroot.org/mailman/listinfo/buildroot > _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/pistache: disable package if affected by BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 2022-01-28 11:05 [Buildroot] [PATCH] package/kf5/kf5-kcoreaddons: add missing comment dependency for binutils-bug-27597 Giulio Benetti 2022-01-28 11:05 ` [Buildroot] [PATCH] package/libcamera: fix missing comment " Giulio Benetti @ 2022-01-28 11:05 ` Giulio Benetti 2022-01-30 21:59 ` Thomas Petazzoni via buildroot 1 sibling, 1 reply; 6+ messages in thread From: Giulio Benetti @ 2022-01-28 11:05 UTC (permalink / raw) To: buildroot; +Cc: Giulio Benetti, Kieran Bingham, Pierre Ducroquet Package pistache is affected by binutils bug 27597(Nios II), so let's disable it when BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597=y. Let'a also indent the comment dependencies. Fixes: http://autobuild.buildroot.net/results/0e7b74c5a07ced2bbae1a0a8c7d7ba26dfa04031/ Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- package/pistache/Config.in | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/package/pistache/Config.in b/package/pistache/Config.in index 64d6340827..96aed5210a 100644 --- a/package/pistache/Config.in +++ b/package/pistache/Config.in @@ -5,6 +5,7 @@ config BR2_PACKAGE_PISTACHE depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_INSTALL_LIBSTDCPP depends on !BR2_TOOLCHAIN_USES_UCLIBC + depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 help Pistache is a modern and elegant HTTP and REST framework for C++. It is entirely written in pure C++14 and provides @@ -12,9 +13,10 @@ config BR2_PACKAGE_PISTACHE https://github.com/oktal/pistache -comment "pistache needs a glibc toolchain w/ C++, gcc >= 4.9, threads, wchar" +comment "pistache needs a glibc toolchain w/ C++, gcc >= 4.9, threads, wchar, not binutils bug 27597" depends on !BR2_INSTALL_LIBSTDCPP || \ - BR2_TOOLCHAIN_USES_UCLIBC || \ - !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \ - !BR2_TOOLCHAIN_HAS_THREADS || \ - !BR2_USE_WCHAR + BR2_TOOLCHAIN_USES_UCLIBC || \ + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \ + !BR2_TOOLCHAIN_HAS_THREADS || \ + !BR2_USE_WCHAR || \ + BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 -- 2.25.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/pistache: disable package if affected by BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 2022-01-28 11:05 ` [Buildroot] [PATCH] package/pistache: disable package if affected by BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 Giulio Benetti @ 2022-01-30 21:59 ` Thomas Petazzoni via buildroot 0 siblings, 0 replies; 6+ messages in thread From: Thomas Petazzoni via buildroot @ 2022-01-30 21:59 UTC (permalink / raw) To: Giulio Benetti; +Cc: Kieran Bingham, Pierre Ducroquet, buildroot On Fri, 28 Jan 2022 12:05:42 +0100 Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > Package pistache is affected by binutils bug 27597(Nios II), so let's > disable it when BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597=y. Let'a also indent > the comment dependencies. > > Fixes: > http://autobuild.buildroot.net/results/0e7b74c5a07ced2bbae1a0a8c7d7ba26dfa04031/ > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > --- > package/pistache/Config.in | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) Applied to master, thanks. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-12 16:57 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-01-28 11:05 [Buildroot] [PATCH] package/kf5/kf5-kcoreaddons: add missing comment dependency for binutils-bug-27597 Giulio Benetti 2022-01-28 11:05 ` [Buildroot] [PATCH] package/libcamera: fix missing comment " Giulio Benetti 2022-02-12 16:49 ` Yann E. MORIN 2022-02-12 16:56 ` Giulio Benetti 2022-01-28 11:05 ` [Buildroot] [PATCH] package/pistache: disable package if affected by BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 Giulio Benetti 2022-01-30 21:59 ` Thomas Petazzoni via buildroot
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.