From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
dri-devel@lists.freedesktop.org,
Robin van der Gracht <robin@protonic.nl>,
David Airlie <airlied@linux.ie>,
Fabio Estevam <festevam@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Daniel Vetter <daniel@ffwll.ch>, David Jander <david@protonic.nl>,
Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/5] ARM: dts: imx6dl: plym2m, prtvt7, victgo: make use of new resistive-adc-touch driver
Date: Tue, 1 Feb 2022 06:26:50 +0100 [thread overview]
Message-ID: <20220201052650.GA29389@pengutronix.de> (raw)
In-Reply-To: <YfgDToubMLxZsy34@ravnborg.org>
Hi Sam,
On Mon, Jan 31, 2022 at 04:42:06PM +0100, Sam Ravnborg wrote:
> On Mon, Jan 31, 2022 at 11:28:40AM +0100, Oleksij Rempel wrote:
> > The tsc2046 is an ADC used as touchscreen controller. To share as mach
> much
> > code as possible, we should use it as actual ADC + virtual touchscreen
> > controller.
> > With this patch we make use of the new kernel IIO and HID infrastructure.
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> > arch/arm/boot/dts/imx6dl-plym2m.dts | 59 +++++++++++++++++++++--------
> > arch/arm/boot/dts/imx6dl-prtvt7.dts | 57 +++++++++++++++++++++-------
> > arch/arm/boot/dts/imx6dl-victgo.dts | 59 ++++++++++++++++++++++-------
> > 3 files changed, 132 insertions(+), 43 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6dl-plym2m.dts b/arch/arm/boot/dts/imx6dl-plym2m.dts
> > index 60fe5f14666e..73c7622bfe0f 100644
> > --- a/arch/arm/boot/dts/imx6dl-plym2m.dts
> > +++ b/arch/arm/boot/dts/imx6dl-plym2m.dts
> > @@ -101,6 +101,18 @@ reg_12v0: regulator-12v0 {
> > regulator-min-microvolt = <12000000>;
> > regulator-max-microvolt = <12000000>;
> > };
> > +
> > + touchscreen {
> > + compatible = "resistive-adc-touch";
> > + io-channels = <&adc_ts 1>, <&adc_ts 3>, <&adc_ts 4>,
> > + <&adc_ts 5>;
> > + io-channel-names = "y", "z1", "z2", "x";
> > + touchscreen-min-pressure = <64687>;
> > + touchscreen-inverted-x;
> > + touchscreen-inverted-y;
> > + touchscreen-x-plate-ohms = <300>;
> > + touchscreen-y-plate-ohms = <800>;
> > + };
> > };
> >
> > &can1 {
> > @@ -129,26 +141,41 @@ &ecspi2 {
> > pinctrl-0 = <&pinctrl_ecspi2>;
> > status = "okay";
> >
> > - touchscreen@0 {
> > - compatible = "ti,tsc2046";
> > + adc_ts: adc@0 {
> > + compatible = "ti,tsc2046e-adc";
> > reg = <0>;
> > pinctrl-0 = <&pinctrl_tsc2046>;
> > pinctrl-names ="default";
> > - spi-max-frequency = <100000>;
> > - interrupts-extended = <&gpio3 20 IRQ_TYPE_EDGE_FALLING>;
> > - pendown-gpio = <&gpio3 20 GPIO_ACTIVE_LOW>;
> > + spi-max-frequency = <1000000>;
> > + interrupts-extended = <&gpio3 20 IRQ_TYPE_LEVEL_LOW>;
> > + #io-channel-cells = <1>;
>
> I quickly skimmed the patch - we seem to loose the pendown-gpio in most
> of the patches - I do not see it replaced.
pendown-gpio is not used by the new driver. It is replace by the IIO
trigger. Please see this comment:
https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/tree/drivers/iio/adc/ti-tsc2046.c?h=testing#n521
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
dri-devel@lists.freedesktop.org,
Robin van der Gracht <robin@protonic.nl>,
David Airlie <airlied@linux.ie>,
Fabio Estevam <festevam@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Daniel Vetter <daniel@ffwll.ch>, David Jander <david@protonic.nl>,
Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/5] ARM: dts: imx6dl: plym2m, prtvt7, victgo: make use of new resistive-adc-touch driver
Date: Tue, 1 Feb 2022 06:26:50 +0100 [thread overview]
Message-ID: <20220201052650.GA29389@pengutronix.de> (raw)
In-Reply-To: <YfgDToubMLxZsy34@ravnborg.org>
Hi Sam,
On Mon, Jan 31, 2022 at 04:42:06PM +0100, Sam Ravnborg wrote:
> On Mon, Jan 31, 2022 at 11:28:40AM +0100, Oleksij Rempel wrote:
> > The tsc2046 is an ADC used as touchscreen controller. To share as mach
> much
> > code as possible, we should use it as actual ADC + virtual touchscreen
> > controller.
> > With this patch we make use of the new kernel IIO and HID infrastructure.
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> > arch/arm/boot/dts/imx6dl-plym2m.dts | 59 +++++++++++++++++++++--------
> > arch/arm/boot/dts/imx6dl-prtvt7.dts | 57 +++++++++++++++++++++-------
> > arch/arm/boot/dts/imx6dl-victgo.dts | 59 ++++++++++++++++++++++-------
> > 3 files changed, 132 insertions(+), 43 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6dl-plym2m.dts b/arch/arm/boot/dts/imx6dl-plym2m.dts
> > index 60fe5f14666e..73c7622bfe0f 100644
> > --- a/arch/arm/boot/dts/imx6dl-plym2m.dts
> > +++ b/arch/arm/boot/dts/imx6dl-plym2m.dts
> > @@ -101,6 +101,18 @@ reg_12v0: regulator-12v0 {
> > regulator-min-microvolt = <12000000>;
> > regulator-max-microvolt = <12000000>;
> > };
> > +
> > + touchscreen {
> > + compatible = "resistive-adc-touch";
> > + io-channels = <&adc_ts 1>, <&adc_ts 3>, <&adc_ts 4>,
> > + <&adc_ts 5>;
> > + io-channel-names = "y", "z1", "z2", "x";
> > + touchscreen-min-pressure = <64687>;
> > + touchscreen-inverted-x;
> > + touchscreen-inverted-y;
> > + touchscreen-x-plate-ohms = <300>;
> > + touchscreen-y-plate-ohms = <800>;
> > + };
> > };
> >
> > &can1 {
> > @@ -129,26 +141,41 @@ &ecspi2 {
> > pinctrl-0 = <&pinctrl_ecspi2>;
> > status = "okay";
> >
> > - touchscreen@0 {
> > - compatible = "ti,tsc2046";
> > + adc_ts: adc@0 {
> > + compatible = "ti,tsc2046e-adc";
> > reg = <0>;
> > pinctrl-0 = <&pinctrl_tsc2046>;
> > pinctrl-names ="default";
> > - spi-max-frequency = <100000>;
> > - interrupts-extended = <&gpio3 20 IRQ_TYPE_EDGE_FALLING>;
> > - pendown-gpio = <&gpio3 20 GPIO_ACTIVE_LOW>;
> > + spi-max-frequency = <1000000>;
> > + interrupts-extended = <&gpio3 20 IRQ_TYPE_LEVEL_LOW>;
> > + #io-channel-cells = <1>;
>
> I quickly skimmed the patch - we seem to loose the pendown-gpio in most
> of the patches - I do not see it replaced.
pendown-gpio is not used by the new driver. It is replace by the IIO
trigger. Please see this comment:
https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/tree/drivers/iio/adc/ti-tsc2046.c?h=testing#n521
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
Robin van der Gracht <robin@protonic.nl>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
David Jander <david@protonic.nl>, Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/5] ARM: dts: imx6dl: plym2m, prtvt7, victgo: make use of new resistive-adc-touch driver
Date: Tue, 1 Feb 2022 06:26:50 +0100 [thread overview]
Message-ID: <20220201052650.GA29389@pengutronix.de> (raw)
In-Reply-To: <YfgDToubMLxZsy34@ravnborg.org>
Hi Sam,
On Mon, Jan 31, 2022 at 04:42:06PM +0100, Sam Ravnborg wrote:
> On Mon, Jan 31, 2022 at 11:28:40AM +0100, Oleksij Rempel wrote:
> > The tsc2046 is an ADC used as touchscreen controller. To share as mach
> much
> > code as possible, we should use it as actual ADC + virtual touchscreen
> > controller.
> > With this patch we make use of the new kernel IIO and HID infrastructure.
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> > arch/arm/boot/dts/imx6dl-plym2m.dts | 59 +++++++++++++++++++++--------
> > arch/arm/boot/dts/imx6dl-prtvt7.dts | 57 +++++++++++++++++++++-------
> > arch/arm/boot/dts/imx6dl-victgo.dts | 59 ++++++++++++++++++++++-------
> > 3 files changed, 132 insertions(+), 43 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6dl-plym2m.dts b/arch/arm/boot/dts/imx6dl-plym2m.dts
> > index 60fe5f14666e..73c7622bfe0f 100644
> > --- a/arch/arm/boot/dts/imx6dl-plym2m.dts
> > +++ b/arch/arm/boot/dts/imx6dl-plym2m.dts
> > @@ -101,6 +101,18 @@ reg_12v0: regulator-12v0 {
> > regulator-min-microvolt = <12000000>;
> > regulator-max-microvolt = <12000000>;
> > };
> > +
> > + touchscreen {
> > + compatible = "resistive-adc-touch";
> > + io-channels = <&adc_ts 1>, <&adc_ts 3>, <&adc_ts 4>,
> > + <&adc_ts 5>;
> > + io-channel-names = "y", "z1", "z2", "x";
> > + touchscreen-min-pressure = <64687>;
> > + touchscreen-inverted-x;
> > + touchscreen-inverted-y;
> > + touchscreen-x-plate-ohms = <300>;
> > + touchscreen-y-plate-ohms = <800>;
> > + };
> > };
> >
> > &can1 {
> > @@ -129,26 +141,41 @@ &ecspi2 {
> > pinctrl-0 = <&pinctrl_ecspi2>;
> > status = "okay";
> >
> > - touchscreen@0 {
> > - compatible = "ti,tsc2046";
> > + adc_ts: adc@0 {
> > + compatible = "ti,tsc2046e-adc";
> > reg = <0>;
> > pinctrl-0 = <&pinctrl_tsc2046>;
> > pinctrl-names ="default";
> > - spi-max-frequency = <100000>;
> > - interrupts-extended = <&gpio3 20 IRQ_TYPE_EDGE_FALLING>;
> > - pendown-gpio = <&gpio3 20 GPIO_ACTIVE_LOW>;
> > + spi-max-frequency = <1000000>;
> > + interrupts-extended = <&gpio3 20 IRQ_TYPE_LEVEL_LOW>;
> > + #io-channel-cells = <1>;
>
> I quickly skimmed the patch - we seem to loose the pendown-gpio in most
> of the patches - I do not see it replaced.
pendown-gpio is not used by the new driver. It is replace by the IIO
trigger. Please see this comment:
https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/tree/drivers/iio/adc/ti-tsc2046.c?h=testing#n521
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-02-01 5:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 10:28 [PATCH v2 0/5] ARM: dts: protonic maintenance patches Oleksij Rempel
2022-01-31 10:28 ` Oleksij Rempel
2022-01-31 10:28 ` Oleksij Rempel
2022-01-31 10:28 ` [PATCH v2 1/5] ARM: dts: imx6dl-prtvt7: Add display and panel nodes Oleksij Rempel
2022-01-31 10:28 ` Oleksij Rempel
2022-01-31 10:28 ` Oleksij Rempel
2022-01-31 10:28 ` [PATCH v2 2/5] ARM: dts: imx6dl-prtvt7: Add missing tvp5150 video decoder node Oleksij Rempel
2022-01-31 10:28 ` Oleksij Rempel
2022-01-31 10:28 ` Oleksij Rempel
2022-02-11 13:12 ` Shawn Guo
2022-02-11 13:12 ` Shawn Guo
2022-02-11 13:12 ` Shawn Guo
2022-01-31 10:28 ` [PATCH v2 3/5] ARM: dts: imx6qdl-vicut1: add CAN termination support Oleksij Rempel
2022-01-31 10:28 ` Oleksij Rempel
2022-01-31 10:28 ` Oleksij Rempel
2022-01-31 15:39 ` Sam Ravnborg
2022-01-31 15:39 ` Sam Ravnborg
2022-02-01 5:28 ` Oleksij Rempel
2022-02-01 5:28 ` Oleksij Rempel
2022-02-01 5:28 ` Oleksij Rempel
2022-01-31 10:28 ` [PATCH v2 4/5] ARM: dts: imx6dl: plym2m, prtvt7, victgo: make use of new resistive-adc-touch driver Oleksij Rempel
2022-01-31 10:28 ` Oleksij Rempel
2022-01-31 10:28 ` Oleksij Rempel
2022-01-31 15:42 ` Sam Ravnborg
2022-01-31 15:42 ` Sam Ravnborg
2022-02-01 5:26 ` Oleksij Rempel [this message]
2022-02-01 5:26 ` Oleksij Rempel
2022-02-01 5:26 ` Oleksij Rempel
2022-01-31 10:28 ` [PATCH v2 5/5] ARM: dts: imx6dl: plym2m, prtvt7, victgo: add thermal zones and hwmon Oleksij Rempel
2022-01-31 10:28 ` Oleksij Rempel
2022-01-31 10:28 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220201052650.GA29389@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=robin@protonic.nl \
--cc=s.hauer@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.