From: kernel test robot <lkp@intel.com>
To: Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Maxim Levitsky <mlevitsk@redhat.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH] iommu/amd: Fix loop timeout issue in iommu_ga_log_enable()
Date: Tue, 1 Feb 2022 15:01:19 +0800 [thread overview]
Message-ID: <202202011448.2UFIiZHD-lkp@intel.com> (raw)
In-Reply-To: <20220131161749.4021-1-joro@8bytes.org>
Hi Joerg,
I love your patch! Yet something to improve:
[auto build test ERROR on joro-iommu/next]
[also build test ERROR on v5.17-rc2 next-20220131]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Joerg-Roedel/iommu-amd-Fix-loop-timeout-issue-in-iommu_ga_log_enable/20220201-002214
base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220201/202202011448.2UFIiZHD-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/5b5785526da0e2a6e793d2107d09afc9f310f17f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Joerg-Roedel/iommu-amd-Fix-loop-timeout-issue-in-iommu_ga_log_enable/20220201-002214
git checkout 5b5785526da0e2a6e793d2107d09afc9f310f17f
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/iommu/amd/init.c: In function 'iommu_ga_log_enable':
>> drivers/iommu/amd/init.c:837:3: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration]
837 | udelay(1);
| ^~~~~~
cc1: some warnings being treated as errors
vim +/udelay +837 drivers/iommu/amd/init.c
804
805 static int iommu_ga_log_enable(struct amd_iommu *iommu)
806 {
807 #ifdef CONFIG_IRQ_REMAP
808 u32 status, i;
809 u64 entry;
810
811 if (!iommu->ga_log)
812 return -EINVAL;
813
814 /* Check if already running */
815 status = readl(iommu->mmio_base + MMIO_STATUS_OFFSET);
816 if (WARN_ON(status & (MMIO_STATUS_GALOG_RUN_MASK)))
817 return 0;
818
819 entry = iommu_virt_to_phys(iommu->ga_log) | GA_LOG_SIZE_512;
820 memcpy_toio(iommu->mmio_base + MMIO_GA_LOG_BASE_OFFSET,
821 &entry, sizeof(entry));
822 entry = (iommu_virt_to_phys(iommu->ga_log_tail) &
823 (BIT_ULL(52)-1)) & ~7ULL;
824 memcpy_toio(iommu->mmio_base + MMIO_GA_LOG_TAIL_OFFSET,
825 &entry, sizeof(entry));
826 writel(0x00, iommu->mmio_base + MMIO_GA_HEAD_OFFSET);
827 writel(0x00, iommu->mmio_base + MMIO_GA_TAIL_OFFSET);
828
829
830 iommu_feature_enable(iommu, CONTROL_GAINT_EN);
831 iommu_feature_enable(iommu, CONTROL_GALOG_EN);
832
833 for (i = 0; i < LOOP_TIMEOUT; ++i) {
834 status = readl(iommu->mmio_base + MMIO_STATUS_OFFSET);
835 if (status & (MMIO_STATUS_GALOG_RUN_MASK))
836 break;
> 837 udelay(1);
838 }
839
840 if (WARN_ON(i >= LOOP_TIMEOUT))
841 return -EINVAL;
842 #endif /* CONFIG_IRQ_REMAP */
843 return 0;
844 }
845
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] iommu/amd: Fix loop timeout issue in iommu_ga_log_enable()
Date: Tue, 01 Feb 2022 15:01:19 +0800 [thread overview]
Message-ID: <202202011448.2UFIiZHD-lkp@intel.com> (raw)
In-Reply-To: <20220131161749.4021-1-joro@8bytes.org>
[-- Attachment #1: Type: text/plain, Size: 3283 bytes --]
Hi Joerg,
I love your patch! Yet something to improve:
[auto build test ERROR on joro-iommu/next]
[also build test ERROR on v5.17-rc2 next-20220131]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Joerg-Roedel/iommu-amd-Fix-loop-timeout-issue-in-iommu_ga_log_enable/20220201-002214
base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220201/202202011448.2UFIiZHD-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/5b5785526da0e2a6e793d2107d09afc9f310f17f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Joerg-Roedel/iommu-amd-Fix-loop-timeout-issue-in-iommu_ga_log_enable/20220201-002214
git checkout 5b5785526da0e2a6e793d2107d09afc9f310f17f
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/iommu/amd/init.c: In function 'iommu_ga_log_enable':
>> drivers/iommu/amd/init.c:837:3: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration]
837 | udelay(1);
| ^~~~~~
cc1: some warnings being treated as errors
vim +/udelay +837 drivers/iommu/amd/init.c
804
805 static int iommu_ga_log_enable(struct amd_iommu *iommu)
806 {
807 #ifdef CONFIG_IRQ_REMAP
808 u32 status, i;
809 u64 entry;
810
811 if (!iommu->ga_log)
812 return -EINVAL;
813
814 /* Check if already running */
815 status = readl(iommu->mmio_base + MMIO_STATUS_OFFSET);
816 if (WARN_ON(status & (MMIO_STATUS_GALOG_RUN_MASK)))
817 return 0;
818
819 entry = iommu_virt_to_phys(iommu->ga_log) | GA_LOG_SIZE_512;
820 memcpy_toio(iommu->mmio_base + MMIO_GA_LOG_BASE_OFFSET,
821 &entry, sizeof(entry));
822 entry = (iommu_virt_to_phys(iommu->ga_log_tail) &
823 (BIT_ULL(52)-1)) & ~7ULL;
824 memcpy_toio(iommu->mmio_base + MMIO_GA_LOG_TAIL_OFFSET,
825 &entry, sizeof(entry));
826 writel(0x00, iommu->mmio_base + MMIO_GA_HEAD_OFFSET);
827 writel(0x00, iommu->mmio_base + MMIO_GA_TAIL_OFFSET);
828
829
830 iommu_feature_enable(iommu, CONTROL_GAINT_EN);
831 iommu_feature_enable(iommu, CONTROL_GALOG_EN);
832
833 for (i = 0; i < LOOP_TIMEOUT; ++i) {
834 status = readl(iommu->mmio_base + MMIO_STATUS_OFFSET);
835 if (status & (MMIO_STATUS_GALOG_RUN_MASK))
836 break;
> 837 udelay(1);
838 }
839
840 if (WARN_ON(i >= LOOP_TIMEOUT))
841 return -EINVAL;
842 #endif /* CONFIG_IRQ_REMAP */
843 return 0;
844 }
845
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org
Cc: kbuild-all@lists.01.org, Joerg Roedel <joro@8bytes.org>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org,
Maxim Levitsky <mlevitsk@redhat.com>
Subject: Re: [PATCH] iommu/amd: Fix loop timeout issue in iommu_ga_log_enable()
Date: Tue, 1 Feb 2022 15:01:19 +0800 [thread overview]
Message-ID: <202202011448.2UFIiZHD-lkp@intel.com> (raw)
In-Reply-To: <20220131161749.4021-1-joro@8bytes.org>
Hi Joerg,
I love your patch! Yet something to improve:
[auto build test ERROR on joro-iommu/next]
[also build test ERROR on v5.17-rc2 next-20220131]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Joerg-Roedel/iommu-amd-Fix-loop-timeout-issue-in-iommu_ga_log_enable/20220201-002214
base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220201/202202011448.2UFIiZHD-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/5b5785526da0e2a6e793d2107d09afc9f310f17f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Joerg-Roedel/iommu-amd-Fix-loop-timeout-issue-in-iommu_ga_log_enable/20220201-002214
git checkout 5b5785526da0e2a6e793d2107d09afc9f310f17f
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/iommu/amd/init.c: In function 'iommu_ga_log_enable':
>> drivers/iommu/amd/init.c:837:3: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration]
837 | udelay(1);
| ^~~~~~
cc1: some warnings being treated as errors
vim +/udelay +837 drivers/iommu/amd/init.c
804
805 static int iommu_ga_log_enable(struct amd_iommu *iommu)
806 {
807 #ifdef CONFIG_IRQ_REMAP
808 u32 status, i;
809 u64 entry;
810
811 if (!iommu->ga_log)
812 return -EINVAL;
813
814 /* Check if already running */
815 status = readl(iommu->mmio_base + MMIO_STATUS_OFFSET);
816 if (WARN_ON(status & (MMIO_STATUS_GALOG_RUN_MASK)))
817 return 0;
818
819 entry = iommu_virt_to_phys(iommu->ga_log) | GA_LOG_SIZE_512;
820 memcpy_toio(iommu->mmio_base + MMIO_GA_LOG_BASE_OFFSET,
821 &entry, sizeof(entry));
822 entry = (iommu_virt_to_phys(iommu->ga_log_tail) &
823 (BIT_ULL(52)-1)) & ~7ULL;
824 memcpy_toio(iommu->mmio_base + MMIO_GA_LOG_TAIL_OFFSET,
825 &entry, sizeof(entry));
826 writel(0x00, iommu->mmio_base + MMIO_GA_HEAD_OFFSET);
827 writel(0x00, iommu->mmio_base + MMIO_GA_TAIL_OFFSET);
828
829
830 iommu_feature_enable(iommu, CONTROL_GAINT_EN);
831 iommu_feature_enable(iommu, CONTROL_GALOG_EN);
832
833 for (i = 0; i < LOOP_TIMEOUT; ++i) {
834 status = readl(iommu->mmio_base + MMIO_STATUS_OFFSET);
835 if (status & (MMIO_STATUS_GALOG_RUN_MASK))
836 break;
> 837 udelay(1);
838 }
839
840 if (WARN_ON(i >= LOOP_TIMEOUT))
841 return -EINVAL;
842 #endif /* CONFIG_IRQ_REMAP */
843 return 0;
844 }
845
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2022-02-01 7:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 16:17 [PATCH] iommu/amd: Fix loop timeout issue in iommu_ga_log_enable() Joerg Roedel
2022-01-31 16:17 ` Joerg Roedel
2022-01-31 17:06 ` John Garry via iommu
2022-01-31 17:06 ` John Garry
2022-02-04 11:34 ` Joerg Roedel
2022-02-04 11:34 ` Joerg Roedel
2022-02-01 7:01 ` kernel test robot [this message]
2022-02-01 7:01 ` kernel test robot
2022-02-01 7:01 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202202011448.2UFIiZHD-lkp@intel.com \
--to=lkp@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.