Re: [RFC PATCH v2 3/3] Register auxiliary device for PCIe enclosure management

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4178 bytes --]

Hi Stuart,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on helgaas-pci/next]
[also build test ERROR on char-misc/char-misc-testing pavel-leds/for-next linus/master v5.17-rc2 next-20220202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Stuart-Hayes/Add-PCIe-enclosure-management-support/20220203-020040
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-randconfig-a003-20220131 (https://download.01.org/0day-ci/archive/20220203/202202031257.yEkdbEE2-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/407e7eb11ce495697eb2ee66d77f20d69548be14
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Stuart-Hayes/Add-PCIe-enclosure-management-support/20220203-020040
        git checkout 407e7eb11ce495697eb2ee66d77f20d69548be14
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: drivers/nvme/host/pci.o: in function `register_pcie_em_auxdev':
>> include/linux/pcie_em.h:71: undefined reference to `auxiliary_device_init'
>> ld: include/linux/pcie_em.h:75: undefined reference to `__auxiliary_device_add'


vim +71 include/linux/pcie_em.h

eefb0f75026145 Stuart Hayes 2022-02-02  53  
eefb0f75026145 Stuart Hayes 2022-02-02  54  static inline struct auxiliary_device *register_pcie_em_auxdev(struct device *dev, int id)
eefb0f75026145 Stuart Hayes 2022-02-02  55  {
eefb0f75026145 Stuart Hayes 2022-02-02  56  	struct auxiliary_device *adev;
eefb0f75026145 Stuart Hayes 2022-02-02  57  	int ret;
eefb0f75026145 Stuart Hayes 2022-02-02  58  
eefb0f75026145 Stuart Hayes 2022-02-02  59  	if (!pci_has_enclosure_management(to_pci_dev(dev)))
eefb0f75026145 Stuart Hayes 2022-02-02  60  		return NULL;
eefb0f75026145 Stuart Hayes 2022-02-02  61  
eefb0f75026145 Stuart Hayes 2022-02-02  62  	adev = kzalloc(sizeof(*adev), GFP_KERNEL);
eefb0f75026145 Stuart Hayes 2022-02-02  63  	if (!adev)
eefb0f75026145 Stuart Hayes 2022-02-02  64  		goto em_reg_out_err;
eefb0f75026145 Stuart Hayes 2022-02-02  65  
eefb0f75026145 Stuart Hayes 2022-02-02  66  	adev->name = "pcie_em";
eefb0f75026145 Stuart Hayes 2022-02-02  67  	adev->dev.parent = dev;
eefb0f75026145 Stuart Hayes 2022-02-02  68  	adev->dev.release = release_pcie_em_aux_device;
eefb0f75026145 Stuart Hayes 2022-02-02  69  	adev->id = id;
eefb0f75026145 Stuart Hayes 2022-02-02  70  
eefb0f75026145 Stuart Hayes 2022-02-02 @71  	ret = auxiliary_device_init(adev);
eefb0f75026145 Stuart Hayes 2022-02-02  72  	if (ret < 0)
eefb0f75026145 Stuart Hayes 2022-02-02  73  		goto em_reg_out_free;
eefb0f75026145 Stuart Hayes 2022-02-02  74  
eefb0f75026145 Stuart Hayes 2022-02-02 @75  	ret = auxiliary_device_add(adev);
eefb0f75026145 Stuart Hayes 2022-02-02  76  	if (ret) {
eefb0f75026145 Stuart Hayes 2022-02-02  77  		auxiliary_device_uninit(adev);
eefb0f75026145 Stuart Hayes 2022-02-02  78  		goto em_reg_out_free;
eefb0f75026145 Stuart Hayes 2022-02-02  79  	}
eefb0f75026145 Stuart Hayes 2022-02-02  80  
eefb0f75026145 Stuart Hayes 2022-02-02  81  	return adev;
eefb0f75026145 Stuart Hayes 2022-02-02  82  em_reg_out_free:
eefb0f75026145 Stuart Hayes 2022-02-02  83  	kfree(adev);
eefb0f75026145 Stuart Hayes 2022-02-02  84  em_reg_out_err:
eefb0f75026145 Stuart Hayes 2022-02-02  85  	dev_warn(dev, "failed to register pcie_em device\n");
eefb0f75026145 Stuart Hayes 2022-02-02  86  	return NULL;
eefb0f75026145 Stuart Hayes 2022-02-02  87  }
eefb0f75026145 Stuart Hayes 2022-02-02  88  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org