Re: [RFC PATCH v2 3/3] Register auxiliary device for PCIe enclosure management

[kernel test robot <lkp@intel.com>]

Hi Stuart,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on helgaas-pci/next]
[also build test WARNING on char-misc/char-misc-testing pavel-leds/for-next linus/master v5.17-rc2 next-20220202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Stuart-Hayes/Add-PCIe-enclosure-management-support/20220203-020040
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-randconfig-a015-20220131 (https://download.01.org/0day-ci/archive/20220203/202202031021.1ORRkl1U-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 6b1e844b69f15bb7dffaf9365cd2b355d2eb7579)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/407e7eb11ce495697eb2ee66d77f20d69548be14
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Stuart-Hayes/Add-PCIe-enclosure-management-support/20220203-020040
        git checkout 407e7eb11ce495697eb2ee66d77f20d69548be14
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/iio/frequency/ drivers/nvme/host/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/nvme/host/pci.c:31:
>> include/linux/pcie_em.h:25:38: warning: use of logical '||' with constant operand [-Wconstant-logical-operand]
                                      1 << GET_SUPPORTED_STATES_DSM ||
                                                                    ^
   include/linux/pcie_em.h:25:38: note: use '|' for a bitwise operation
                                      1 << GET_SUPPORTED_STATES_DSM ||
                                                                    ^~
                                                                    |
   include/linux/pcie_em.h:26:27: warning: use of logical '||' with constant operand [-Wconstant-logical-operand]
                                      1 << GET_STATE_DSM ||
                                                         ^
   include/linux/pcie_em.h:26:27: note: use '|' for a bitwise operation
                                      1 << GET_STATE_DSM ||
                                                         ^~
                                                         |
>> include/linux/pcie_em.h:27:10: warning: converting the result of '<<' to a boolean always evaluates to true [-Wtautological-constant-compare]
                                      1 << SET_STATE_DSM))
                                        ^
   include/linux/pcie_em.h:25:10: warning: converting the result of '<<' to a boolean always evaluates to true [-Wtautological-constant-compare]
                                      1 << GET_SUPPORTED_STATES_DSM ||
                                        ^
   include/linux/pcie_em.h:26:10: warning: converting the result of '<<' to a boolean always evaluates to true [-Wtautological-constant-compare]
                                      1 << GET_STATE_DSM ||
                                        ^
   5 warnings generated.


vim +25 include/linux/pcie_em.h

eefb0f75026145 Stuart Hayes 2022-02-02  15  
eefb0f75026145 Stuart Hayes 2022-02-02  16  static inline bool pci_has_pcie_em_dsm(struct pci_dev *pdev)
eefb0f75026145 Stuart Hayes 2022-02-02  17  {
eefb0f75026145 Stuart Hayes 2022-02-02  18  #ifdef CONFIG_ACPI
eefb0f75026145 Stuart Hayes 2022-02-02  19  	acpi_handle handle;
eefb0f75026145 Stuart Hayes 2022-02-02  20  	const guid_t pcie_ssd_leds_dsm_guid = PCIE_SSD_LEDS_DSM_GUID;
eefb0f75026145 Stuart Hayes 2022-02-02  21  
eefb0f75026145 Stuart Hayes 2022-02-02  22  	handle = ACPI_HANDLE(&pdev->dev);
eefb0f75026145 Stuart Hayes 2022-02-02  23  	if (handle)
eefb0f75026145 Stuart Hayes 2022-02-02  24  		if (acpi_check_dsm(handle, &pcie_ssd_leds_dsm_guid, 0x1,
eefb0f75026145 Stuart Hayes 2022-02-02 @25  				   1 << GET_SUPPORTED_STATES_DSM ||
eefb0f75026145 Stuart Hayes 2022-02-02 @26  				   1 << GET_STATE_DSM ||
eefb0f75026145 Stuart Hayes 2022-02-02 @27  				   1 << SET_STATE_DSM))
eefb0f75026145 Stuart Hayes 2022-02-02  28  			return true;
eefb0f75026145 Stuart Hayes 2022-02-02  29  #endif
eefb0f75026145 Stuart Hayes 2022-02-02  30  	return false;
eefb0f75026145 Stuart Hayes 2022-02-02  31  }
eefb0f75026145 Stuart Hayes 2022-02-02  32  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org