From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v32 24/28] Audit: Add framework for auxiliary records
Date: Thu, 03 Feb 2022 14:34:49 +0800 [thread overview]
Message-ID: <202202031436.8ZZBmoEC-lkp@intel.com> (raw)
In-Reply-To: <20220202235323.23929-25-casey@schaufler-ca.com>
[-- Attachment #1: Type: text/plain, Size: 4040 bytes --]
Hi Casey,
I love your patch! Perhaps something to improve:
[auto build test WARNING on pcmoore-audit/next]
[also build test WARNING on nf-next/master nf/master linus/master v5.17-rc2]
[cannot apply to jmorris-security/next-testing]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Casey-Schaufler/integrity-disassociate-ima_filter_rule-from-security_audit_rule/20220203-085302
base: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git next
config: arc-randconfig-r043-20220131 (https://download.01.org/0day-ci/archive/20220203/202202031436.8ZZBmoEC-lkp(a)intel.com/config)
compiler: arc-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/25bd76f704528c053f7260a22eeecbd214b11982
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Casey-Schaufler/integrity-disassociate-ima_filter_rule-from-security_audit_rule/20220203-085302
git checkout 25bd76f704528c053f7260a22eeecbd214b11982
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
kernel/audit.c:1804:14: warning: no previous prototype for 'audit_serial' [-Wmissing-prototypes]
1804 | unsigned int audit_serial(void)
| ^~~~~~~~~~~~
kernel/audit.c: In function 'audit_log_vformat':
kernel/audit.c:1954:9: warning: function 'audit_log_vformat' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
1954 | len = vsnprintf(skb_tail_pointer(skb), avail, fmt, args);
| ^~~
kernel/audit.c:1963:17: warning: function 'audit_log_vformat' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
1963 | len = vsnprintf(skb_tail_pointer(skb), avail, fmt, args2);
| ^~~
kernel/audit.c: At top level:
>> kernel/audit.c:2399:6: warning: no previous prototype for '__audit_log_end' [-Wmissing-prototypes]
2399 | void __audit_log_end(struct audit_buffer *ab)
| ^~~~~~~~~~~~~~~
vim +/__audit_log_end +2399 kernel/audit.c
2389
2390 /**
2391 * __audit_log_end - end one audit record
2392 * @ab: the audit_buffer
2393 *
2394 * We can not do a netlink send inside an irq context because it blocks (last
2395 * arg, flags, is not set to MSG_DONTWAIT), so the audit buffer is placed on a
2396 * queue and a kthread is scheduled to remove them from the queue outside the
2397 * irq context. May be called in any context.
2398 */
> 2399 void __audit_log_end(struct audit_buffer *ab)
2400 {
2401 struct sk_buff *skb;
2402 struct nlmsghdr *nlh;
2403
2404 if (!ab)
2405 return;
2406
2407 if (audit_rate_check()) {
2408 skb = ab->skb;
2409 ab->skb = NULL;
2410
2411 /* setup the netlink header, see the comments in
2412 * kauditd_send_multicast_skb() for length quirks */
2413 nlh = nlmsg_hdr(skb);
2414 nlh->nlmsg_len = skb->len - NLMSG_HDRLEN;
2415
2416 /* queue the netlink packet and poke the kauditd thread */
2417 skb_queue_tail(&audit_queue, skb);
2418 wake_up_interruptible(&kauditd_wait);
2419 } else
2420 audit_log_lost("rate limit exceeded");
2421 }
2422
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2022-02-03 6:34 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220202235323.23929-1-casey.ref@schaufler-ca.com>
2022-02-02 23:52 ` [PATCH v32 00/28] LSM: Module stacking for AppArmor Casey Schaufler
2022-02-02 23:52 ` Casey Schaufler
2022-02-02 23:52 ` [PATCH v32 01/28] integrity: disassociate ima_filter_rule from security_audit_rule Casey Schaufler
2022-02-02 23:52 ` Casey Schaufler
2022-02-02 23:52 ` [PATCH v32 02/28] LSM: Infrastructure management of the sock security Casey Schaufler
2022-02-02 23:52 ` Casey Schaufler
2022-02-02 23:52 ` [PATCH v32 03/28] LSM: Add the lsmblob data structure Casey Schaufler
2022-02-02 23:52 ` Casey Schaufler
2022-03-04 10:48 ` Mickaël Salaün
2022-03-04 10:48 ` Mickaël Salaün
2022-03-04 19:14 ` Casey Schaufler
2022-03-04 19:14 ` Casey Schaufler
2022-02-02 23:52 ` [PATCH v32 04/28] LSM: provide lsm name and id slot mappings Casey Schaufler
2022-02-02 23:52 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 05/28] IMA: avoid label collisions with stacked LSMs Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-22 23:20 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 06/28] LSM: Use lsmblob in security_audit_rule_match Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 07/28] LSM: Use lsmblob in security_kernel_act_as Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 08/28] LSM: Use lsmblob in security_secctx_to_secid Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 09/28] LSM: Use lsmblob in security_secid_to_secctx Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 10/28] LSM: Use lsmblob in security_ipc_getsecid Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 11/28] LSM: Use lsmblob in security_current_getsecid Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 12/28] LSM: Use lsmblob in security_inode_getsecid Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 13/28] LSM: Use lsmblob in security_cred_getsecid Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-03 5:23 ` kernel test robot
2022-02-03 5:23 ` kernel test robot
2022-02-03 14:07 ` kernel test robot
2022-02-02 23:53 ` [PATCH v32 14/28] LSM: Specify which LSM to display Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 15/28] LSM: Ensure the correct LSM context releaser Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 16/28] LSM: Use lsmcontext in security_secid_to_secctx Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 17/28] LSM: Use lsmcontext in security_inode_getsecctx Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 18/28] LSM: security_secid_to_secctx in netlink netfilter Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 19/28] NET: Store LSM netlabel data in a lsmblob Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 20/28] binder: Pass LSM identifier for confirmation Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 21/28] LSM: Extend security_secid_to_secctx to include module selection Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 22/28] Audit: Keep multiple LSM data in audit_names Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 23/28] Audit: Create audit_stamp structure Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 24/28] Audit: Add framework for auxiliary records Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-03 6:34 ` kernel test robot [this message]
2022-02-03 22:33 ` [RFC PATCH] Audit: __audit_log_end() can be static kernel test robot
2022-02-04 1:30 ` [PATCH v32 24/28] Audit: Add framework for auxiliary records kernel test robot
2022-03-02 22:32 ` Casey Schaufler
2022-03-02 22:32 ` Casey Schaufler
2022-03-03 22:27 ` Paul Moore
2022-03-03 22:27 ` Paul Moore
2022-03-03 22:33 ` Casey Schaufler
2022-03-03 22:33 ` Casey Schaufler
2022-03-03 22:43 ` Paul Moore
2022-03-03 22:43 ` Paul Moore
2022-03-03 22:55 ` Casey Schaufler
2022-03-03 22:55 ` Casey Schaufler
2022-03-03 23:36 ` Paul Moore
2022-03-03 23:36 ` Paul Moore
2022-03-04 2:13 ` Casey Schaufler
2022-03-04 2:13 ` Casey Schaufler
2022-03-04 14:43 ` Paul Moore
2022-03-04 14:43 ` Paul Moore
2022-02-02 23:53 ` [PATCH v32 25/28] Audit: Add record for multiple task security contexts Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 26/28] Audit: Add record for multiple object " Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-03 5:23 ` kernel test robot
2022-02-03 5:43 ` kernel test robot
2022-03-03 23:36 ` Paul Moore
2022-03-03 23:36 ` Paul Moore
2022-03-04 1:26 ` Casey Schaufler
2022-03-04 1:26 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 27/28] LSM: Add /proc attr entry for full LSM context Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
2022-02-02 23:53 ` [PATCH v32 28/28] AppArmor: Remove the exclusive flag Casey Schaufler
2022-02-02 23:53 ` Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202202031436.8ZZBmoEC-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.