Re: [PATCH 1/6] spi: tegra210-quad: use device_reset method

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 6107 bytes --]

Hi Krishna,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on broonie-spi/for-next]
[also build test WARNING on v5.17-rc2 next-20220204]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Krishna-Yarlagadda/Tegra-QUAD-SPI-combined-sequence-mode/20220204-183224
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20220204/202202042014.dJC3BvqS-lkp(a)intel.com/config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/6bd51e7b07329b4ee4e90f5bc5aa8372ef26c999
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Krishna-Yarlagadda/Tegra-QUAD-SPI-combined-sequence-mode/20220204-183224
        git checkout 6bd51e7b07329b4ee4e90f5bc5aa8372ef26c999
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash drivers/spi/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/spi/spi-tegra210-quad.c: In function 'tegra_qspi_probe':
>> drivers/spi/spi-tegra210-quad.c:1270:9: warning: ignoring return value of 'device_reset' declared with attribute 'warn_unused_result' [-Wunused-result]
    1270 |         device_reset(tqspi->dev);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/spi/spi-tegra210-quad.c: In function 'tegra_qspi_handle_error':
   drivers/spi/spi-tegra210-quad.c:950:9: warning: ignoring return value of 'device_reset' declared with attribute 'warn_unused_result' [-Wunused-result]
     950 |         device_reset(tqspi->dev);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~


vim +1270 drivers/spi/spi-tegra210-quad.c

  1201	
  1202	static int tegra_qspi_probe(struct platform_device *pdev)
  1203	{
  1204		struct spi_master	*master;
  1205		struct tegra_qspi	*tqspi;
  1206		struct resource		*r;
  1207		int ret, qspi_irq;
  1208		int bus_num;
  1209	
  1210		master = devm_spi_alloc_master(&pdev->dev, sizeof(*tqspi));
  1211		if (!master)
  1212			return -ENOMEM;
  1213	
  1214		platform_set_drvdata(pdev, master);
  1215		tqspi = spi_master_get_devdata(master);
  1216	
  1217		master->mode_bits = SPI_MODE_0 | SPI_MODE_3 | SPI_CS_HIGH |
  1218				    SPI_TX_DUAL | SPI_RX_DUAL | SPI_TX_QUAD | SPI_RX_QUAD;
  1219		master->bits_per_word_mask = SPI_BPW_MASK(32) | SPI_BPW_MASK(16) | SPI_BPW_MASK(8);
  1220		master->setup = tegra_qspi_setup;
  1221		master->transfer_one_message = tegra_qspi_transfer_one_message;
  1222		master->num_chipselect = 1;
  1223		master->auto_runtime_pm = true;
  1224	
  1225		bus_num = of_alias_get_id(pdev->dev.of_node, "spi");
  1226		if (bus_num >= 0)
  1227			master->bus_num = bus_num;
  1228	
  1229		tqspi->master = master;
  1230		tqspi->dev = &pdev->dev;
  1231		spin_lock_init(&tqspi->lock);
  1232	
  1233		r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
  1234		tqspi->base = devm_ioremap_resource(&pdev->dev, r);
  1235		if (IS_ERR(tqspi->base))
  1236			return PTR_ERR(tqspi->base);
  1237	
  1238		tqspi->phys = r->start;
  1239		qspi_irq = platform_get_irq(pdev, 0);
  1240		tqspi->irq = qspi_irq;
  1241	
  1242		tqspi->clk = devm_clk_get(&pdev->dev, "qspi");
  1243		if (IS_ERR(tqspi->clk)) {
  1244			ret = PTR_ERR(tqspi->clk);
  1245			dev_err(&pdev->dev, "failed to get clock: %d\n", ret);
  1246			return ret;
  1247		}
  1248	
  1249		tqspi->max_buf_size = QSPI_FIFO_DEPTH << 2;
  1250		tqspi->dma_buf_size = DEFAULT_QSPI_DMA_BUF_LEN;
  1251	
  1252		ret = tegra_qspi_init_dma(tqspi);
  1253		if (ret < 0)
  1254			return ret;
  1255	
  1256		if (tqspi->use_dma)
  1257			tqspi->max_buf_size = tqspi->dma_buf_size;
  1258	
  1259		init_completion(&tqspi->tx_dma_complete);
  1260		init_completion(&tqspi->rx_dma_complete);
  1261		init_completion(&tqspi->xfer_completion);
  1262	
  1263		pm_runtime_enable(&pdev->dev);
  1264		ret = pm_runtime_resume_and_get(&pdev->dev);
  1265		if (ret < 0) {
  1266			dev_err(&pdev->dev, "failed to get runtime PM: %d\n", ret);
  1267			goto exit_pm_disable;
  1268		}
  1269	
> 1270		device_reset(tqspi->dev);
  1271	
  1272		tqspi->def_command1_reg = QSPI_M_S | QSPI_CS_SW_HW |  QSPI_CS_SW_VAL;
  1273		tegra_qspi_writel(tqspi, tqspi->def_command1_reg, QSPI_COMMAND1);
  1274		tqspi->spi_cs_timing1 = tegra_qspi_readl(tqspi, QSPI_CS_TIMING1);
  1275		tqspi->spi_cs_timing2 = tegra_qspi_readl(tqspi, QSPI_CS_TIMING2);
  1276		tqspi->def_command2_reg = tegra_qspi_readl(tqspi, QSPI_COMMAND2);
  1277	
  1278		pm_runtime_put(&pdev->dev);
  1279	
  1280		ret = request_threaded_irq(tqspi->irq, NULL,
  1281					   tegra_qspi_isr_thread, IRQF_ONESHOT,
  1282					   dev_name(&pdev->dev), tqspi);
  1283		if (ret < 0) {
  1284			dev_err(&pdev->dev, "failed to request IRQ#%u: %d\n", tqspi->irq, ret);
  1285			goto exit_pm_disable;
  1286		}
  1287	
  1288		master->dev.of_node = pdev->dev.of_node;
  1289		ret = spi_register_master(master);
  1290		if (ret < 0) {
  1291			dev_err(&pdev->dev, "failed to register master: %d\n", ret);
  1292			goto exit_free_irq;
  1293		}
  1294	
  1295		return 0;
  1296	
  1297	exit_free_irq:
  1298		free_irq(qspi_irq, tqspi);
  1299	exit_pm_disable:
  1300		pm_runtime_force_suspend(&pdev->dev);
  1301		tegra_qspi_deinit_dma(tqspi);
  1302		return ret;
  1303	}
  1304	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org