From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] PCI:pciehp: Replace request_threaded_irq with devm_request_threaded_irq
Date: Mon, 07 Feb 2022 02:37:18 +0800 [thread overview]
Message-ID: <202202070253.VcJImRNn-lkp@intel.com> (raw)
In-Reply-To: <20220206140705.10705-1-sensor1010@163.com>
[-- Attachment #1: Type: text/plain, Size: 8314 bytes --]
Hi lizhe,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on helgaas-pci/next]
[also build test ERROR on v5.17-rc2 next-20220204]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/lizhe/PCI-pciehp-Replace-request_threaded_irq-with-devm_request_threaded_irq/20220206-222442
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20220207/202202070253.VcJImRNn-lkp(a)intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/8c1aa010219ad629dc74363ec0392a9e868ca536
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review lizhe/PCI-pciehp-Replace-request_threaded_irq-with-devm_request_threaded_irq/20220206-222442
git checkout 8c1aa010219ad629dc74363ec0392a9e868ca536
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/pci/hotplug/pciehp_hpc.c: In function 'pciehp_request_irq':
drivers/pci/hotplug/pciehp_hpc.c:69:44: warning: passing argument 1 of 'devm_request_threaded_irq' makes pointer from integer without a cast [-Wint-conversion]
69 | retval = devm_request_threaded_irq(irq, pciehp_isr, pciehp_ist,
| ^~~
| |
| int
In file included from include/linux/pci.h:38,
from drivers/pci/hotplug/pciehp_hpc.c:22:
include/linux/interrupt.h:205:42: note: expected 'struct device *' but argument is of type 'int'
205 | devm_request_threaded_irq(struct device *dev, unsigned int irq,
| ~~~~~~~~~~~~~~~^~~
drivers/pci/hotplug/pciehp_hpc.c:69:49: warning: passing argument 2 of 'devm_request_threaded_irq' makes integer from pointer without a cast [-Wint-conversion]
69 | retval = devm_request_threaded_irq(irq, pciehp_isr, pciehp_ist,
| ^~~~~~~~~~
| |
| irqreturn_t (*)(int, void *) {aka enum irqreturn (*)(int, void *)}
In file included from include/linux/pci.h:38,
from drivers/pci/hotplug/pciehp_hpc.c:22:
include/linux/interrupt.h:205:60: note: expected 'unsigned int' but argument is of type 'irqreturn_t (*)(int, void *)' {aka 'enum irqreturn (*)(int, void *)'}
205 | devm_request_threaded_irq(struct device *dev, unsigned int irq,
| ~~~~~~~~~~~~~^~~
include/linux/interrupt.h:71:33: warning: passing argument 4 of 'devm_request_threaded_irq' makes pointer from integer without a cast [-Wint-conversion]
71 | #define IRQF_SHARED 0x00000080
| ^~~~~~~~~~
| |
| int
drivers/pci/hotplug/pciehp_hpc.c:70:39: note: in expansion of macro 'IRQF_SHARED'
70 | IRQF_SHARED, "pciehp", ctrl);
| ^~~~~~~~~~~
include/linux/interrupt.h:206:64: note: expected 'irq_handler_t' {aka 'enum irqreturn (*)(int, void *)'} but argument is of type 'int'
206 | irq_handler_t handler, irq_handler_t thread_fn,
| ~~~~~~~~~~~~~~^~~~~~~~~
drivers/pci/hotplug/pciehp_hpc.c:70:52: warning: passing argument 5 of 'devm_request_threaded_irq' makes integer from pointer without a cast [-Wint-conversion]
70 | IRQF_SHARED, "pciehp", ctrl);
| ^~~~~~~~
| |
| char *
In file included from include/linux/pci.h:38,
from drivers/pci/hotplug/pciehp_hpc.c:22:
include/linux/interrupt.h:207:41: note: expected 'long unsigned int' but argument is of type 'char *'
207 | unsigned long irqflags, const char *devname,
| ~~~~~~~~~~~~~~^~~~~~~~
>> drivers/pci/hotplug/pciehp_hpc.c:70:62: error: passing argument 6 of 'devm_request_threaded_irq' from incompatible pointer type [-Werror=incompatible-pointer-types]
70 | IRQF_SHARED, "pciehp", ctrl);
| ^~~~
| |
| struct controller *
In file included from include/linux/pci.h:38,
from drivers/pci/hotplug/pciehp_hpc.c:22:
include/linux/interrupt.h:207:63: note: expected 'const char *' but argument is of type 'struct controller *'
207 | unsigned long irqflags, const char *devname,
| ~~~~~~~~~~~~^~~~~~~
>> drivers/pci/hotplug/pciehp_hpc.c:69:18: error: too few arguments to function 'devm_request_threaded_irq'
69 | retval = devm_request_threaded_irq(irq, pciehp_isr, pciehp_ist,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/pci.h:38,
from drivers/pci/hotplug/pciehp_hpc.c:22:
include/linux/interrupt.h:205:1: note: declared here
205 | devm_request_threaded_irq(struct device *dev, unsigned int irq,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/devm_request_threaded_irq +70 drivers/pci/hotplug/pciehp_hpc.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 56
2aeeef11999590 Kenji Kaneshige 2008-04-25 57 static inline int pciehp_request_irq(struct controller *ctrl)
2aeeef11999590 Kenji Kaneshige 2008-04-25 58 {
f7a10e32a1a7ae Kenji Kaneshige 2008-08-22 59 int retval, irq = ctrl->pcie->irq;
2aeeef11999590 Kenji Kaneshige 2008-04-25 60
2aeeef11999590 Kenji Kaneshige 2008-04-25 61 if (pciehp_poll_mode) {
ec07a4473072ff Lukas Wunner 2018-07-19 62 ctrl->poll_thread = kthread_run(&pciehp_poll, ctrl,
ec07a4473072ff Lukas Wunner 2018-07-19 63 "pciehp_poll-%s",
5790a9c78e78aa Lukas Wunner 2018-09-18 64 slot_name(ctrl));
ec07a4473072ff Lukas Wunner 2018-07-19 65 return PTR_ERR_OR_ZERO(ctrl->poll_thread);
2aeeef11999590 Kenji Kaneshige 2008-04-25 66 }
2aeeef11999590 Kenji Kaneshige 2008-04-25 67
2aeeef11999590 Kenji Kaneshige 2008-04-25 68 /* Installs the interrupt handler */
8c1aa010219ad6 lizhe 2022-02-06 @69 retval = devm_request_threaded_irq(irq, pciehp_isr, pciehp_ist,
e07ca82a5fde88 Bjorn Helgaas 2019-05-08 @70 IRQF_SHARED, "pciehp", ctrl);
2aeeef11999590 Kenji Kaneshige 2008-04-25 71 if (retval)
7f2feec140f1f1 Taku Izumi 2008-09-05 72 ctrl_err(ctrl, "Cannot get irq %d for the hotplug controller\n",
7f2feec140f1f1 Taku Izumi 2008-09-05 73 irq);
2aeeef11999590 Kenji Kaneshige 2008-04-25 74 return retval;
2aeeef11999590 Kenji Kaneshige 2008-04-25 75 }
2aeeef11999590 Kenji Kaneshige 2008-04-25 76
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
prev parent reply other threads:[~2022-02-06 18:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 14:07 [PATCH] PCI:pciehp: Replace request_threaded_irq with devm_request_threaded_irq lizhe
2022-02-06 14:34 ` Hans de Goede
2022-02-06 16:14 ` kernel test robot
2022-02-06 18:37 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202202070253.VcJImRNn-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.