From: Stephen Hemminger <stephen@networkplumber.org>
To: Hans Schultz <schultz.hans@gmail.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
linux-kernel@vger.kernel.org,
Hans Schultz <schultz.hans+netdev@gmail.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
Roopa Prabhu <roopa@nvidia.com>,
kuba@kernel.org, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next 1/4] net: bridge: Add support for bridge port in locked mode
Date: Mon, 7 Feb 2022 09:30:48 -0800 [thread overview]
Message-ID: <20220207093048.24bb6249@hermes.local> (raw)
In-Reply-To: <20220207100742.15087-2-schultz.hans+netdev@gmail.com>
On Mon, 7 Feb 2022 11:07:39 +0100
Hans Schultz <schultz.hans@gmail.com> wrote:
> --- a/include/uapi/linux/if_link.h
> +++ b/include/uapi/linux/if_link.h
> @@ -532,6 +532,7 @@ enum {
> IFLA_BRPORT_GROUP_FWD_MASK,
> IFLA_BRPORT_NEIGH_SUPPRESS,
> IFLA_BRPORT_ISOLATED,
> + IFLA_BRPORT_LOCKED,
> IFLA_BRPORT_BACKUP_PORT,
> IFLA_BRPORT_MRP_RING_OPEN,
Adding new element in middle of enum causes them to be renumbered.
That breaks the kernel ABI. Please add only at end.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Hans Schultz <schultz.hans@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
Hans Schultz <schultz.hans+netdev@gmail.com>,
Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next 1/4] net: bridge: Add support for bridge port in locked mode
Date: Mon, 7 Feb 2022 09:30:48 -0800 [thread overview]
Message-ID: <20220207093048.24bb6249@hermes.local> (raw)
In-Reply-To: <20220207100742.15087-2-schultz.hans+netdev@gmail.com>
On Mon, 7 Feb 2022 11:07:39 +0100
Hans Schultz <schultz.hans@gmail.com> wrote:
> --- a/include/uapi/linux/if_link.h
> +++ b/include/uapi/linux/if_link.h
> @@ -532,6 +532,7 @@ enum {
> IFLA_BRPORT_GROUP_FWD_MASK,
> IFLA_BRPORT_NEIGH_SUPPRESS,
> IFLA_BRPORT_ISOLATED,
> + IFLA_BRPORT_LOCKED,
> IFLA_BRPORT_BACKUP_PORT,
> IFLA_BRPORT_MRP_RING_OPEN,
Adding new element in middle of enum causes them to be renumbered.
That breaks the kernel ABI. Please add only at end.
next prev parent reply other threads:[~2022-02-07 17:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 10:07 [PATCH net-next 0/4] Add support for locked bridge ports (for 802.1X) Hans Schultz
2022-02-07 10:07 ` [Bridge] [PATCH net-next 1/4] net: bridge: Add support for bridge port in locked mode Hans Schultz
2022-02-07 10:07 ` Hans Schultz
2022-02-07 10:49 ` [Bridge] " Ido Schimmel
2022-02-07 10:49 ` Ido Schimmel
2022-02-07 13:53 ` [Bridge] " Andrew Lunn
2022-02-07 13:53 ` Andrew Lunn
2022-02-08 9:06 ` [Bridge] " Hans Schultz
2022-02-08 9:06 ` Hans Schultz
2022-02-08 10:26 ` [Bridge] " Hans Schultz
2022-02-08 10:26 ` Hans Schultz
2022-02-07 17:30 ` Stephen Hemminger [this message]
2022-02-07 17:30 ` Stephen Hemminger
2024-05-21 19:27 ` Stephen Hemminger
2022-02-07 10:07 ` [Bridge] [PATCH net-next 2/4] net: bridge: dsa: Add support for offloading of locked port flag Hans Schultz
2022-02-07 10:07 ` Hans Schultz
2022-02-07 10:51 ` [Bridge] " Nikolay Aleksandrov
2022-02-07 10:51 ` Nikolay Aleksandrov
2022-02-07 10:07 ` [PATCH net-next 3/4] net: dsa: mv88e6xxx: Add support for bridge port locked feature Hans Schultz
2022-02-07 14:05 ` Andrew Lunn
2022-02-08 12:14 ` Hans Schultz
2022-02-08 13:26 ` Andrew Lunn
2022-02-07 10:07 ` [Bridge] [PATCH net-next 4/4] net: bridge: Refactor bridge port in locked mode to use jump labels Hans Schultz
2022-02-07 10:07 ` Hans Schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220207093048.24bb6249@hermes.local \
--to=stephen@networkplumber.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
--cc=schultz.hans+netdev@gmail.com \
--cc=schultz.hans@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.