* + ubsan-no-need-to-unset-panic_on_warn-in-ubsan_epilogue.patch added to -mm tree
@ 2022-02-08 20:36 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2022-02-08 20:36 UTC (permalink / raw)
To: mm-commits, ryabinin.a.a, lixuefeng, elver, corbet, bhe,
yangtiezhu, akpm
The patch titled
Subject: ubsan: no need to unset panic_on_warn in ubsan_epilogue()
has been added to the -mm tree. Its filename is
ubsan-no-need-to-unset-panic_on_warn-in-ubsan_epilogue.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/ubsan-no-need-to-unset-panic_on_warn-in-ubsan_epilogue.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/ubsan-no-need-to-unset-panic_on_warn-in-ubsan_epilogue.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Tiezhu Yang <yangtiezhu@loongson.cn>
Subject: ubsan: no need to unset panic_on_warn in ubsan_epilogue()
panic_on_warn is unset inside panic(), so no need to unset it before
calling panic() in ubsan_epilogue().
Link: https://lkml.kernel.org/r/1644324666-15947-5-git-send-email-yangtiezhu@loongson.cn
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Marco Elver <elver@google.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Cc: Baoquan He <bhe@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Xuefeng Li <lixuefeng@loongson.cn>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
lib/ubsan.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
--- a/lib/ubsan.c~ubsan-no-need-to-unset-panic_on_warn-in-ubsan_epilogue
+++ a/lib/ubsan.c
@@ -154,16 +154,8 @@ static void ubsan_epilogue(void)
current->in_ubsan--;
- if (panic_on_warn) {
- /*
- * This thread may hit another WARN() in the panic path.
- * Resetting this prevents additional WARN() from panicking the
- * system on this thread. Other threads are blocked by the
- * panic_mutex in panic().
- */
- panic_on_warn = 0;
+ if (panic_on_warn)
panic("panic_on_warn set ...\n");
- }
}
void __ubsan_handle_divrem_overflow(void *_data, void *lhs, void *rhs)
_
Patches currently in -mm which might be from yangtiezhu@loongson.cn are
docs-kdump-update-description-about-sysfs-file-system-support.patch
docs-kdump-add-scp-example-to-write-out-the-dump-file.patch
panic-unset-panic_on_warn-inside-panic.patch
ubsan-no-need-to-unset-panic_on_warn-in-ubsan_epilogue.patch
kasan-no-need-to-unset-panic_on_warn-in-end_report.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-02-08 22:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-08 20:36 + ubsan-no-need-to-unset-panic_on_warn-in-ubsan_epilogue.patch added to -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.