From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, sagi@grimberg.me,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Vidya Sagar <vidyas@nvidia.com>
Subject: Re: [PATCH] nvme/pci: default to simple suspend
Date: Wed, 9 Feb 2022 08:48:45 +0100 [thread overview]
Message-ID: <20220209074845.GA9540@lst.de> (raw)
In-Reply-To: <20220208171421.GA1168214@dhcp-10-100-145-180.wdc.com>
On Tue, Feb 08, 2022 at 09:14:21AM -0800, Keith Busch wrote:
> > I don't think this will work, as most older platforms just won't have
> > that attribute at all, and non-ACPI platforms most certainly won't have
> > it. We'll need more quirks in the core PCI/PM code like we did for the
> > AMD mobile platforms.
>
> old platform + old kernel -> simple suspend
>
> old platform + new kernel -> nvme pm
>
> This inevitably introduced regressions. Why should we need to quirk old
> platforms for a feature that didn't even exist when they were made?
> Shouldn't the quirk be the other way around?
Because they are broken? If we do get a suspend request that does not
explicitly asks for the device do be disabled we need to be able to rely
on that. Where we is not just nvme, but any driver.
next prev parent reply other threads:[~2022-02-09 7:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 16:50 [PATCH] nvme/pci: default to simple suspend Keith Busch
2022-02-01 17:49 ` Vidya Sagar
2022-02-02 7:55 ` Christoph Hellwig
2022-02-02 16:03 ` Keith Busch
2022-02-04 7:10 ` Christoph Hellwig
2022-02-07 16:06 ` Keith Busch
2022-02-08 14:37 ` Christoph Hellwig
2022-02-08 17:14 ` Keith Busch
2022-02-09 7:48 ` Christoph Hellwig [this message]
2022-04-11 13:58 ` Manivannan Sadhasivam
2022-04-23 5:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209074845.GA9540@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=sagi@grimberg.me \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.