From: Christoph Hellwig <hch@lst.de>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Vidya Sagar <vidyas@nvidia.com>,
kbusch@kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] nvme/pci: default to simple suspend
Date: Sat, 23 Apr 2022 07:49:38 +0200 [thread overview]
Message-ID: <20220423054938.GA17945@lst.de> (raw)
In-Reply-To: <20220411135850.GA42637@thinkpad>
On Mon, Apr 11, 2022 at 07:28:50PM +0530, Manivannan Sadhasivam wrote:
> PCI core only accepts the quirks for the host devices that could be passed onto
> the PCI device drivers like this one. In this case, this is not a quirk but
> actually an aggressive power saving feature (atleast on the Qcom platforms).
> Moreover, adding a flag to the PCI bus will make it applicable to all the
> child devices of the RC/bridge and that would be wrong.
As you correctly state it is not a device quirk. It describes the
power management applied by the platform. So we do need to communicate
it through the core PM and/or PCI code. Please work with the relevant
maintainers.
> In our case, the same power saving feature is not applicable to all PCI devices
> like WLAN for an example.
This doesn't make sense. Your plaform can't know what device is connected
to a given root port / slot. So you might have different policies per
slot, but that has nothing to do with the Linux drivers for given devices.
prev parent reply other threads:[~2022-04-23 5:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 16:50 [PATCH] nvme/pci: default to simple suspend Keith Busch
2022-02-01 17:49 ` Vidya Sagar
2022-02-02 7:55 ` Christoph Hellwig
2022-02-02 16:03 ` Keith Busch
2022-02-04 7:10 ` Christoph Hellwig
2022-02-07 16:06 ` Keith Busch
2022-02-08 14:37 ` Christoph Hellwig
2022-02-08 17:14 ` Keith Busch
2022-02-09 7:48 ` Christoph Hellwig
2022-04-11 13:58 ` Manivannan Sadhasivam
2022-04-23 5:49 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220423054938.GA17945@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=rafael.j.wysocki@intel.com \
--cc=sagi@grimberg.me \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.