All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [PATCH] iio: adc: fix for_each_child.cocci warnings
Date: Wed, 09 Feb 2022 21:13:10 +0800	[thread overview]
Message-ID: <20220209131310.GA64935@d9df6f5d589d> (raw)
In-Reply-To: <202202092111.JiywQULH-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1821 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Rajnikant Bhojani <rajnikant.bhojani@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Hyun Kwon <hyun.kwon@xilinx.com>
CC: Shubhrajyoti Datta <shubhraj@xilinx.com>
CC: "Jean-Francois Dagenais" <jeff.dagenais@gmail.com>
CC: Olivier Dugas <dugaso@sonatest.com>
CC: Manish Narani <mnarani@xilinx.com>
CC: Jonathan Cameron <jic23@kernel.org>
CC: "Lars-Peter Clausen" <lars@metafoo.de>
CC: linux-iio(a)vger.kernel.org
CC: linux-arm-kernel(a)lists.infradead.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/iio/adc/xilinx-ams.c:917:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 923.


Semantic patch information:
 False positives can be due to function calls within the for_each
 loop that may encapsulate an of_node_put.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

CC: Rajnikant Bhojani <rajnikant.bhojani@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head:   423a108a01e05e84b59a4c4885c16bf3cd8c90c7
commit: d073b83d3f8f3ba83c59f7502371b1cf9eb35e92 [541/907] iio: adc: Add Xilinx AMS driver
:::::: branch date: 3 hours ago
:::::: commit date: 8 days ago

Please take the patch only if it's a positive warning. Thanks!

 xilinx-ams.c |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/iio/adc/xilinx-ams.c
+++ b/drivers/iio/adc/xilinx-ams.c
@@ -920,6 +920,7 @@ static int ams_parse_dt(struct iio_dev *
 					      ams_channels + num_channels);
 			if (ret < 0) {
 				kfree(ams_channels);
+				of_node_put(child_node);
 				return ret;
 			}
 

  reply	other threads:[~2022-02-09 13:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09 13:16 [xilinx-xlnx:xlnx_rebase_v5.15 541/907] drivers/iio/adc/xilinx-ams.c:917:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 923 kernel test robot
2022-02-09 13:13 ` kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-02-12 12:00 [xilinx-xlnx:xlnx_rebase_v5.15 541/923] " kernel test robot
2022-02-12 11:53 ` [PATCH] iio: adc: fix for_each_child.cocci warnings kernel test robot
2022-02-14 12:34 [xilinx-xlnx:xlnx_rebase_v5.15 541/923] drivers/iio/adc/xilinx-ams.c:917:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 923 kernel test robot
2022-02-14 12:34 ` [PATCH] iio: adc: fix for_each_child.cocci warnings kernel test robot
2022-02-15 17:52 [xilinx-xlnx:xlnx_rebase_v5.15_LTS 541/924] drivers/iio/adc/xilinx-ams.c:917:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 923 kernel test robot
2022-02-15 17:44 ` [PATCH] iio: adc: fix for_each_child.cocci warnings kernel test robot
2022-03-26  0:47 [xilinx-xlnx:xlnx_rebase_v5.15_LTS 541/1029] drivers/iio/adc/xilinx-ams.c:917:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 923 kernel test robot
2022-03-26  0:39 ` [PATCH] iio: adc: fix for_each_child.cocci warnings kernel test robot
2022-03-26  8:28 Julia Lawall
2022-03-26  8:28 ` Julia Lawall
2022-03-26  8:28 ` Julia Lawall
2022-03-27 13:38 ` Jonathan Cameron
2022-03-27 13:38   ` Jonathan Cameron
2022-03-27 13:38   ` Jonathan Cameron
2022-03-27 19:14 ` Andy Shevchenko
2022-03-27 19:14   ` Andy Shevchenko
2022-03-27 19:14   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220209131310.GA64935@d9df6f5d589d \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.