From: Christoph Hellwig <hch@lst.de>
To: Jinpu Wang <jinpu.wang@ionos.com>
Cc: axboe@kernel.dk, manoj@linux.ibm.com, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, philipp.reisner@linbit.com,
linux-block@vger.kernel.org, dm-devel@redhat.com,
target-devel@vger.kernel.org, haris.iqbal@ionos.com,
ukrishn@linux.ibm.com, lars.ellenberg@linbit.com,
drbd-dev@lists.linbit.com, Christoph Hellwig <hch@lst.de>,
mrochs@linux.ibm.com
Subject: Re: [dm-devel] [PATCH 3/7] rnbd: drop WRITE_SAME support
Date: Wed, 9 Feb 2022 15:04:48 +0100 [thread overview]
Message-ID: <20220209140448.GA20765@lst.de> (raw)
In-Reply-To: <CAMGffE=GMYNsw+mDt1h-BDh3JXkdrP9v2AUF7z0xE7jkumM+RQ@mail.gmail.com>
On Wed, Feb 09, 2022 at 11:16:13AM +0100, Jinpu Wang wrote:
> Hi Christoph,
>
>
> On Wed, Feb 9, 2022 at 9:28 AM Christoph Hellwig <hch@lst.de> wrote:
> >
> > REQ_OP_WRITE_SAME was only ever submitted by the legacy Linux zeroing
> > code, which has switched to use REQ_OP_WRITE_ZEROES long before rnbd was
> > even merged.
>
> Do you think if it makes sense to instead of removing
> REQ_OP_WRITE_SAME, simply convert it to REQ_OP_WRITE_ZEROES?
Well, they have different semantics, so you can't just "convert" it.
But it might make sense to add REQ_OP_WRITE_ZEROES.
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jinpu Wang <jinpu.wang@ionos.com>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, martin.petersen@oracle.com,
philipp.reisner@linbit.com, lars.ellenberg@linbit.com,
target-devel@vger.kernel.org, haris.iqbal@ionos.com,
manoj@linux.ibm.com, mrochs@linux.ibm.com, ukrishn@linux.ibm.com,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
drbd-dev@lists.linbit.com, dm-devel@redhat.com
Subject: Re: [PATCH 3/7] rnbd: drop WRITE_SAME support
Date: Wed, 9 Feb 2022 15:04:48 +0100 [thread overview]
Message-ID: <20220209140448.GA20765@lst.de> (raw)
In-Reply-To: <CAMGffE=GMYNsw+mDt1h-BDh3JXkdrP9v2AUF7z0xE7jkumM+RQ@mail.gmail.com>
On Wed, Feb 09, 2022 at 11:16:13AM +0100, Jinpu Wang wrote:
> Hi Christoph,
>
>
> On Wed, Feb 9, 2022 at 9:28 AM Christoph Hellwig <hch@lst.de> wrote:
> >
> > REQ_OP_WRITE_SAME was only ever submitted by the legacy Linux zeroing
> > code, which has switched to use REQ_OP_WRITE_ZEROES long before rnbd was
> > even merged.
>
> Do you think if it makes sense to instead of removing
> REQ_OP_WRITE_SAME, simply convert it to REQ_OP_WRITE_ZEROES?
Well, they have different semantics, so you can't just "convert" it.
But it might make sense to add REQ_OP_WRITE_ZEROES.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jinpu Wang <jinpu.wang@ionos.com>
Cc: axboe@kernel.dk, manoj@linux.ibm.com, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, philipp.reisner@linbit.com,
linux-block@vger.kernel.org, dm-devel@redhat.com,
target-devel@vger.kernel.org, haris.iqbal@ionos.com,
ukrishn@linux.ibm.com, lars.ellenberg@linbit.com,
drbd-dev@lists.linbit.com, Christoph Hellwig <hch@lst.de>,
mrochs@linux.ibm.com
Subject: Re: [Drbd-dev] [PATCH 3/7] rnbd: drop WRITE_SAME support
Date: Wed, 9 Feb 2022 15:04:48 +0100 [thread overview]
Message-ID: <20220209140448.GA20765@lst.de> (raw)
In-Reply-To: <CAMGffE=GMYNsw+mDt1h-BDh3JXkdrP9v2AUF7z0xE7jkumM+RQ@mail.gmail.com>
On Wed, Feb 09, 2022 at 11:16:13AM +0100, Jinpu Wang wrote:
> Hi Christoph,
>
>
> On Wed, Feb 9, 2022 at 9:28 AM Christoph Hellwig <hch@lst.de> wrote:
> >
> > REQ_OP_WRITE_SAME was only ever submitted by the legacy Linux zeroing
> > code, which has switched to use REQ_OP_WRITE_ZEROES long before rnbd was
> > even merged.
>
> Do you think if it makes sense to instead of removing
> REQ_OP_WRITE_SAME, simply convert it to REQ_OP_WRITE_ZEROES?
Well, they have different semantics, so you can't just "convert" it.
But it might make sense to add REQ_OP_WRITE_ZEROES.
next prev parent reply other threads:[~2022-02-09 14:07 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 8:28 [dm-devel] remove REQ_OP_WRITE_SAME v2 Christoph Hellwig
2022-02-09 8:28 ` [Drbd-dev] " Christoph Hellwig
2022-02-09 8:28 ` Christoph Hellwig
2022-02-09 8:28 ` [dm-devel] [PATCH 1/7] cxlflash: query write_zeroes limit for zeroing Christoph Hellwig
2022-02-09 8:28 ` [Drbd-dev] " Christoph Hellwig
2022-02-09 8:28 ` Christoph Hellwig
2022-02-09 8:43 ` [dm-devel] " Chaitanya Kulkarni
2022-02-09 8:43 ` [Drbd-dev] " Chaitanya Kulkarni
2022-02-09 8:43 ` Chaitanya Kulkarni
2022-02-09 8:28 ` [dm-devel] [PATCH 2/7] drbd: drop REQ_OP_WRITE_SAME support Christoph Hellwig
2022-02-09 8:28 ` [Drbd-dev] " Christoph Hellwig
2022-02-09 8:28 ` Christoph Hellwig
2022-02-09 8:28 ` [dm-devel] [PATCH 3/7] rnbd: drop WRITE_SAME support Christoph Hellwig
2022-02-09 8:28 ` [Drbd-dev] " Christoph Hellwig
2022-02-09 8:28 ` Christoph Hellwig
2022-02-09 8:44 ` [dm-devel] " Chaitanya Kulkarni
2022-02-09 8:44 ` [Drbd-dev] " Chaitanya Kulkarni
2022-02-09 8:44 ` Chaitanya Kulkarni
2022-02-09 9:05 ` [dm-devel] " Guoqing Jiang
2022-02-09 9:05 ` [Drbd-dev] " Guoqing Jiang
2022-02-09 9:05 ` Guoqing Jiang
2022-02-09 9:13 ` [dm-devel] " Jinpu Wang
2022-02-09 9:13 ` [Drbd-dev] " Jinpu Wang
2022-02-09 9:13 ` Jinpu Wang
2022-02-09 9:21 ` [dm-devel] " Guoqing Jiang
2022-02-09 9:21 ` [Drbd-dev] " Guoqing Jiang
2022-02-09 9:21 ` Guoqing Jiang
2022-02-09 10:16 ` [dm-devel] " Jinpu Wang
2022-02-09 10:16 ` [Drbd-dev] " Jinpu Wang
2022-02-09 10:16 ` Jinpu Wang
2022-02-09 14:04 ` Christoph Hellwig [this message]
2022-02-09 14:04 ` [Drbd-dev] " Christoph Hellwig
2022-02-09 14:04 ` Christoph Hellwig
2022-02-09 14:08 ` [dm-devel] " Jinpu Wang
2022-02-09 14:08 ` [Drbd-dev] " Jinpu Wang
2022-02-09 14:08 ` Jinpu Wang
2022-02-09 8:28 ` [dm-devel] [PATCH 4/7] sd: remove write same support Christoph Hellwig
2022-02-09 8:28 ` [Drbd-dev] " Christoph Hellwig
2022-02-09 8:28 ` Christoph Hellwig
2022-02-09 8:45 ` [dm-devel] " Chaitanya Kulkarni
2022-02-09 8:45 ` [Drbd-dev] " Chaitanya Kulkarni
2022-02-09 8:45 ` Chaitanya Kulkarni
2022-02-09 8:28 ` [dm-devel] [PATCH 5/7] md: drop WRITE_SAME support Christoph Hellwig
2022-02-09 8:28 ` [Drbd-dev] " Christoph Hellwig
2022-02-09 8:28 ` Christoph Hellwig
2022-02-09 8:28 ` [dm-devel] [PATCH 6/7] dm: remove write same support Christoph Hellwig
2022-02-09 8:28 ` [Drbd-dev] " Christoph Hellwig
2022-02-09 8:28 ` Christoph Hellwig
2022-02-16 18:45 ` [dm-devel] " Mike Snitzer
2022-02-16 18:45 ` [Drbd-dev] " Mike Snitzer
2022-02-16 18:45 ` Mike Snitzer
2022-02-09 8:28 ` [dm-devel] [PATCH 7/7] block: remove REQ_OP_WRITE_SAME support Christoph Hellwig
2022-02-09 8:28 ` [Drbd-dev] " Christoph Hellwig
2022-02-09 8:28 ` Christoph Hellwig
2022-02-09 8:46 ` [dm-devel] " Chaitanya Kulkarni
2022-02-09 8:46 ` [Drbd-dev] " Chaitanya Kulkarni
2022-02-09 8:46 ` Chaitanya Kulkarni
2022-02-20 1:44 ` [dm-devel] " Martin K. Petersen
2022-02-20 1:44 ` [Drbd-dev] " Martin K. Petersen
2022-02-20 1:44 ` Martin K. Petersen
2022-02-22 7:38 ` [dm-devel] " Christoph Hellwig
2022-02-22 7:38 ` [Drbd-dev] " Christoph Hellwig
2022-02-22 7:38 ` Christoph Hellwig
2022-02-23 1:58 ` [dm-devel] " Martin K. Petersen
2022-02-23 1:58 ` [Drbd-dev] " Martin K. Petersen
2022-02-23 1:58 ` Martin K. Petersen
2022-02-09 8:47 ` [dm-devel] remove REQ_OP_WRITE_SAME v2 Chaitanya Kulkarni
2022-02-09 8:47 ` [Drbd-dev] " Chaitanya Kulkarni
2022-02-09 8:47 ` Chaitanya Kulkarni
2022-02-09 18:00 ` [dm-devel] " Martin K. Petersen
2022-02-09 18:00 ` [Drbd-dev] " Martin K. Petersen
2022-02-09 18:00 ` Martin K. Petersen
2022-02-10 5:51 ` [dm-devel] " Christoph Hellwig
2022-02-10 5:51 ` [Drbd-dev] " Christoph Hellwig
2022-02-10 5:51 ` Christoph Hellwig
2022-02-17 3:07 ` [dm-devel] " Jens Axboe
2022-02-17 3:07 ` [Drbd-dev] " Jens Axboe
2022-02-17 3:07 ` Jens Axboe
2022-02-17 6:43 ` [dm-devel] " Christoph Hellwig
2022-02-17 6:43 ` [Drbd-dev] " Christoph Hellwig
2022-02-17 6:43 ` Christoph Hellwig
2022-02-18 4:27 ` [dm-devel] " Martin K. Petersen
2022-02-18 4:27 ` [Drbd-dev] " Martin K. Petersen
2022-02-18 4:27 ` Martin K. Petersen
2022-02-19 23:33 ` [dm-devel] " Martin K. Petersen
2022-02-19 23:33 ` [Drbd-dev] " Martin K. Petersen
2022-02-19 23:33 ` Martin K. Petersen
2022-02-28 3:43 ` [dm-devel] " Martin K. Petersen
2022-02-28 3:43 ` [Drbd-dev] " Martin K. Petersen
2022-02-28 3:43 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209140448.GA20765@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=haris.iqbal@ionos.com \
--cc=jinpu.wang@ionos.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manoj@linux.ibm.com \
--cc=martin.petersen@oracle.com \
--cc=mrochs@linux.ibm.com \
--cc=philipp.reisner@linbit.com \
--cc=target-devel@vger.kernel.org \
--cc=ukrishn@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.