All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: zhenwei pi <pizhenwei@bytedance.com>,
	"Gonglei (Arei)" <arei.gonglei@huawei.com>,
	virtualization <virtualization@lists.linux-foundation.org>,
	linux-crypto@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	helei.sig11@bytedance.com
Subject: Re: PING: [PATCH 0/3] Introduce akcipher service for virtio-crypto
Date: Thu, 10 Feb 2022 02:23:42 -0500	[thread overview]
Message-ID: <20220210022221-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CACGkMEsxnFU5TnPGxU3TjFG6MWZhtCyu93f2qzeAq08ce6VJ_g@mail.gmail.com>

On Thu, Feb 10, 2022 at 03:17:38PM +0800, Jason Wang wrote:
> On Thu, Feb 10, 2022 at 2:58 PM zhenwei pi <pizhenwei@bytedance.com> wrote:
> >
> > PING!
> 
> I think it would be helpful to get ack/reviewing from crypto gurus.

For sure, but with the robot warning some people might just assume
there's a problem and wait for the next version to review.
Just post v2, don't forget the changelog.

> Maybe Herbert?
> 
> Thanks
> 
> >
> > PS: Please ignore the warning from kernel test robot, I'll fix it in
> > next version.
> >
> > On 1/21/22 10:24 AM, zhenwei pi wrote:
> > > Introduce akcipher service, implement RSA algorithm, and a minor fix.
> > >
> > > zhenwei pi (3):
> > >    virtio_crypto: Introduce VIRTIO_CRYPTO_NOSPC
> > >    virtio-crypto: introduce akcipher service
> > >    virtio-crypto: implement RSA algorithm
> > >
> > >   drivers/crypto/virtio/Makefile                |   1 +
> > >   .../virtio/virtio_crypto_akcipher_algo.c      | 584 ++++++++++++++++++
> > >   drivers/crypto/virtio/virtio_crypto_common.h  |   3 +
> > >   drivers/crypto/virtio/virtio_crypto_core.c    |   6 +-
> > >   drivers/crypto/virtio/virtio_crypto_mgr.c     |  11 +
> > >   include/uapi/linux/virtio_crypto.h            |  98 ++-
> > >   6 files changed, 693 insertions(+), 10 deletions(-)
> > >   create mode 100644 drivers/crypto/virtio/virtio_crypto_akcipher_algo.c
> > >
> >
> > --
> > zhenwei pi
> >


WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: helei.sig11@bytedance.com,
	linux-kernel <linux-kernel@vger.kernel.org>,
	zhenwei pi <pizhenwei@bytedance.com>,
	virtualization <virtualization@lists.linux-foundation.org>,
	linux-crypto@vger.kernel.org
Subject: Re: PING: [PATCH 0/3] Introduce akcipher service for virtio-crypto
Date: Thu, 10 Feb 2022 02:23:42 -0500	[thread overview]
Message-ID: <20220210022221-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CACGkMEsxnFU5TnPGxU3TjFG6MWZhtCyu93f2qzeAq08ce6VJ_g@mail.gmail.com>

On Thu, Feb 10, 2022 at 03:17:38PM +0800, Jason Wang wrote:
> On Thu, Feb 10, 2022 at 2:58 PM zhenwei pi <pizhenwei@bytedance.com> wrote:
> >
> > PING!
> 
> I think it would be helpful to get ack/reviewing from crypto gurus.

For sure, but with the robot warning some people might just assume
there's a problem and wait for the next version to review.
Just post v2, don't forget the changelog.

> Maybe Herbert?
> 
> Thanks
> 
> >
> > PS: Please ignore the warning from kernel test robot, I'll fix it in
> > next version.
> >
> > On 1/21/22 10:24 AM, zhenwei pi wrote:
> > > Introduce akcipher service, implement RSA algorithm, and a minor fix.
> > >
> > > zhenwei pi (3):
> > >    virtio_crypto: Introduce VIRTIO_CRYPTO_NOSPC
> > >    virtio-crypto: introduce akcipher service
> > >    virtio-crypto: implement RSA algorithm
> > >
> > >   drivers/crypto/virtio/Makefile                |   1 +
> > >   .../virtio/virtio_crypto_akcipher_algo.c      | 584 ++++++++++++++++++
> > >   drivers/crypto/virtio/virtio_crypto_common.h  |   3 +
> > >   drivers/crypto/virtio/virtio_crypto_core.c    |   6 +-
> > >   drivers/crypto/virtio/virtio_crypto_mgr.c     |  11 +
> > >   include/uapi/linux/virtio_crypto.h            |  98 ++-
> > >   6 files changed, 693 insertions(+), 10 deletions(-)
> > >   create mode 100644 drivers/crypto/virtio/virtio_crypto_akcipher_algo.c
> > >
> >
> > --
> > zhenwei pi
> >

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2022-02-10  7:23 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-21  2:24 [PATCH 0/3] Introduce akcipher service for virtio-crypto zhenwei pi
2022-01-21  2:24 ` zhenwei pi
2022-01-21  2:24 ` [PATCH 1/3] virtio_crypto: Introduce VIRTIO_CRYPTO_NOSPC zhenwei pi
2022-01-21  2:24   ` zhenwei pi
2022-02-10  7:22   ` Gonglei (Arei)
2022-02-10  7:22     ` Gonglei (Arei) via Virtualization
2022-01-21  2:24 ` [PATCH 2/3] virtio-crypto: introduce akcipher service zhenwei pi
2022-01-21  2:24   ` zhenwei pi
2022-02-10  7:51   ` Gonglei (Arei)
2022-02-10  7:51     ` Gonglei (Arei) via Virtualization
2022-02-10  8:18     ` zhenwei pi
2022-02-10  8:18       ` zhenwei pi
2022-02-10  9:21       ` Gonglei (Arei)
2022-02-10  9:21         ` Gonglei (Arei) via Virtualization
2022-01-21  2:24 ` [PATCH 3/3] virtio-crypto: implement RSA algorithm zhenwei pi
2022-01-21  2:24   ` zhenwei pi
2022-01-21  6:36   ` kernel test robot
2022-01-21  6:36     ` kernel test robot
2022-01-21  6:36     ` kernel test robot
2022-01-21  8:29   ` [RFC PATCH] virtio-crypto: virtio_crypto_rsa_do_req() can be static kernel test robot
2022-01-21  8:29     ` kernel test robot
2022-01-21  8:29     ` kernel test robot
2022-01-21  8:39   ` [PATCH 3/3] virtio-crypto: implement RSA algorithm kernel test robot
2022-01-21  8:39     ` kernel test robot
2022-01-21  8:39     ` kernel test robot
2022-01-21 21:43   ` kernel test robot
2022-01-21 21:43     ` kernel test robot
2022-01-21 21:43     ` kernel test robot
2022-01-22  0:19   ` kernel test robot
2022-01-22  0:19     ` kernel test robot
2022-01-22  0:19     ` kernel test robot
2022-02-10  6:55 ` PING: [PATCH 0/3] Introduce akcipher service for virtio-crypto zhenwei pi
2022-02-10  6:55   ` zhenwei pi
2022-02-10  7:17   ` Jason Wang
2022-02-10  7:17     ` Jason Wang
2022-02-10  7:23     ` Michael S. Tsirkin [this message]
2022-02-10  7:23       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220210022221-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=arei.gonglei@huawei.com \
    --cc=helei.sig11@bytedance.com \
    --cc=jasowang@redhat.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pizhenwei@bytedance.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.