All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <frederic@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, ardb@kernel.org,
	bp@alien8.de, catalin.marinas@arm.com,
	dave.hansen@linux.intel.com, james.morse@arm.com,
	joey.gouly@arm.com, juri.lelli@redhat.com,
	linux-kernel@vger.kernel.org, luto@kernel.org, mingo@redhat.com,
	peterz@infradead.org, tglx@linutronix.de,
	valentin.schneider@arm.com, will@kernel.org
Subject: Re: [PATCH v3 5/7] sched/preempt: add PREEMPT_DYNAMIC using static keys
Date: Thu, 10 Feb 2022 16:59:29 +0100	[thread overview]
Message-ID: <20220210155929.GB567552@lothringen> (raw)
In-Reply-To: <YgTn7pnZ/hxmHBha@FVFF77S0Q05N>

On Thu, Feb 10, 2022 at 10:27:39AM +0000, Mark Rutland wrote:
> On Wed, Feb 09, 2022 at 06:48:01PM +0100, Frederic Weisbecker wrote:
> > On Wed, Feb 09, 2022 at 03:35:33PM +0000, Mark Rutland wrote:
> > > +config HAVE_PREEMPT_DYNAMIC_KEY
> > > +	bool
> > > +	depends on JUMP_LABEL
> > 
> > This should probably be:
> > 
> >      depends on HAVE_ARCH_JUMP_LABEL && CC_HAS_ASM_GOTO
> >      select JUMP_LABEL
> > 
> > Otherwise you may run into trouble if CONFIG_JUMP_LABEL is initially n.
> 
> I'll make that:
> 
>  config HAVE_PREEMPT_DYNAMIC_KEY
>         bool
>         depends on HAVE_ARCH_JUMP_LABEL && CC_HAS_ASM_GOTO
>         ...
> 
> ... and 
> 
>  config PREEMPT_DYNAMIC
>         bool "Preemption behaviour defined on boot"
>         depends on HAVE_PREEMPT_DYNAMIC && !PREEMPT_RT
>         select JUMP_LABEL if HAVE_PREEMPT_DYNAMIC_KEY
>         ...
> 
> So that we don't force JUMP_LABEL on even when people aren't using it.

Much better!

Thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Frederic Weisbecker <frederic@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, ardb@kernel.org,
	bp@alien8.de, catalin.marinas@arm.com,
	dave.hansen@linux.intel.com, james.morse@arm.com,
	joey.gouly@arm.com, juri.lelli@redhat.com,
	linux-kernel@vger.kernel.org, luto@kernel.org, mingo@redhat.com,
	peterz@infradead.org, tglx@linutronix.de,
	valentin.schneider@arm.com, will@kernel.org
Subject: Re: [PATCH v3 5/7] sched/preempt: add PREEMPT_DYNAMIC using static keys
Date: Thu, 10 Feb 2022 16:59:29 +0100	[thread overview]
Message-ID: <20220210155929.GB567552@lothringen> (raw)
In-Reply-To: <YgTn7pnZ/hxmHBha@FVFF77S0Q05N>

On Thu, Feb 10, 2022 at 10:27:39AM +0000, Mark Rutland wrote:
> On Wed, Feb 09, 2022 at 06:48:01PM +0100, Frederic Weisbecker wrote:
> > On Wed, Feb 09, 2022 at 03:35:33PM +0000, Mark Rutland wrote:
> > > +config HAVE_PREEMPT_DYNAMIC_KEY
> > > +	bool
> > > +	depends on JUMP_LABEL
> > 
> > This should probably be:
> > 
> >      depends on HAVE_ARCH_JUMP_LABEL && CC_HAS_ASM_GOTO
> >      select JUMP_LABEL
> > 
> > Otherwise you may run into trouble if CONFIG_JUMP_LABEL is initially n.
> 
> I'll make that:
> 
>  config HAVE_PREEMPT_DYNAMIC_KEY
>         bool
>         depends on HAVE_ARCH_JUMP_LABEL && CC_HAS_ASM_GOTO
>         ...
> 
> ... and 
> 
>  config PREEMPT_DYNAMIC
>         bool "Preemption behaviour defined on boot"
>         depends on HAVE_PREEMPT_DYNAMIC && !PREEMPT_RT
>         select JUMP_LABEL if HAVE_PREEMPT_DYNAMIC_KEY
>         ...
> 
> So that we don't force JUMP_LABEL on even when people aren't using it.

Much better!

Thanks!

  reply	other threads:[~2022-02-10 16:00 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09 15:35 [PATCH v3 0/7] arm64 / sched/preempt: support PREEMPT_DYNAMIC with static keys Mark Rutland
2022-02-09 15:35 ` Mark Rutland
2022-02-09 15:35 ` [PATCH v3 1/7] sched/preempt: move PREEMPT_DYNAMIC logic later Mark Rutland
2022-02-09 15:35   ` Mark Rutland
2022-02-09 15:35 ` [PATCH v3 2/7] sched/preempt: refactor sched_dynamic_update() Mark Rutland
2022-02-09 15:35   ` Mark Rutland
2022-02-09 15:35 ` [PATCH v3 3/7] sched/preempt: simplify irqentry_exit_cond_resched() callers Mark Rutland
2022-02-09 15:35   ` Mark Rutland
2022-02-09 15:35 ` [PATCH v3 4/7] sched/preempt: decouple HAVE_PREEMPT_DYNAMIC from GENERIC_ENTRY Mark Rutland
2022-02-09 15:35   ` Mark Rutland
2022-02-09 15:35 ` [PATCH v3 5/7] sched/preempt: add PREEMPT_DYNAMIC using static keys Mark Rutland
2022-02-09 15:35   ` Mark Rutland
2022-02-09 17:48   ` Frederic Weisbecker
2022-02-09 17:48     ` Frederic Weisbecker
2022-02-10 10:27     ` Mark Rutland
2022-02-10 10:27       ` Mark Rutland
2022-02-10 15:59       ` Frederic Weisbecker [this message]
2022-02-10 15:59         ` Frederic Weisbecker
2022-02-09 15:35 ` [PATCH v3 6/7] arm64: entry: centralize premeption decision Mark Rutland
2022-02-09 15:35   ` Mark Rutland
2022-02-09 18:10   ` Catalin Marinas
2022-02-09 18:10     ` Catalin Marinas
2022-02-10  9:19     ` Mark Rutland
2022-02-10  9:19       ` Mark Rutland
2022-02-09 15:35 ` [PATCH v3 7/7] arm64: support PREEMPT_DYNAMIC Mark Rutland
2022-02-09 15:35   ` Mark Rutland
2022-02-09 18:13   ` Catalin Marinas
2022-02-09 18:13     ` Catalin Marinas
2022-02-09 19:57   ` Frederic Weisbecker
2022-02-09 19:57     ` Frederic Weisbecker
2022-02-10  9:38     ` Mark Rutland
2022-02-10  9:38       ` Mark Rutland
2022-02-10 12:00       ` Mark Rutland
2022-02-10 12:00         ` Mark Rutland
2022-02-10 15:58         ` Frederic Weisbecker
2022-02-10 15:58           ` Frederic Weisbecker
2022-02-09 19:58 ` [PATCH v3 0/7] arm64 / sched/preempt: support PREEMPT_DYNAMIC with static keys Frederic Weisbecker
2022-02-09 19:58   ` Frederic Weisbecker
2022-02-10  9:29 ` Ard Biesheuvel
2022-02-10  9:29   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220210155929.GB567552@lothringen \
    --to=frederic@kernel.org \
    --cc=ardb@kernel.org \
    --cc=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=james.morse@arm.com \
    --cc=joey.gouly@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=valentin.schneider@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.