All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
	Andreas Noever <andreas.noever@gmail.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
	"open list:THUNDERBOLT DRIVER" <linux-usb@vger.kernel.org>,
	"open list:RADEON and AMDGPU DRM DRIVERS"
	<amd-gfx@lists.freedesktop.org>,
	"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
	"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS"
	<nouveau@lists.freedesktop.org>,
	"open list:X86 PLATFORM DRIVERS"
	<platform-driver-x86@vger.kernel.org>
Cc: Michael Jamet <michael.jamet@intel.com>,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	Alexander.Deucher@amd.com, Lukas Wunner <lukas@wunner.de>,
	Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH v2 9/9] PCI: drop `pci_is_thunderbolt_attached`
Date: Thu, 10 Feb 2022 16:43:29 -0600	[thread overview]
Message-ID: <20220210224329.2793-10-mario.limonciello@amd.com> (raw)
In-Reply-To: <20220210224329.2793-1-mario.limonciello@amd.com>

Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.

As all drivers now look at the removable attribute, drop this function.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 include/linux/pci.h | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/include/linux/pci.h b/include/linux/pci.h
index d9719eb14654..089e7e36a0d9 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -2434,28 +2434,6 @@ static inline bool pci_ari_enabled(struct pci_bus *bus)
 	return bus->self && bus->self->ari_enabled;
 }
 
-/**
- * pci_is_thunderbolt_attached - whether device is on a Thunderbolt daisy chain
- * @pdev: PCI device to check
- *
- * Walk upwards from @pdev and check for each encountered bridge if it's part
- * of a Thunderbolt controller.  Reaching the host bridge means @pdev is not
- * Thunderbolt-attached.  (But rather soldered to the mainboard usually.)
- */
-static inline bool pci_is_thunderbolt_attached(struct pci_dev *pdev)
-{
-	struct pci_dev *parent = pdev;
-
-	if (dev_is_removable(&pdev->dev))
-		return true;
-
-	while ((parent = pci_upstream_bridge(parent)))
-		if (dev_is_removable(&parent->dev))
-			return true;
-
-	return false;
-}
-
 #if defined(CONFIG_PCIEPORTBUS) || defined(CONFIG_EEH)
 void pci_uevent_ers(struct pci_dev *pdev, enum  pci_ers_result err_type);
 #endif
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Mario Limonciello <mario.limonciello@amd.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
	Andreas Noever <andreas.noever@gmail.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
	"open list:THUNDERBOLT DRIVER" <linux-usb@vger.kernel.org>,
	"open list:RADEON and AMDGPU DRM DRIVERS" 
	<amd-gfx@lists.freedesktop.org>,
	"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
	"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" 
	<nouveau@lists.freedesktop.org>,
	"open list:X86 PLATFORM DRIVERS" 
	<platform-driver-x86@vger.kernel.org>
Cc: Michael Jamet <michael.jamet@intel.com>,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	Lukas Wunner <lukas@wunner.de>, <Alexander.Deucher@amd.com>,
	Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH v2 9/9] PCI: drop `pci_is_thunderbolt_attached`
Date: Thu, 10 Feb 2022 16:43:29 -0600	[thread overview]
Message-ID: <20220210224329.2793-10-mario.limonciello@amd.com> (raw)
In-Reply-To: <20220210224329.2793-1-mario.limonciello@amd.com>

Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.

As all drivers now look at the removable attribute, drop this function.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 include/linux/pci.h | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/include/linux/pci.h b/include/linux/pci.h
index d9719eb14654..089e7e36a0d9 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -2434,28 +2434,6 @@ static inline bool pci_ari_enabled(struct pci_bus *bus)
 	return bus->self && bus->self->ari_enabled;
 }
 
-/**
- * pci_is_thunderbolt_attached - whether device is on a Thunderbolt daisy chain
- * @pdev: PCI device to check
- *
- * Walk upwards from @pdev and check for each encountered bridge if it's part
- * of a Thunderbolt controller.  Reaching the host bridge means @pdev is not
- * Thunderbolt-attached.  (But rather soldered to the mainboard usually.)
- */
-static inline bool pci_is_thunderbolt_attached(struct pci_dev *pdev)
-{
-	struct pci_dev *parent = pdev;
-
-	if (dev_is_removable(&pdev->dev))
-		return true;
-
-	while ((parent = pci_upstream_bridge(parent)))
-		if (dev_is_removable(&parent->dev))
-			return true;
-
-	return false;
-}
-
 #if defined(CONFIG_PCIEPORTBUS) || defined(CONFIG_EEH)
 void pci_uevent_ers(struct pci_dev *pdev, enum  pci_ers_result err_type);
 #endif
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Mario Limonciello <mario.limonciello@amd.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
	Andreas Noever <andreas.noever@gmail.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
	"open list:THUNDERBOLT DRIVER" <linux-usb@vger.kernel.org>,
	"open list:RADEON and AMDGPU DRM DRIVERS"
	<amd-gfx@lists.freedesktop.org>,
	"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
	"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS"
	<nouveau@lists.freedesktop.org>,
	"open list:X86 PLATFORM DRIVERS"
	<platform-driver-x86@vger.kernel.org>
Cc: Michael Jamet <michael.jamet@intel.com>,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	Alexander.Deucher@amd.com,
	Mario Limonciello <mario.limonciello@amd.com>
Subject: [Nouveau] [PATCH v2 9/9] PCI: drop `pci_is_thunderbolt_attached`
Date: Thu, 10 Feb 2022 16:43:29 -0600	[thread overview]
Message-ID: <20220210224329.2793-10-mario.limonciello@amd.com> (raw)
In-Reply-To: <20220210224329.2793-1-mario.limonciello@amd.com>

Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.

As all drivers now look at the removable attribute, drop this function.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 include/linux/pci.h | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/include/linux/pci.h b/include/linux/pci.h
index d9719eb14654..089e7e36a0d9 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -2434,28 +2434,6 @@ static inline bool pci_ari_enabled(struct pci_bus *bus)
 	return bus->self && bus->self->ari_enabled;
 }
 
-/**
- * pci_is_thunderbolt_attached - whether device is on a Thunderbolt daisy chain
- * @pdev: PCI device to check
- *
- * Walk upwards from @pdev and check for each encountered bridge if it's part
- * of a Thunderbolt controller.  Reaching the host bridge means @pdev is not
- * Thunderbolt-attached.  (But rather soldered to the mainboard usually.)
- */
-static inline bool pci_is_thunderbolt_attached(struct pci_dev *pdev)
-{
-	struct pci_dev *parent = pdev;
-
-	if (dev_is_removable(&pdev->dev))
-		return true;
-
-	while ((parent = pci_upstream_bridge(parent)))
-		if (dev_is_removable(&parent->dev))
-			return true;
-
-	return false;
-}
-
 #if defined(CONFIG_PCIEPORTBUS) || defined(CONFIG_EEH)
 void pci_uevent_ers(struct pci_dev *pdev, enum  pci_ers_result err_type);
 #endif
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Mario Limonciello <mario.limonciello@amd.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
	Andreas Noever <andreas.noever@gmail.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
	"open list:THUNDERBOLT DRIVER" <linux-usb@vger.kernel.org>,
	"open list:RADEON and AMDGPU DRM DRIVERS"
	<amd-gfx@lists.freedesktop.org>,
	"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
	"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS"
	<nouveau@lists.freedesktop.org>,
	"open list:X86 PLATFORM DRIVERS"
	<platform-driver-x86@vger.kernel.org>
Cc: Michael Jamet <michael.jamet@intel.com>,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	Alexander.Deucher@amd.com,
	Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH v2 9/9] PCI: drop `pci_is_thunderbolt_attached`
Date: Thu, 10 Feb 2022 16:43:29 -0600	[thread overview]
Message-ID: <20220210224329.2793-10-mario.limonciello@amd.com> (raw)
In-Reply-To: <20220210224329.2793-1-mario.limonciello@amd.com>

Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.

As all drivers now look at the removable attribute, drop this function.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 include/linux/pci.h | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/include/linux/pci.h b/include/linux/pci.h
index d9719eb14654..089e7e36a0d9 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -2434,28 +2434,6 @@ static inline bool pci_ari_enabled(struct pci_bus *bus)
 	return bus->self && bus->self->ari_enabled;
 }
 
-/**
- * pci_is_thunderbolt_attached - whether device is on a Thunderbolt daisy chain
- * @pdev: PCI device to check
- *
- * Walk upwards from @pdev and check for each encountered bridge if it's part
- * of a Thunderbolt controller.  Reaching the host bridge means @pdev is not
- * Thunderbolt-attached.  (But rather soldered to the mainboard usually.)
- */
-static inline bool pci_is_thunderbolt_attached(struct pci_dev *pdev)
-{
-	struct pci_dev *parent = pdev;
-
-	if (dev_is_removable(&pdev->dev))
-		return true;
-
-	while ((parent = pci_upstream_bridge(parent)))
-		if (dev_is_removable(&parent->dev))
-			return true;
-
-	return false;
-}
-
 #if defined(CONFIG_PCIEPORTBUS) || defined(CONFIG_EEH)
 void pci_uevent_ers(struct pci_dev *pdev, enum  pci_ers_result err_type);
 #endif
-- 
2.34.1


  parent reply	other threads:[~2022-02-10 22:44 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 22:43 [PATCH v2 0/9] Overhaul is_thunderbolt Mario Limonciello
2022-02-10 22:43 ` Mario Limonciello
2022-02-10 22:43 ` [Nouveau] " Mario Limonciello
2022-02-10 22:43 ` Mario Limonciello
2022-02-10 22:43 ` [PATCH v2 1/9] thunderbolt: move definition of PCI_CLASS_SERIAL_USB_USB4 Mario Limonciello
2022-02-10 22:43   ` Mario Limonciello
2022-02-10 22:43   ` [Nouveau] " Mario Limonciello
2022-02-10 22:43   ` Mario Limonciello
2022-02-11 10:13   ` Mika Westerberg
2022-02-11 10:13     ` Mika Westerberg
2022-02-11 10:13     ` [Nouveau] " Mika Westerberg
2022-02-11 10:13     ` Mika Westerberg
2022-02-10 22:43 ` [PATCH v2 2/9] PCI: Move `is_thunderbolt` check for lack of command completed to a quirk Mario Limonciello
2022-02-10 22:43   ` Mario Limonciello
2022-02-10 22:43   ` [Nouveau] " Mario Limonciello
2022-02-10 22:43   ` Mario Limonciello
2022-02-10 22:43 ` [PATCH v2 3/9] PCI: drop `is_thunderbolt` attribute Mario Limonciello
2022-02-10 22:43   ` Mario Limonciello
2022-02-10 22:43   ` [Nouveau] " Mario Limonciello
2022-02-10 22:43   ` Mario Limonciello
2022-02-11 10:23   ` Mika Westerberg
2022-02-11 10:23     ` Mika Westerberg
2022-02-11 10:23     ` [Nouveau] " Mika Westerberg
2022-02-11 10:23     ` Mika Westerberg
2022-02-11 19:37     ` Limonciello, Mario
2022-02-11 19:37       ` Limonciello, Mario
2022-02-11 19:37       ` [Nouveau] " Limonciello, Mario
2022-02-11 19:37       ` Limonciello, Mario
2022-02-13  8:39     ` Lukas Wunner
2022-02-13  8:39       ` [Nouveau] " Lukas Wunner
2022-02-13  8:39       ` Lukas Wunner
2022-02-14  6:22       ` Mika Westerberg
2022-02-14  6:22         ` [Nouveau] " Mika Westerberg
2022-02-14  6:22         ` Mika Westerberg
2022-02-10 22:43 ` [PATCH v2 4/9] PCI: mark USB4 devices as removable Mario Limonciello
2022-02-10 22:43   ` Mario Limonciello
2022-02-10 22:43   ` [Nouveau] " Mario Limonciello
2022-02-10 22:43   ` Mario Limonciello
2022-02-11  1:28   ` Macpaul Lin
2022-02-11  1:28     ` Macpaul Lin
2022-02-11  1:28     ` [Nouveau] " Macpaul Lin
2022-02-11  1:28     ` Macpaul Lin
2022-02-11 10:35   ` Mika Westerberg
2022-02-11 10:35     ` Mika Westerberg
2022-02-11 10:35     ` [Nouveau] " Mika Westerberg
2022-02-11 10:35     ` Mika Westerberg
2022-02-11 19:36     ` Limonciello, Mario
2022-02-11 19:36       ` Limonciello, Mario
2022-02-11 19:36       ` [Nouveau] " Limonciello, Mario
2022-02-11 19:36       ` Limonciello, Mario
2022-02-10 22:43 ` [PATCH v2 5/9] drm/amd: drop the use of `pci_is_thunderbolt_attached` Mario Limonciello
2022-02-10 22:43   ` Mario Limonciello
2022-02-10 22:43   ` [Nouveau] " Mario Limonciello
2022-02-10 22:43   ` Mario Limonciello
2022-02-11  1:31   ` Macpaul Lin
2022-02-11  1:31     ` Macpaul Lin
2022-02-11  1:31     ` [Nouveau] " Macpaul Lin
2022-02-11  1:31     ` Macpaul Lin
2022-02-10 22:43 ` [PATCH v2 6/9] drm/nouveau: " Mario Limonciello
2022-02-10 22:43   ` Mario Limonciello
2022-02-10 22:43   ` [Nouveau] " Mario Limonciello
2022-02-10 22:43   ` Mario Limonciello
2022-02-10 22:43 ` [PATCH v2 7/9] drm/radeon: " Mario Limonciello
2022-02-10 22:43   ` Mario Limonciello
2022-02-10 22:43   ` [Nouveau] " Mario Limonciello
2022-02-10 22:43   ` Mario Limonciello
2022-02-10 22:43 ` [PATCH v2 8/9] platform/x86: amd-gmux: " Mario Limonciello
2022-02-10 22:43   ` Mario Limonciello
2022-02-10 22:43   ` [Nouveau] " Mario Limonciello
2022-02-10 22:43   ` Mario Limonciello
2022-02-11  8:45   ` Hans de Goede
2022-02-11  8:45     ` Hans de Goede
2022-02-11  8:45     ` [Nouveau] " Hans de Goede
2022-02-11  8:45     ` Hans de Goede
2022-02-11  9:00   ` Yehezkel Bernat
2022-02-11  9:00     ` Yehezkel Bernat
2022-02-11  9:00     ` [Nouveau] " Yehezkel Bernat
2022-02-11  9:00     ` Yehezkel Bernat
2022-02-11  9:22     ` Hans de Goede
2022-02-11  9:22       ` Hans de Goede
2022-02-11  9:22       ` [Nouveau] " Hans de Goede
2022-02-11  9:22       ` Hans de Goede
2022-02-10 22:43 ` Mario Limonciello [this message]
2022-02-10 22:43   ` [PATCH v2 9/9] PCI: drop `pci_is_thunderbolt_attached` Mario Limonciello
2022-02-10 22:43   ` [Nouveau] " Mario Limonciello
2022-02-10 22:43   ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220210224329.2793-10-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=YehezkelShB@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andreas.noever@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=michael.jamet@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.