All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/8] various imx6ul DT fixes
Date: Fri, 11 Feb 2022 11:37:43 +0800	[thread overview]
Message-ID: <20220211033743.GI4909@dragon> (raw)
In-Reply-To: <20220125135014.3041002-1-alexander.stein@ew.tq-group.com>

On Tue, Jan 25, 2022 at 02:50:06PM +0100, Alexander Stein wrote:
> This patch set fixes several, but not all, dt_binding_check warnings. Some are
> missing properties or their format, others address issues regarding to
> compatible names. I only touched those where compatibles are stated in the yaml
> bindings.
> There are several imx6ul compatible names used by imx6ul.dtsi, but which are
> not listed in the bindings. Namely:
> * "fsl,imx6ul-gpt", "fsl,imx6sx-gpt"
> * "fsl,imx6ul-tempmon", "fsl,imx6sx-tempmon"
> * "fsl,imx6ul-gpc", "fsl,imx6q-gpc"
> * "fsl,imx6ul-usdhc", "fsl,imx6sx-usdhc"
> 
> Despite GPC, the others are apperently compatible to imx6sx. I'm not sure how
> to fix the DTB check warning. Add the imx6ul compatible to bindings and drivers?

Add the compatible to bindings, I would say.

Shawn

> Or change the .dtsi to use only the imx6sx compatible.
> 
> The GPC on imx6ul apparently does only support power gating for ARM CPU, so
> this would require actually a new compatible which supports only 1 domain.
> 
> Alexander Stein (8):
>   ARM: dts: imx6ul: add missing properties for sram
>   ARM: dts: imx6ul: change operating-points to uint32-matrix
>   ARM: dts: imx6ul: fix keypad compatible
>   ARM: dts: imx6ul: fix adc node compatible
>   ARM: dts: imx6ul: remove unsupported adc property
>   ARM: dts: imx6ul: fix csi node compatible
>   ARM: dts: imx6ul: fix lcdif node compatible
>   ARM: dts: imx6ul: fix qspi node compatible
> 
>  arch/arm/boot/dts/imx6ul.dtsi | 36 +++++++++++++++++------------------
>  1 file changed, 18 insertions(+), 18 deletions(-)
> 
> -- 
> 2.25.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/8] various imx6ul DT fixes
Date: Fri, 11 Feb 2022 11:37:43 +0800	[thread overview]
Message-ID: <20220211033743.GI4909@dragon> (raw)
In-Reply-To: <20220125135014.3041002-1-alexander.stein@ew.tq-group.com>

On Tue, Jan 25, 2022 at 02:50:06PM +0100, Alexander Stein wrote:
> This patch set fixes several, but not all, dt_binding_check warnings. Some are
> missing properties or their format, others address issues regarding to
> compatible names. I only touched those where compatibles are stated in the yaml
> bindings.
> There are several imx6ul compatible names used by imx6ul.dtsi, but which are
> not listed in the bindings. Namely:
> * "fsl,imx6ul-gpt", "fsl,imx6sx-gpt"
> * "fsl,imx6ul-tempmon", "fsl,imx6sx-tempmon"
> * "fsl,imx6ul-gpc", "fsl,imx6q-gpc"
> * "fsl,imx6ul-usdhc", "fsl,imx6sx-usdhc"
> 
> Despite GPC, the others are apperently compatible to imx6sx. I'm not sure how
> to fix the DTB check warning. Add the imx6ul compatible to bindings and drivers?

Add the compatible to bindings, I would say.

Shawn

> Or change the .dtsi to use only the imx6sx compatible.
> 
> The GPC on imx6ul apparently does only support power gating for ARM CPU, so
> this would require actually a new compatible which supports only 1 domain.
> 
> Alexander Stein (8):
>   ARM: dts: imx6ul: add missing properties for sram
>   ARM: dts: imx6ul: change operating-points to uint32-matrix
>   ARM: dts: imx6ul: fix keypad compatible
>   ARM: dts: imx6ul: fix adc node compatible
>   ARM: dts: imx6ul: remove unsupported adc property
>   ARM: dts: imx6ul: fix csi node compatible
>   ARM: dts: imx6ul: fix lcdif node compatible
>   ARM: dts: imx6ul: fix qspi node compatible
> 
>  arch/arm/boot/dts/imx6ul.dtsi | 36 +++++++++++++++++------------------
>  1 file changed, 18 insertions(+), 18 deletions(-)
> 
> -- 
> 2.25.1
> 

  parent reply	other threads:[~2022-02-11  3:39 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25 13:50 [PATCH 0/8] various imx6ul DT fixes Alexander Stein
2022-01-25 13:50 ` Alexander Stein
2022-01-25 13:50 ` [PATCH 1/8] ARM: dts: imx6ul: add missing properties for sram Alexander Stein
2022-01-25 13:50   ` Alexander Stein
2022-02-11  3:42   ` Shawn Guo
2022-02-11  3:42     ` Shawn Guo
2022-02-11 14:36     ` (EXT) " Alexander Stein
2022-02-11 14:36       ` Alexander Stein
2022-01-25 13:50 ` [PATCH 2/8] ARM: dts: imx6ul: change operating-points to uint32-matrix Alexander Stein
2022-01-25 13:50   ` Alexander Stein
2022-01-25 13:50 ` [PATCH 3/8] ARM: dts: imx6ul: fix keypad compatible Alexander Stein
2022-01-25 13:50   ` Alexander Stein
2022-01-25 13:50 ` [PATCH 4/8] ARM: dts: imx6ul: fix adc node compatible Alexander Stein
2022-01-25 13:50   ` Alexander Stein
2022-02-11  3:47   ` Shawn Guo
2022-02-11  3:47     ` Shawn Guo
2022-02-11 14:47     ` (EXT) " Alexander Stein
2022-02-11 14:47       ` Alexander Stein
2022-01-25 13:50 ` [PATCH 5/8] ARM: dts: imx6ul: remove unsupported adc property Alexander Stein
2022-01-25 13:50   ` Alexander Stein
2022-01-25 13:50 ` [PATCH 6/8] ARM: dts: imx6ul: fix csi node compatible Alexander Stein
2022-01-25 13:50   ` Alexander Stein
2022-01-25 13:50 ` [PATCH 7/8] ARM: dts: imx6ul: fix lcdif " Alexander Stein
2022-01-25 13:50   ` Alexander Stein
2022-01-25 13:50 ` [PATCH 8/8] ARM: dts: imx6ul: fix qspi " Alexander Stein
2022-01-25 13:50   ` Alexander Stein
2022-02-11  3:37 ` Shawn Guo [this message]
2022-02-11  3:37   ` [PATCH 0/8] various imx6ul DT fixes Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220211033743.GI4909@dragon \
    --to=shawnguo@kernel.org \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.