From: Shawn Guo <shawnguo@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Leo Li <leoyang.li@nxp.com>
Subject: Re: [PATCH 1/2] arm64: dts: fsl-ls1028a-qds: Drop overlay syntax hard coding
Date: Fri, 11 Feb 2022 16:57:03 +0800 [thread overview]
Message-ID: <20220211085703.GR4909@dragon> (raw)
In-Reply-To: <20220131110659.7lu7ccfcktfhgddm@skbuf>
On Mon, Jan 31, 2022 at 11:07:00AM +0000, Vladimir Oltean wrote:
> Hi Shawn,
>
> On Sat, Jan 29, 2022 at 03:09:11PM +0800, Shawn Guo wrote:
> > As suggested by commit 9ae8578b517a ("of: Documentation: change overlay
> > example to use current syntax"), there is no need to have overlay syntax
> > be hard coded in the device tree source file any more.
> >
> > Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> > ---
>
> This looks good.
>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> Just one minor comment below:
>
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts
> > index 8ffb707a1576..bd88438c2ecd 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts
> > @@ -11,98 +11,78 @@
> > /dts-v1/;
> > /plugin/;
> >
> > -/ {
> > - fragment@0 {
> > - target = <&mdio_slot1>;
> > -
> > - __overlay__ {
> > - #address-cells = <1>;
> > - #size-cells = <0>;
> > -
> > - slot1_sgmii: ethernet-phy@2 {
> > - /* AQR112 */
> > - reg = <0x2>;
> > - compatible = "ethernet-phy-ieee802.3-c45";
> > - };
> > - };
> > - };
> > +&mdio_slot1 {
> >
>
> Can you please delete this blank line?
Fixed. Thanks for spotting it, Vladimir!
Shawn
>
> > - fragment@1 {
> > - target = <&enetc_port0>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> >
> > - __overlay__ {
> > - phy-handle = <&slot1_sgmii>;
> > - phy-mode = "2500base-x";
> > - managed = "in-band-status";
> > - status = "okay";
> > - };
> > + slot1_sgmii: ethernet-phy@2 {
> > + /* AQR112 */
> > + reg = <0x2>;
> > + compatible = "ethernet-phy-ieee802.3-c45";
> > };
> > +};
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Leo Li <leoyang.li@nxp.com>
Subject: Re: [PATCH 1/2] arm64: dts: fsl-ls1028a-qds: Drop overlay syntax hard coding
Date: Fri, 11 Feb 2022 16:57:03 +0800 [thread overview]
Message-ID: <20220211085703.GR4909@dragon> (raw)
In-Reply-To: <20220131110659.7lu7ccfcktfhgddm@skbuf>
On Mon, Jan 31, 2022 at 11:07:00AM +0000, Vladimir Oltean wrote:
> Hi Shawn,
>
> On Sat, Jan 29, 2022 at 03:09:11PM +0800, Shawn Guo wrote:
> > As suggested by commit 9ae8578b517a ("of: Documentation: change overlay
> > example to use current syntax"), there is no need to have overlay syntax
> > be hard coded in the device tree source file any more.
> >
> > Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> > ---
>
> This looks good.
>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> Just one minor comment below:
>
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts
> > index 8ffb707a1576..bd88438c2ecd 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts
> > @@ -11,98 +11,78 @@
> > /dts-v1/;
> > /plugin/;
> >
> > -/ {
> > - fragment@0 {
> > - target = <&mdio_slot1>;
> > -
> > - __overlay__ {
> > - #address-cells = <1>;
> > - #size-cells = <0>;
> > -
> > - slot1_sgmii: ethernet-phy@2 {
> > - /* AQR112 */
> > - reg = <0x2>;
> > - compatible = "ethernet-phy-ieee802.3-c45";
> > - };
> > - };
> > - };
> > +&mdio_slot1 {
> >
>
> Can you please delete this blank line?
Fixed. Thanks for spotting it, Vladimir!
Shawn
>
> > - fragment@1 {
> > - target = <&enetc_port0>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> >
> > - __overlay__ {
> > - phy-handle = <&slot1_sgmii>;
> > - phy-mode = "2500base-x";
> > - managed = "in-band-status";
> > - status = "okay";
> > - };
> > + slot1_sgmii: ethernet-phy@2 {
> > + /* AQR112 */
> > + reg = <0x2>;
> > + compatible = "ethernet-phy-ieee802.3-c45";
> > };
> > +};
next prev parent reply other threads:[~2022-02-11 8:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 7:09 [PATCH 0/2] Improve fsl-ls1028a-qds device tree overlay build Shawn Guo
2022-01-29 7:09 ` Shawn Guo
2022-01-29 7:09 ` [PATCH 1/2] arm64: dts: fsl-ls1028a-qds: Drop overlay syntax hard coding Shawn Guo
2022-01-29 7:09 ` Shawn Guo
2022-01-31 11:07 ` Vladimir Oltean
2022-01-31 11:07 ` Vladimir Oltean
2022-02-11 8:57 ` Shawn Guo [this message]
2022-02-11 8:57 ` Shawn Guo
2022-01-29 7:09 ` [PATCH 2/2] arm64: dts: freescale: Use overlay target for simplicity Shawn Guo
2022-01-29 7:09 ` Shawn Guo
2022-01-31 11:07 ` Vladimir Oltean
2022-01-31 11:07 ` Vladimir Oltean
2022-02-09 22:10 ` Tim Harvey
2022-02-11 9:10 ` Shawn Guo
2022-02-11 23:23 ` Tim Harvey
2022-02-12 4:00 ` Shawn Guo
2022-02-14 23:09 ` Tim Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220211085703.GR4909@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.