All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: daniel@ffwll.ch, sumit.semwal@linaro.org,
	dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Subject: [PATCH 15/23] drm/amdgpu: use dma_resv_get_singleton in amdgpu_pasid_free_cb
Date: Fri, 11 Feb 2022 13:49:55 +0100	[thread overview]
Message-ID: <20220211125003.918447-16-christian.koenig@amd.com> (raw)
In-Reply-To: <20220211125003.918447-1-christian.koenig@amd.com>

Makes the code a bit more simpler.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: amd-gfx@lists.freedesktop.org
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 23 +++--------------------
 1 file changed, 3 insertions(+), 20 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
index be48487e2ca7..888d97143177 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
@@ -107,36 +107,19 @@ static void amdgpu_pasid_free_cb(struct dma_fence *fence,
 void amdgpu_pasid_free_delayed(struct dma_resv *resv,
 			       u32 pasid)
 {
-	struct dma_fence *fence, **fences;
 	struct amdgpu_pasid_cb *cb;
-	unsigned count;
+	struct dma_fence *fence;
 	int r;
 
-	r = dma_resv_get_fences(resv, true, &count, &fences);
+	r = dma_resv_get_singleton(resv, true, &fence);
 	if (r)
 		goto fallback;
 
-	if (count == 0) {
+	if (!fence) {
 		amdgpu_pasid_free(pasid);
 		return;
 	}
 
-	if (count == 1) {
-		fence = fences[0];
-		kfree(fences);
-	} else {
-		uint64_t context = dma_fence_context_alloc(1);
-		struct dma_fence_array *array;
-
-		array = dma_fence_array_create(count, fences, context,
-					       1, false);
-		if (!array) {
-			kfree(fences);
-			goto fallback;
-		}
-		fence = &array->base;
-	}
-
 	cb = kmalloc(sizeof(*cb), GFP_KERNEL);
 	if (!cb) {
 		/* Last resort when we are OOM */
-- 
2.25.1


  parent reply	other threads:[~2022-02-11 12:50 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-11 12:49 completely rework the dma_resv semantic Christian König
2022-02-11 12:49 ` [PATCH 01/23] dma-buf: add dma_resv_replace_fences Christian König
2022-02-11 12:49 ` [PATCH 02/23] dma-buf: finally make the dma_resv_list private v2 Christian König
2022-02-11 12:49 ` [PATCH 03/23] dma-buf: add dma_resv_get_singleton v2 Christian König
2022-02-11 12:49 ` [PATCH 04/23] RDMA: use dma_resv_wait() instead of extracting the fence Christian König
2022-02-11 12:49 ` [PATCH 05/23] drm/etnaviv: stop using dma_resv_excl_fence Christian König
2022-02-11 12:49 ` [PATCH 06/23] drm/nouveau: " Christian König
2022-02-11 12:49 ` [PATCH 07/23] drm/vmwgfx: " Christian König
2022-02-11 12:49 ` [PATCH 08/23] drm/radeon: " Christian König
2022-02-11 12:49 ` [PATCH 09/23] drm/amdgpu: use dma_resv_for_each_fence for CS workaround Christian König
2022-02-11 12:49 ` [PATCH 10/23] dma-buf: finally make dma_resv_excl_fence private v2 Christian König
2022-02-11 12:49 ` [PATCH 11/23] dma-buf: drop the DAG approach for the dma_resv object Christian König
2022-02-11 12:49 ` [PATCH 12/23] dma-buf/drivers: make reserving a shared slot mandatory v3 Christian König
2022-02-11 12:49 ` [PATCH 13/23] drm/atomic-helper: support more than one write fence in drm_gem_plane_helper_prepare_fb Christian König
2022-02-11 12:49 ` [PATCH 14/23] drm/nouveau: support more than one write fence in fenv50_wndw_prepare_fb Christian König
2022-02-11 12:49 ` Christian König [this message]
2022-02-11 12:49 ` [PATCH 16/23] dma-buf: add enum dma_resv_usage v3 Christian König
2022-02-11 12:49 ` [PATCH 17/23] dma-buf: specify usage while adding fences to dma_resv obj v4 Christian König
2022-02-11 12:49 ` [PATCH 18/23] drm/amdgpu: remove dma_resv workaround Christian König
2022-02-11 12:49 ` [PATCH 19/23] dma-buf: add DMA_RESV_USAGE_KERNEL Christian König
2022-02-11 12:50 ` [PATCH 20/23] dma-buf: add DMA_RESV_USAGE_BOOKKEEP v2 Christian König
2022-02-11 12:50 ` [PATCH 21/23] dma-buf: wait for map to complete for static attachments Christian König
2022-02-11 12:50 ` [PATCH 22/23] drm/i915: drop bo->moving dependency Christian König
2022-02-11 12:50 ` [PATCH 23/23] drm/ttm: remove bo->moving Christian König
2022-02-18 11:03 ` completely rework the dma_resv semantic Christian König
  -- strict thread matches above, loose matches on Subject: below --
2022-03-21 13:58 [PATCH 01/23] dma-buf: add dma_resv_replace_fences v2 Christian König
2022-03-21 13:58 ` [PATCH 15/23] drm/amdgpu: use dma_resv_get_singleton in amdgpu_pasid_free_cb Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220211125003.918447-16-christian.koenig@amd.com \
    --to=ckoenig.leichtzumerken@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.