From: "Rafał Miłecki" <zajec5@gmail.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>
Subject: [PATCH V2 3/3] nvmem: core: add cell name based matching of DT cell nodes
Date: Fri, 11 Feb 2022 14:05:54 +0100 [thread overview]
Message-ID: <20220211130554.13062-4-zajec5@gmail.com> (raw)
In-Reply-To: <20220211130554.13062-1-zajec5@gmail.com>
From: Rafał Miłecki <rafal@milecki.pl>
When adding NVMEM cells defined by driver it's important to match them
with DT nodes that specify matching names. That way other bindings &
drivers can reference such "dynamic" NVMEM cells.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
drivers/nvmem/core.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 53a43d843743..a891449c52f1 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -499,6 +499,31 @@ static int nvmem_cell_info_to_nvmem_cell_entry(struct nvmem_device *nvmem,
return 0;
}
+/**
+ * nvmem_find_cell_of_node() - Find DT node matching nvmem cell
+ *
+ * @nvmem: nvmem provider
+ * @name: nvmem cell name
+ *
+ * Runtime created nvmem cells (those not coming from DT) may still need to be
+ * referenced in DT. This function allows finding DT node referencing nvmem cell
+ * by its name. Such a DT node can be then used by nvmem consumers.
+ *
+ * Return: NULL or pointer to DT node
+ */
+static struct device_node *nvmem_find_cell_of_node(struct nvmem_device *nvmem,
+ const char *name)
+{
+ struct device_node *child;
+
+ for_each_child_of_node(nvmem->dev.of_node, child) {
+ if (!strcmp(child->name, name))
+ return child;
+ }
+
+ return NULL;
+}
+
/**
* nvmem_add_cells() - Add cell information to an nvmem device
*
@@ -532,6 +557,8 @@ static int nvmem_add_cells(struct nvmem_device *nvmem,
goto err;
}
+ cells[i]->np = nvmem_find_cell_of_node(nvmem, cells[i]->name);
+
nvmem_cell_entry_add(cells[i]);
}
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>
Subject: [PATCH V2 3/3] nvmem: core: add cell name based matching of DT cell nodes
Date: Fri, 11 Feb 2022 14:05:54 +0100 [thread overview]
Message-ID: <20220211130554.13062-4-zajec5@gmail.com> (raw)
In-Reply-To: <20220211130554.13062-1-zajec5@gmail.com>
From: Rafał Miłecki <rafal@milecki.pl>
When adding NVMEM cells defined by driver it's important to match them
with DT nodes that specify matching names. That way other bindings &
drivers can reference such "dynamic" NVMEM cells.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
drivers/nvmem/core.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 53a43d843743..a891449c52f1 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -499,6 +499,31 @@ static int nvmem_cell_info_to_nvmem_cell_entry(struct nvmem_device *nvmem,
return 0;
}
+/**
+ * nvmem_find_cell_of_node() - Find DT node matching nvmem cell
+ *
+ * @nvmem: nvmem provider
+ * @name: nvmem cell name
+ *
+ * Runtime created nvmem cells (those not coming from DT) may still need to be
+ * referenced in DT. This function allows finding DT node referencing nvmem cell
+ * by its name. Such a DT node can be then used by nvmem consumers.
+ *
+ * Return: NULL or pointer to DT node
+ */
+static struct device_node *nvmem_find_cell_of_node(struct nvmem_device *nvmem,
+ const char *name)
+{
+ struct device_node *child;
+
+ for_each_child_of_node(nvmem->dev.of_node, child) {
+ if (!strcmp(child->name, name))
+ return child;
+ }
+
+ return NULL;
+}
+
/**
* nvmem_add_cells() - Add cell information to an nvmem device
*
@@ -532,6 +557,8 @@ static int nvmem_add_cells(struct nvmem_device *nvmem,
goto err;
}
+ cells[i]->np = nvmem_find_cell_of_node(nvmem, cells[i]->name);
+
nvmem_cell_entry_add(cells[i]);
}
--
2.34.1
next prev parent reply other threads:[~2022-02-11 13:07 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 16:02 [PATCH 0/3] nvmem: allow specifying cells by just names in DT Rafał Miłecki
2022-01-24 16:02 ` Rafał Miłecki
2022-01-24 16:02 ` [PATCH 1/3] dt-bindings: nvmem: make "reg" property optional Rafał Miłecki
2022-01-24 16:02 ` Rafał Miłecki
2022-02-11 12:38 ` Rob Herring
2022-02-11 12:38 ` Rob Herring
2022-01-24 16:02 ` [PATCH 2/3] dt-bindings: nvmem: brcm, nvram: add NVMEM cell to example Rafał Miłecki
2022-01-24 16:02 ` [PATCH 2/3] dt-bindings: nvmem: brcm,nvram: " Rafał Miłecki
2022-02-11 12:45 ` Rob Herring
2022-02-11 12:45 ` Rob Herring
2022-01-24 16:03 ` [PATCH 3/3] nvmem: core: add cell name based matching of DT cell nodes Rafał Miłecki
2022-01-24 16:03 ` Rafał Miłecki
2022-02-11 13:05 ` [PATCH V2 0/3] nvmem: allow specifying cells by just names in DT Rafał Miłecki
2022-02-11 13:05 ` Rafał Miłecki
2022-02-11 13:05 ` [PATCH V2 1/3] dt-bindings: nvmem: make "reg" property optional Rafał Miłecki
2022-02-11 13:05 ` Rafał Miłecki
2022-02-11 13:05 ` [PATCH V2 2/3] dt-bindings: nvmem: brcm, nvram: add NVMEM cell to example Rafał Miłecki
2022-02-11 13:05 ` [PATCH V2 2/3] dt-bindings: nvmem: brcm,nvram: " Rafał Miłecki
2022-02-17 23:58 ` [PATCH V2 2/3] dt-bindings: nvmem: brcm, nvram: " Rob Herring
2022-02-17 23:58 ` [PATCH V2 2/3] dt-bindings: nvmem: brcm,nvram: " Rob Herring
2022-02-11 13:05 ` Rafał Miłecki [this message]
2022-02-11 13:05 ` [PATCH V2 3/3] nvmem: core: add cell name based matching of DT cell nodes Rafał Miłecki
2022-02-18 7:07 ` [PATCH V3 0/3] nvmem: allow specifying cells by just names in DT Rafał Miłecki
2022-02-18 7:07 ` Rafał Miłecki
2022-02-18 7:07 ` [PATCH V3 1/3] dt-bindings: nvmem: make "reg" property optional Rafał Miłecki
2022-02-18 7:07 ` Rafał Miłecki
2022-02-25 13:30 ` Srinivas Kandagatla
2022-02-25 13:30 ` Srinivas Kandagatla
2022-02-18 7:07 ` [PATCH V3 2/3] dt-bindings: nvmem: brcm,nvram: add basic NVMEM cells Rafał Miłecki
2022-02-18 7:07 ` Rafał Miłecki
2022-02-24 19:55 ` Rob Herring
2022-02-24 19:55 ` Rob Herring
2022-02-25 13:30 ` Srinivas Kandagatla
2022-02-25 13:30 ` Srinivas Kandagatla
2022-02-18 7:07 ` [PATCH V3 3/3] nvmem: core: add cell name based matching of DT cell nodes Rafał Miłecki
2022-02-18 7:07 ` Rafał Miłecki
2022-02-25 12:10 ` Srinivas Kandagatla
2022-02-25 12:10 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220211130554.13062-4-zajec5@gmail.com \
--to=zajec5@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.