* drivers/net/dsa/sja1105/sja1105_main.c:3370 sja1105_port_mcast_flood() warn: should '(((1))) << to' be a 64 bit type?
@ 2022-02-11 8:40 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-02-11 8:40 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 9006 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Vladimir Oltean <vladimir.oltean@nxp.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f1baf68e1383f6ed93eb9cff2866d46562607a43
commit: 4d9423549501812dafe6551d4a78db079ea87648 net: dsa: sja1105: offload bridge port flags to device
date: 12 months ago
:::::: branch date: 9 hours ago
:::::: commit date: 12 months ago
config: m68k-randconfig-m031-20220211 (https://download.01.org/0day-ci/archive/20220211/202202111635.N11UnMJE-lkp(a)intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/dsa/sja1105/sja1105_main.c:3370 sja1105_port_mcast_flood() warn: should '(((1))) << to' be a 64 bit type?
Old smatch warnings:
drivers/net/dsa/sja1105/sja1105_main.c:48 sja1105_port_allow_traffic() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:185 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 1
drivers/net/dsa/sja1105/sja1105_main.c:188 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 1
drivers/net/dsa/sja1105/sja1105_main.c:194 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 1
drivers/net/dsa/sja1105/sja1105_main.c:199 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 1
drivers/net/dsa/sja1105/sja1105_main.c:417 sja1105_init_l2_forwarding() warn: should '(((1))) << upstream' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:418 sja1105_init_l2_forwarding() warn: should '(((1))) << upstream' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:591 sja1105_init_avb_params() warn: is 'table->entries' large enough for 'struct sja1105_avb_params_entry'? 1
drivers/net/dsa/sja1105/sja1105_main.c:1183 sja1105_find_static_fdb_entry() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1301 sja1105et_fdb_add() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1303 sja1105et_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1311 sja1105et_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1397 sja1105pqrs_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1405 sja1105pqrs_fdb_add() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1410 sja1105pqrs_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1460 sja1105pqrs_fdb_del() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1544 sja1105_fdb_dump() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1865 sja1105_static_config_reload() warn: bitwise AND condition is false here
drivers/net/dsa/sja1105/sja1105_main.c:2212 sja1105_build_bridge_vlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2213 sja1105_build_bridge_vlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2215 sja1105_build_bridge_vlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2234 sja1105_build_dsa_8021q_vlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2235 sja1105_build_dsa_8021q_vlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2237 sja1105_build_dsa_8021q_vlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2287 sja1105_build_subvlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2288 sja1105_build_subvlans() warn: should '(((1))) << upstream' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2289 sja1105_build_subvlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2290 sja1105_build_subvlans() warn: should '(((1))) << upstream' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2295 sja1105_build_subvlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2297 sja1105_build_subvlans() warn: should '(((1))) << upstream' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2313 sja1105_build_subvlans() warn: should '(((1))) << (v->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2314 sja1105_build_subvlans() warn: should '(((1))) << upstream' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2454 sja1105_build_crosschip_subvlans() warn: should '(((1))) << (tmp->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2455 sja1105_build_crosschip_subvlans() warn: should '(((1))) << upstream' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2463 sja1105_build_crosschip_subvlans() warn: should '(((1))) << (tmp->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2464 sja1105_build_crosschip_subvlans() warn: should '(((1))) << upstream' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2489 sja1105_build_crosschip_subvlans() warn: should '(((1))) << upstream' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2490 sja1105_build_crosschip_subvlans() warn: should '(((1))) << (tmp->port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:3026 sja1105_mgmt_xmit() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:3326 sja1105_port_ucast_bcast_flood() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:3333 sja1105_port_ucast_bcast_flood() warn: should '(((1))) << to' be a 64 bit type?
vim +3370 drivers/net/dsa/sja1105/sja1105_main.c
4d942354950181 Vladimir Oltean 2021-02-12 3346
4d942354950181 Vladimir Oltean 2021-02-12 3347 static int sja1105_port_mcast_flood(struct sja1105_private *priv, int to,
4d942354950181 Vladimir Oltean 2021-02-12 3348 struct switchdev_brport_flags flags,
4d942354950181 Vladimir Oltean 2021-02-12 3349 struct netlink_ext_ack *extack)
4d942354950181 Vladimir Oltean 2021-02-12 3350 {
4d942354950181 Vladimir Oltean 2021-02-12 3351 struct sja1105_l2_lookup_entry *l2_lookup;
4d942354950181 Vladimir Oltean 2021-02-12 3352 struct sja1105_table *table;
4d942354950181 Vladimir Oltean 2021-02-12 3353 int match;
4d942354950181 Vladimir Oltean 2021-02-12 3354
4d942354950181 Vladimir Oltean 2021-02-12 3355 table = &priv->static_config.tables[BLK_IDX_L2_LOOKUP];
4d942354950181 Vladimir Oltean 2021-02-12 3356 l2_lookup = table->entries;
4d942354950181 Vladimir Oltean 2021-02-12 3357
4d942354950181 Vladimir Oltean 2021-02-12 3358 for (match = 0; match < table->entry_count; match++)
4d942354950181 Vladimir Oltean 2021-02-12 3359 if (l2_lookup[match].macaddr == SJA1105_UNKNOWN_MULTICAST &&
4d942354950181 Vladimir Oltean 2021-02-12 3360 l2_lookup[match].mask_macaddr == SJA1105_UNKNOWN_MULTICAST)
4d942354950181 Vladimir Oltean 2021-02-12 3361 break;
4d942354950181 Vladimir Oltean 2021-02-12 3362
4d942354950181 Vladimir Oltean 2021-02-12 3363 if (match == table->entry_count) {
4d942354950181 Vladimir Oltean 2021-02-12 3364 NL_SET_ERR_MSG_MOD(extack,
4d942354950181 Vladimir Oltean 2021-02-12 3365 "Could not find FDB entry for unknown multicast");
4d942354950181 Vladimir Oltean 2021-02-12 3366 return -ENOSPC;
4d942354950181 Vladimir Oltean 2021-02-12 3367 }
4d942354950181 Vladimir Oltean 2021-02-12 3368
4d942354950181 Vladimir Oltean 2021-02-12 3369 if (flags.val & BR_MCAST_FLOOD)
4d942354950181 Vladimir Oltean 2021-02-12 @3370 l2_lookup[match].destports |= BIT(to);
4d942354950181 Vladimir Oltean 2021-02-12 3371 else
4d942354950181 Vladimir Oltean 2021-02-12 3372 l2_lookup[match].destports &= ~BIT(to);
4d942354950181 Vladimir Oltean 2021-02-12 3373
4d942354950181 Vladimir Oltean 2021-02-12 3374 return sja1105_dynamic_config_write(priv, BLK_IDX_L2_LOOKUP,
4d942354950181 Vladimir Oltean 2021-02-12 3375 l2_lookup[match].index,
4d942354950181 Vladimir Oltean 2021-02-12 3376 &l2_lookup[match],
4d942354950181 Vladimir Oltean 2021-02-12 3377 true);
4d942354950181 Vladimir Oltean 2021-02-12 3378 }
4d942354950181 Vladimir Oltean 2021-02-12 3379
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-02-11 8:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-11 8:40 drivers/net/dsa/sja1105/sja1105_main.c:3370 sja1105_port_mcast_flood() warn: should '(((1))) << to' be a 64 bit type? kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.