From: Jason Gunthorpe <jgg@nvidia.com>
To: David Hildenbrand <david@redhat.com>
Cc: Alex Sierra <alex.sierra@amd.com>,
rcampbell@nvidia.com, willy@infradead.org,
Felix.Kuehling@amd.com, apopple@nvidia.com,
amd-gfx@lists.freedesktop.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, jglisse@redhat.com,
dri-devel@lists.freedesktop.org, akpm@linux-foundation.org,
linux-ext4@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH v6 01/10] mm: add zone device coherent type memory support
Date: Fri, 11 Feb 2022 12:56:24 -0400 [thread overview]
Message-ID: <20220211165624.GP4160@nvidia.com> (raw)
In-Reply-To: <6a8df47e-96d0-ffaf-247a-acc504e2532b@redhat.com>
On Fri, Feb 11, 2022 at 05:49:08PM +0100, David Hildenbrand wrote:
> On 11.02.22 17:45, Jason Gunthorpe wrote:
> > On Fri, Feb 11, 2022 at 05:15:25PM +0100, David Hildenbrand wrote:
> >
> >> ... I'm pretty sure we cannot FOLL_PIN DEVICE_PRIVATE pages
> >
> > Currently the only way to get a DEVICE_PRIVATE page out of the page
> > tables is via hmm_range_fault() and that doesn't manipulate any ref
> > counts.
>
> Thanks for clarifying Jason! ... and AFAIU, device exclusive entries are
> essentially just pointers at ordinary PageAnon() pages. So with DEVICE
> COHERENT we'll have the first PageAnon() ZONE_DEVICE pages mapped as
> present in the page tables where GUP could FOLL_PIN them.
This is my understanding
Though you probably understand what PageAnon means alot better than I
do.. I wonder if it really makes sense to talk about that together
with ZONE_DEVICE which has alot in common with filesystem originated
pages too.
I'm not sure what AMDs plan is here, is there an expecation that a GPU
driver will somehow stuff these pages into an existing anonymous
memory VMA or do they always come from a driver originated VMA?
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: David Hildenbrand <david@redhat.com>
Cc: Alex Sierra <alex.sierra@amd.com>,
akpm@linux-foundation.org, Felix.Kuehling@amd.com,
linux-mm@kvack.org, rcampbell@nvidia.com,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
hch@lst.de, jglisse@redhat.com, apopple@nvidia.com,
willy@infradead.org
Subject: Re: [PATCH v6 01/10] mm: add zone device coherent type memory support
Date: Fri, 11 Feb 2022 12:56:24 -0400 [thread overview]
Message-ID: <20220211165624.GP4160@nvidia.com> (raw)
In-Reply-To: <6a8df47e-96d0-ffaf-247a-acc504e2532b@redhat.com>
On Fri, Feb 11, 2022 at 05:49:08PM +0100, David Hildenbrand wrote:
> On 11.02.22 17:45, Jason Gunthorpe wrote:
> > On Fri, Feb 11, 2022 at 05:15:25PM +0100, David Hildenbrand wrote:
> >
> >> ... I'm pretty sure we cannot FOLL_PIN DEVICE_PRIVATE pages
> >
> > Currently the only way to get a DEVICE_PRIVATE page out of the page
> > tables is via hmm_range_fault() and that doesn't manipulate any ref
> > counts.
>
> Thanks for clarifying Jason! ... and AFAIU, device exclusive entries are
> essentially just pointers at ordinary PageAnon() pages. So with DEVICE
> COHERENT we'll have the first PageAnon() ZONE_DEVICE pages mapped as
> present in the page tables where GUP could FOLL_PIN them.
This is my understanding
Though you probably understand what PageAnon means alot better than I
do.. I wonder if it really makes sense to talk about that together
with ZONE_DEVICE which has alot in common with filesystem originated
pages too.
I'm not sure what AMDs plan is here, is there an expecation that a GPU
driver will somehow stuff these pages into an existing anonymous
memory VMA or do they always come from a driver originated VMA?
Jason
next prev parent reply other threads:[~2022-02-11 17:06 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 15:48 [PATCH v6 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping Alex Sierra
2022-02-01 15:48 ` Alex Sierra
2022-02-01 15:48 ` [PATCH v6 01/10] mm: add zone device coherent type memory support Alex Sierra
2022-02-01 15:48 ` Alex Sierra
2022-02-11 16:15 ` David Hildenbrand
2022-02-11 16:15 ` David Hildenbrand
2022-02-11 16:39 ` David Hildenbrand
2022-02-11 16:39 ` David Hildenbrand
2022-02-11 16:52 ` Sierra Guiza, Alejandro (Alex)
2022-02-11 16:52 ` Sierra Guiza, Alejandro (Alex)
2022-02-11 17:07 ` Felix Kuehling
2022-02-11 17:07 ` Felix Kuehling
2022-02-15 12:16 ` David Hildenbrand
2022-02-15 12:16 ` David Hildenbrand
2022-02-15 14:45 ` Jason Gunthorpe
2022-02-15 14:45 ` Jason Gunthorpe
2022-02-15 18:32 ` Christoph Hellwig
2022-02-15 18:32 ` Christoph Hellwig
2022-02-15 19:41 ` Jason Gunthorpe
2022-02-15 19:41 ` Jason Gunthorpe
2022-02-15 21:35 ` Felix Kuehling
2022-02-15 21:35 ` Felix Kuehling
2022-02-15 21:47 ` Jason Gunthorpe
2022-02-15 21:47 ` Jason Gunthorpe
2022-02-15 22:49 ` Felix Kuehling
2022-02-15 22:49 ` Felix Kuehling
2022-02-16 2:01 ` Jason Gunthorpe
2022-02-16 2:01 ` Jason Gunthorpe
2022-02-16 16:56 ` Felix Kuehling
2022-02-16 16:56 ` Felix Kuehling
2022-02-16 17:28 ` Jason Gunthorpe
2022-02-16 17:28 ` Jason Gunthorpe
2022-02-16 1:23 ` Alistair Popple
2022-02-16 1:23 ` Alistair Popple
2022-02-16 2:03 ` Jason Gunthorpe
2022-02-16 2:03 ` Jason Gunthorpe
2022-02-16 2:36 ` Alistair Popple
2022-02-16 2:36 ` Alistair Popple
2022-02-16 8:31 ` David Hildenbrand
2022-02-16 8:31 ` David Hildenbrand
2022-02-16 12:26 ` Jason Gunthorpe
2022-02-16 12:26 ` Jason Gunthorpe
2022-02-17 1:05 ` Alistair Popple
2022-02-17 1:05 ` Alistair Popple
2022-02-17 21:12 ` Felix Kuehling
2022-02-17 21:12 ` Felix Kuehling
2022-02-18 0:19 ` Jason Gunthorpe
2022-02-18 0:19 ` Jason Gunthorpe
2022-02-18 19:20 ` Felix Kuehling
2022-02-18 19:20 ` Felix Kuehling
2022-02-18 19:26 ` Jason Gunthorpe
2022-02-18 19:26 ` Jason Gunthorpe
2022-02-18 19:37 ` Felix Kuehling
2022-02-18 19:37 ` Felix Kuehling
2022-02-28 20:34 ` [PATCH] mm: split vm_normal_pages for LRU and non-LRU handling Alex Sierra
2022-02-28 20:34 ` Alex Sierra
2022-02-28 22:41 ` Felix Kuehling
2022-02-28 22:41 ` Felix Kuehling
2022-03-01 8:03 ` David Hildenbrand
2022-03-01 8:03 ` David Hildenbrand
2022-03-01 16:08 ` Felix Kuehling
2022-03-01 16:08 ` Felix Kuehling
2022-03-01 16:22 ` David Hildenbrand
2022-03-01 16:22 ` David Hildenbrand
2022-03-01 16:30 ` Felix Kuehling
2022-03-01 16:30 ` Felix Kuehling
2022-03-01 16:32 ` David Hildenbrand
2022-03-01 16:32 ` David Hildenbrand
2022-02-18 0:59 ` [PATCH v6 01/10] mm: add zone device coherent type memory support Alistair Popple
2022-02-18 0:59 ` Alistair Popple
2022-02-11 16:45 ` Jason Gunthorpe
2022-02-11 16:45 ` Jason Gunthorpe
2022-02-11 16:49 ` David Hildenbrand
2022-02-11 16:49 ` David Hildenbrand
2022-02-11 16:56 ` Jason Gunthorpe [this message]
2022-02-11 16:56 ` Jason Gunthorpe
2022-02-15 12:15 ` David Hildenbrand
2022-02-15 12:15 ` David Hildenbrand
2022-02-15 18:52 ` Felix Kuehling
2022-02-15 18:52 ` Felix Kuehling
2022-02-11 17:05 ` Felix Kuehling
2022-02-11 17:05 ` Felix Kuehling
2022-02-14 2:04 ` Alistair Popple
2022-02-14 2:04 ` Alistair Popple
2022-02-01 15:48 ` [PATCH v6 02/10] mm: add device coherent vma selection for memory migration Alex Sierra
2022-02-01 15:48 ` Alex Sierra
2022-02-01 15:48 ` [PATCH v6 03/10] mm/gup: fail get_user_pages for LONGTERM dev coherent type Alex Sierra
2022-02-01 15:48 ` Alex Sierra
2022-02-01 15:48 ` [PATCH v6 04/10] drm/amdkfd: add SPM support for SVM Alex Sierra
2022-02-01 15:48 ` Alex Sierra
2022-02-01 15:48 ` [PATCH v6 05/10] drm/amdkfd: coherent type as sys mem on migration to ram Alex Sierra
2022-02-01 15:48 ` Alex Sierra
2022-02-01 15:48 ` [PATCH v6 06/10] lib: test_hmm add ioctl to get zone device type Alex Sierra
2022-02-01 15:48 ` Alex Sierra
2022-02-01 15:48 ` [PATCH v6 07/10] lib: test_hmm add module param for " Alex Sierra
2022-02-01 15:48 ` Alex Sierra
2022-02-01 15:48 ` [PATCH v6 08/10] lib: add support for device coherent type in test_hmm Alex Sierra
2022-02-01 15:48 ` Alex Sierra
2022-02-01 15:49 ` [PATCH v6 09/10] tools: update hmm-test to support device coherent type Alex Sierra
2022-02-01 15:49 ` Alex Sierra
2022-02-01 15:49 ` [PATCH v6 10/10] tools: update test_hmm script to support SP config Alex Sierra
2022-02-01 15:49 ` Alex Sierra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220211165624.GP4160@nvidia.com \
--to=jgg@nvidia.com \
--cc=Felix.Kuehling@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alex.sierra@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=apopple@nvidia.com \
--cc=david@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=jglisse@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rcampbell@nvidia.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.