From: Bjorn Helgaas <helgaas@kernel.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
"open list:THUNDERBOLT DRIVER" <linux-usb@vger.kernel.org>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
Hans de Goede <hdegoede@redhat.com>,
"open list:RADEON and AMDGPU DRM DRIVERS"
<amd-gfx@lists.freedesktop.org>,
"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS"
<nouveau@lists.freedesktop.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Alexander.Deucher@amd.com,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Macpaul Lin <macpaul.lin@mediatek.com>
Subject: Re: [PATCH v3 06/12] PCI: Explicitly mark USB4 NHI devices as removable
Date: Fri, 11 Feb 2022 15:58:26 -0600 [thread overview]
Message-ID: <20220211215826.GA737975@bhelgaas> (raw)
In-Reply-To: <20220211193250.1904843-7-mario.limonciello@amd.com>
On Fri, Feb 11, 2022 at 01:32:44PM -0600, Mario Limonciello wrote:
> USB4 class devices are also removable like Intel Thunderbolt devices.
Spec reference, please.
> Drivers of downstream devices use this information to declare functional
> differences in how the drivers perform by knowing that they are connected
> to an upstream TBT/USB4 port.
>
> Reviewed-by: Macpaul Lin <macpaul.lin@mediatek.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/pci/probe.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index 2693211d31cf..67ca33188cba 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -1610,6 +1610,7 @@ static void pci_set_removable(struct pci_dev *dev)
> * exposed as "removable" to userspace.
> */
> if (vsec ||
> + dev->class == PCI_CLASS_SERIAL_USB_USB4 ||
> pci_acpi_is_usb4(dev) ||
> (parent &&
> (parent->external_facing || dev_is_removable(&parent->dev))))
> --
> 2.34.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
"open list:THUNDERBOLT DRIVER" <linux-usb@vger.kernel.org>,
"open list:RADEON and AMDGPU DRM DRIVERS"
<amd-gfx@lists.freedesktop.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS"
<nouveau@lists.freedesktop.org>,
Hans de Goede <hdegoede@redhat.com>,
Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
Alexander.Deucher@amd.com,
Andreas Noever <andreas.noever@gmail.com>,
Macpaul Lin <macpaul.lin@mediatek.com>
Subject: Re: [PATCH v3 06/12] PCI: Explicitly mark USB4 NHI devices as removable
Date: Fri, 11 Feb 2022 15:58:26 -0600 [thread overview]
Message-ID: <20220211215826.GA737975@bhelgaas> (raw)
In-Reply-To: <20220211193250.1904843-7-mario.limonciello@amd.com>
On Fri, Feb 11, 2022 at 01:32:44PM -0600, Mario Limonciello wrote:
> USB4 class devices are also removable like Intel Thunderbolt devices.
Spec reference, please.
> Drivers of downstream devices use this information to declare functional
> differences in how the drivers perform by knowing that they are connected
> to an upstream TBT/USB4 port.
>
> Reviewed-by: Macpaul Lin <macpaul.lin@mediatek.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/pci/probe.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index 2693211d31cf..67ca33188cba 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -1610,6 +1610,7 @@ static void pci_set_removable(struct pci_dev *dev)
> * exposed as "removable" to userspace.
> */
> if (vsec ||
> + dev->class == PCI_CLASS_SERIAL_USB_USB4 ||
> pci_acpi_is_usb4(dev) ||
> (parent &&
> (parent->external_facing || dev_is_removable(&parent->dev))))
> --
> 2.34.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
"open list:THUNDERBOLT DRIVER" <linux-usb@vger.kernel.org>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
Hans de Goede <hdegoede@redhat.com>,
"open list:RADEON and AMDGPU DRM DRIVERS"
<amd-gfx@lists.freedesktop.org>,
"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS"
<nouveau@lists.freedesktop.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Alexander.Deucher@amd.com,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Macpaul Lin <macpaul.lin@mediatek.com>
Subject: Re: [Nouveau] [PATCH v3 06/12] PCI: Explicitly mark USB4 NHI devices as removable
Date: Fri, 11 Feb 2022 15:58:26 -0600 [thread overview]
Message-ID: <20220211215826.GA737975@bhelgaas> (raw)
In-Reply-To: <20220211193250.1904843-7-mario.limonciello@amd.com>
On Fri, Feb 11, 2022 at 01:32:44PM -0600, Mario Limonciello wrote:
> USB4 class devices are also removable like Intel Thunderbolt devices.
Spec reference, please.
> Drivers of downstream devices use this information to declare functional
> differences in how the drivers perform by knowing that they are connected
> to an upstream TBT/USB4 port.
>
> Reviewed-by: Macpaul Lin <macpaul.lin@mediatek.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/pci/probe.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index 2693211d31cf..67ca33188cba 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -1610,6 +1610,7 @@ static void pci_set_removable(struct pci_dev *dev)
> * exposed as "removable" to userspace.
> */
> if (vsec ||
> + dev->class == PCI_CLASS_SERIAL_USB_USB4 ||
> pci_acpi_is_usb4(dev) ||
> (parent &&
> (parent->external_facing || dev_is_removable(&parent->dev))))
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-02-11 21:58 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 19:32 [PATCH v3 00/12] Overhaul `is_thunderbolt` Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 19:32 ` [Nouveau] " Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 19:32 ` [PATCH v3 01/12] thunderbolt: move definition of PCI_CLASS_SERIAL_USB_USB4 Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 19:32 ` [Nouveau] " Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 21:02 ` Bjorn Helgaas
2022-02-11 21:02 ` Bjorn Helgaas
2022-02-11 21:02 ` [Nouveau] " Bjorn Helgaas
2022-02-11 21:02 ` Bjorn Helgaas
2022-02-11 19:32 ` [PATCH v3 02/12] PCI: Move `is_thunderbolt` check for lack of command completed to a quirk Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 19:32 ` [Nouveau] " Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 21:20 ` Bjorn Helgaas
2022-02-11 21:20 ` Bjorn Helgaas
2022-02-11 21:20 ` [Nouveau] " Bjorn Helgaas
2022-02-11 21:20 ` Bjorn Helgaas
2022-02-11 19:32 ` [PATCH v3 03/12] PCI: Move check for old Apple Thunderbolt controllers into " Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 19:32 ` [Nouveau] " Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 21:35 ` Bjorn Helgaas
2022-02-11 21:35 ` Bjorn Helgaas
2022-02-11 21:35 ` [Nouveau] " Bjorn Helgaas
2022-02-11 21:35 ` Bjorn Helgaas
2022-02-11 22:06 ` Limonciello, Mario
2022-02-11 22:06 ` Limonciello, Mario
2022-02-11 22:06 ` [Nouveau] " Limonciello, Mario
2022-02-11 22:06 ` Limonciello, Mario
2022-02-14 7:15 ` Mika Westerberg
2022-02-14 7:15 ` Mika Westerberg
2022-02-14 7:15 ` [Nouveau] " Mika Westerberg
2022-02-14 7:15 ` Mika Westerberg
2022-02-13 9:19 ` Lukas Wunner
2022-02-13 9:19 ` [Nouveau] " Lukas Wunner
2022-02-13 9:19 ` Lukas Wunner
2022-02-13 9:21 ` Lukas Wunner
2022-02-13 9:21 ` [Nouveau] " Lukas Wunner
2022-02-13 9:21 ` Lukas Wunner
2022-02-14 7:23 ` Mika Westerberg
2022-02-14 7:23 ` [Nouveau] " Mika Westerberg
2022-02-14 7:23 ` Mika Westerberg
2022-02-11 19:32 ` [PATCH v3 04/12] PCI: Drop the `is_thunderbolt` attribute from PCI core Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 19:32 ` [Nouveau] " Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-13 8:20 ` Lukas Wunner
2022-02-13 8:20 ` [Nouveau] " Lukas Wunner
2022-02-13 8:20 ` Lukas Wunner
2022-02-13 17:26 ` Limonciello, Mario
2022-02-13 17:26 ` [Nouveau] " Limonciello, Mario
2022-02-13 17:26 ` Limonciello, Mario
2022-02-14 7:27 ` Mika Westerberg
2022-02-14 7:27 ` Mika Westerberg
2022-02-14 7:27 ` [Nouveau] " Mika Westerberg
2022-02-14 7:27 ` Mika Westerberg
2022-02-11 19:32 ` [PATCH v3 05/12] PCI: Detect root port of internal USB4 devices by `usb4-host-interface` Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 19:32 ` [Nouveau] " Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 21:45 ` Bjorn Helgaas
2022-02-11 21:45 ` Bjorn Helgaas
2022-02-11 21:45 ` [Nouveau] " Bjorn Helgaas
2022-02-11 21:45 ` Bjorn Helgaas
2022-02-14 7:34 ` Mika Westerberg
2022-02-14 7:34 ` Mika Westerberg
2022-02-14 7:34 ` [Nouveau] " Mika Westerberg
2022-02-14 7:34 ` Mika Westerberg
2022-02-14 8:52 ` Lukas Wunner
2022-02-14 8:52 ` [Nouveau] " Lukas Wunner
2022-02-14 8:52 ` Lukas Wunner
2022-02-14 10:56 ` Mika Westerberg
2022-02-14 10:56 ` Mika Westerberg
2022-02-14 11:08 ` [Nouveau] " Mika Westerberg
2022-02-14 11:08 ` Mika Westerberg
2022-02-14 11:08 ` Mika Westerberg
2022-02-14 10:56 ` [Nouveau] " Mika Westerberg
2022-02-14 10:56 ` Mika Westerberg
2022-02-14 11:11 ` Mika Westerberg
2022-02-14 11:11 ` [Nouveau] " Mika Westerberg
2022-02-14 11:11 ` Mika Westerberg
2022-02-17 20:40 ` Bjorn Helgaas
2022-02-17 20:40 ` Bjorn Helgaas
2022-02-17 20:40 ` [Nouveau] " Bjorn Helgaas
2022-02-17 20:40 ` Bjorn Helgaas
2022-02-11 19:32 ` [PATCH v3 06/12] PCI: Explicitly mark USB4 NHI devices as removable Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 19:32 ` [Nouveau] " Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 21:58 ` Bjorn Helgaas [this message]
2022-02-11 21:58 ` [Nouveau] " Bjorn Helgaas
2022-02-11 21:58 ` Bjorn Helgaas
2022-02-11 19:32 ` [PATCH v3 07/12] PCI: Set ports for discrete USB4 controllers appropriately Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 19:32 ` [Nouveau] " Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 22:10 ` Bjorn Helgaas
2022-02-11 22:10 ` Bjorn Helgaas
2022-02-11 22:10 ` [Nouveau] " Bjorn Helgaas
2022-02-11 22:10 ` Bjorn Helgaas
2022-02-11 19:32 ` [PATCH v3 08/12] drm/amd: drop the use of `pci_is_thunderbolt_attached` Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 19:32 ` [Nouveau] " Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 19:32 ` [PATCH v3 09/12] drm/nouveau: " Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 19:32 ` [Nouveau] " Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 19:32 ` [PATCH v3 10/12] drm/radeon: " Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 19:32 ` [Nouveau] " Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 19:32 ` [PATCH v3 11/12] platform/x86: amd-gmux: " Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 19:32 ` [Nouveau] " Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 19:32 ` [PATCH v3 12/12] PCI: drop `pci_is_thunderbolt_attached` Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
2022-02-11 19:32 ` [Nouveau] " Mario Limonciello
2022-02-11 19:32 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220211215826.GA737975@bhelgaas \
--to=helgaas@kernel.org \
--cc=Alexander.Deucher@amd.com \
--cc=YehezkelShB@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andreas.noever@gmail.com \
--cc=bhelgaas@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=macpaul.lin@mediatek.com \
--cc=mario.limonciello@amd.com \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.