Re: [Buildroot] [PATCH v6 3/8] package/icu: don't disable renaming for host build

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: "Daniel Price" <daniel.price@gmail.com>,
	"Gilles Talis" <gilles.talis@gmail.com>,
	"Peter Seiderer" <ps.report@gmx.net>,
	"Julien Corjon" <corjon.j@ecagroup.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org, "Martin Bark" <martin@barkynet.com>,
	"Gaël Portay" <gael.portay@collabora.com>
Subject: Re: [Buildroot] [PATCH v6 3/8] package/icu: don't disable renaming for host build
Date: Sun, 13 Feb 2022 16:00:51 +0100	[thread overview]
Message-ID: <20220213150051.GB4462@scaer> (raw)
In-Reply-To: <20220205201837.3324085-3-james.hilliard1@gmail.com>

James, All,

On 2022-02-05 13:18 -0700, James Hilliard spake thusly:
> Using a different renaming option for the icu host build can cause
> issues for packages such as qt5webengine which expect target and
> host packages to be built with the same options.

This little hand-waving is not explaning the actual error that those
packages encounter, nor the root cause for that error.

A package that needs both host and target to have the same options is
most probably doing somethig wrong, like linking a host program and
taking the result as valid for the target...

However, our adding the --disable-renaming in the first place in
3911e67151b (icu: security bump to version 51.2) did not provide any
explanations why it was needed to begin with.

So it is not much uglier to remove it without further explanations
either.

Yet, a reference to the original commit would be nice, like the little
blurb I wrote above maybe...

Regards,
Yann E. MORIN.

> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/icu/icu.mk       | 3 +--
>  package/nodejs/nodejs.mk | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/package/icu/icu.mk b/package/icu/icu.mk
> index 7e0c96e43a..ebbb1968fc 100644
> --- a/package/icu/icu.mk
> +++ b/package/icu/icu.mk
> @@ -45,8 +45,7 @@ HOST_ICU_CONF_OPTS = \
>  	--disable-tests \
>  	--disable-extras \
>  	--disable-icuio \
> -	--disable-layout \
> -	--disable-renaming
> +	--disable-layout
>  ICU_SUBDIR = source
>  HOST_ICU_SUBDIR = source
>  
> diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
> index 727af6dc50..2e41c11dbd 100644
> --- a/package/nodejs/nodejs.mk
> +++ b/package/nodejs/nodejs.mk
> @@ -94,7 +94,7 @@ NODEJS_HOST_TOOLS_V8 = \
>  NODEJS_HOST_TOOLS_NODE = mkcodecache
>  NODEJS_HOST_TOOLS = $(NODEJS_HOST_TOOLS_V8) $(NODEJS_HOST_TOOLS_NODE)
>  
> -HOST_NODEJS_CXXFLAGS = $(HOST_CXXFLAGS) -DU_DISABLE_RENAMING=1
> +HOST_NODEJS_CXXFLAGS = $(HOST_CXXFLAGS)
>  
>  define HOST_NODEJS_BUILD_CMDS
>  	$(HOST_MAKE_ENV) PYTHON=$(HOST_DIR)/bin/python3 \
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot