Re: [Buildroot] [PATCH v6 2/8] package/re2: switch to generic-package make build

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Jmes, All,
 > On 2022-02-05 13:18 -0700, James Hilliard spake thusly:
 >> The cmake build appears to be missing features such as pkg-config
 >> generation support, switch to the regular makefile based build
 >> which appears to work better.

 > I was wondering why we could not just fix the CMake buildsystem, and
 > submit the fix upstream...

 > And then I remembered already talking about this earlier, but this
 > commit did not carry any explanations why we could not do it... So I
 > had to dig the archives to recover the previous discussion.

 > So, bottom line is, the commit log would be better off with more
 > explanations, like:

 >     The cmake build appears to be missing features, such as pkg-config
 >     generation support which is needed for some packages to find re2,
 >     like qt5webengine.

 >     Upstream is not keen on fixing the CMake-absed buildsystem [0]

 >     Instead of patching it on our side, and then have to carry the patch
 >     forever, we switch to the Makefile-based generic buildsystem.

 >     Note that previously some packages like grpc failed when the generic
 >     Makefile was used, because they would not find the cmake-equivalent
 >     of pkg-config, but this is now fixed [1].

 >     Signed-off-by: you.

 >     [0] https://github.com/google/re2/issues/349
 >     [1] https://github.com/grpc/grpc/commit/45e413d2520795e7281e9a592af81620349bc186

Yes, a lot nicer! Committed with the commit message changed to the
above, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot