Re: [PATCH v4 1/3] Bluetooth: aosp: surface AOSP quality report through mgmt

[kernel test robot <lkp@intel.com>]

Hi Joseph,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on net-next/master next-20220215]
[cannot apply to net/master v5.17-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Joseph-Hwang/Bluetooth-aosp-surface-AOSP-quality-report-through-mgmt/20220215-213800
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: h8300-randconfig-s032-20220214 (https://download.01.org/0day-ci/archive/20220216/202202160117.jjnGwidL-lkp@intel.com/config)
compiler: h8300-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/8c2212761e41006d67f3fad819b5bde57bc17773
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Joseph-Hwang/Bluetooth-aosp-surface-AOSP-quality-report-through-mgmt/20220215-213800
        git checkout 8c2212761e41006d67f3fad819b5bde57bc17773
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=h8300 SHELL=/bin/bash net/bluetooth/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
   net/bluetooth/hci_event.c:338:15: sparse: sparse: restricted __le16 degrades to integer
>> net/bluetooth/hci_event.c:4288:3: sparse: sparse: symbol 'evt_prefixes' was not declared. Should it be static?
   net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):
   include/net/bluetooth/hci.h:2473:47: sparse: sparse: array of flexible structures
   include/net/bluetooth/hci.h:2559:43: sparse: sparse: array of flexible structures

vim +/evt_prefixes +4288 net/bluetooth/hci_event.c

  4275	
  4276	/* Every distinct vendor specification must have a well-defined vendor
  4277	 * event prefix to determine if a vendor event meets the specification.
  4278	 * If an event prefix is fixed, it should be delcared with FIXED_EVT_PREFIX.
  4279	 * Otherwise, DYNAMIC_EVT_PREFIX should be used for variable prefixes.
  4280	 */
  4281	struct vendor_event_prefix {
  4282		__u8 *prefix;
  4283		__u8 prefix_len;
  4284		void (*vendor_func)(struct hci_dev *hdev, void *data,
  4285				    struct sk_buff *skb);
  4286		__u8 *(*get_prefix)(struct hci_dev *hdev);
  4287		__u8 (*get_prefix_len)(struct hci_dev *hdev);
> 4288	} evt_prefixes[] = {
  4289		FIXED_EVT_PREFIX(AOSP_BQR_PREFIX, aosp_quality_report_evt),
  4290		DYNAMIC_EVT_PREFIX(get_msft_evt_prefix, get_msft_evt_prefix_len,
  4291				   msft_vendor_evt),
  4292	
  4293		/* end with a null entry */
  4294		{},
  4295	};
  4296	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org