Re: [Buildroot] Buildroot Failure 2022-02-16 02:25:21

Re: [Buildroot] Buildroot Failure 2022-02-16 02:25:21

[Giulio Benetti]

[-- Attachment #1.1: Type: text/plain, Size: 3539 bytes --]

Hi Peter,

I add ML in Cc,

> Il giorno 18 feb 2022, alle ore 20:03, Peter Thompson <peter.macleod.thompson@gmail.com> ha scritto:
> 
> 
> Hi  Giulio
> 
> Whew - that was fast - I am back asking questions already :)....
> 
> My bump of sdl2_ttf-2.0.15 to sdl2_ttf-2.0.18  caused an autobuilder failure  2022-02-16 02:25:21.      The log indicates the problem is  pthread.h missing when harfbuzz is specified.    See log below...

Here can you please provide me the link like below?
http://autobuild.buildroot.net/results/cba/cba34c431f8d1315e9ca9159274421a8219a701e//

> 
> Not sure why sdl2_ttf-2.0.15 worked before.....  

It seems like that between 2.0.15 to 2.0.18(maybe)
sdl2_ttf only uses harfbuzz provided by sdl2_ttf itself.
This means it’s skipping the one provided from Buildroot that is already patched for harfbuzz pthread.h issue.

> Anyways, I planned to add 
> SDL2_TTF_DEPENDENCIES +=  pthread
> right under
> SDL2_TTF_DEPENDENCIES +=  harfbuzz

I would instead try to make sdl2_ttf to choose external harfbuzz instead of using the internal one. And also, we’re not sure that phtread.h is not provided at all.
Sometimes build systems fail to recognize headers and libs(the way they check if a library does exist or not).

> 
> But I am having trouble testing.   When I submit
>  ./autobuild   91f241b8e96   ( I assume SHA1 is the git id = commit id)
> I get 
> 404 Error Cannot get configuration for build 91f/91f241b8
> Suggestions?

Here you need to pass this sha1:
cba34c431f8d1315e9ca9159274421a8219a701e
that is the autobuilder sha1 and not the git sha1.

Take care to download the right script:
http://git.buildroot.net/buildroot-test/plain/utils/br-reproduce-build

Then to:
$ chmod a+x br-reproduce-build
Open it and adjust Buildroot path.
Then execute it with:
$ ./br-reproduce-build cba34c431f8d1315e9ca9159274421a8219a701e

Also remember that if it fails you can:
$ cd cba34c431f8d1315e9ca9159274421a8219a701e/output
$ make sdl2_ttf
or to rebuild package only:
$ make sdl2_ttf-dirclean sdl2_ttf

> 
> --- ALTERNATE IDEA ---
> 
> A better way to fix this issue might be to fix package/harfbuzz.   It is that dependency which needs pthread and which is causing sdl2_ttf to fail AFAIK. 

If look closer the build failure you will see that it’s not Buildroot harfbuzz that fails but a harfbuzz embedded into sdl2_ttf. 
So what I should to is to try to make sdl2_ttf drop its internal harfbuzz and use the Buildroot one.

> I see harfbuzz is maintained by you so you are an excellent person to ask.    
> 
> I checked harfbuzz and there is 
> 0001-meson.build-check-for-pthread.h.patch
> from Nov 2020 by Fabrice Fontaine.   Not sure if that patch was applied or if it fixes my issue. 

That is applied and actually fixes harfbuzz build failure. But as explained above you’re dealing with the one embedded into sdl2_ttf package.

> 
> Should I have copied the mailing list with these questions?  I am never sure. 

If you’re in doubt put it in Cc :-)

> Anyway - thanks for being there and helping.    It is appreciated. 

You’re welcome!

Best regards

Giulio

> 
> Peter
> 
> 
> In file included from external/harfbuzz-2.8.0/src/hb.hh:470,
>                  from external/harfbuzz-2.8.0/src/hb-aat-layout.cc:28:
> external/harfbuzz-2.8.0/src/hb-mutex.hh:53:10: fatal error: pthread.h: No such file or directory
>    53 | #include <pthread.h>
>       |          ^~~~~~~~~~~
> compilation terminated.
> 

[-- Attachment #1.2: Type: text/html, Size: 6171 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] Buildroot Failure 2022-02-16 02:25:21

[Yann E. MORIN]

Giulio, Peter, All,

On 2022-02-18 22:41 +0100, Giulio Benetti spake thusly:
> > Il giorno 18 feb 2022, alle ore 20:03, Peter Thompson <peter.macleod.thompson@gmail.com> ha scritto:
> > My bump of sdl2_ttf-2.0.15 to sdl2_ttf-2.0.18  caused an autobuilder failure  2022-02-16 02:25:21.      The log indicates the problem is  pthread.h missing when harfbuzz is specified.    See log below...
> > Not sure why sdl2_ttf-2.0.15 worked before.....  
> It seems like that between 2.0.15 to 2.0.18(maybe)
> sdl2_ttf only uses harfbuzz provided by sdl2_ttf itself.
> This means it’s skipping the one provided from Buildroot that is already patched for harfbuzz pthread.h issue.
[--SNIP--]
> If look closer the build failure you will see that it’s not Buildroot harfbuzz that fails but a harfbuzz embedded into sdl2_ttf. 
> So what I should to is to try to make sdl2_ttf drop its internal harfbuzz and use the Buildroot one.

I think ths might have been fixed with commit e253e41ce2e5 (package/sdl2_ttf:
add harfbuzz optional dependency)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] Buildroot Failure 2022-02-16 02:25:21

[Giulio Benetti]

Hi Yann, Peter, All,

> Il giorno 19 feb 2022, alle ore 10:02, Yann E. MORIN <yann.morin.1998@free.fr> ha scritto:
> 
> Giulio, Peter, All,
> 
> On 2022-02-18 22:41 +0100, Giulio Benetti spake thusly:
>>>> Il giorno 18 feb 2022, alle ore 20:03, Peter Thompson <peter.macleod.thompson@gmail.com> ha scritto:
>>> My bump of sdl2_ttf-2.0.15 to sdl2_ttf-2.0.18  caused an autobuilder failure  2022-02-16 02:25:21.      The log indicates the problem is  pthread.h missing when harfbuzz is specified.    See log below...
>>> Not sure why sdl2_ttf-2.0.15 worked before.....  
>> It seems like that between 2.0.15 to 2.0.18(maybe)
>> sdl2_ttf only uses harfbuzz provided by sdl2_ttf itself.
>> This means it’s skipping the one provided from Buildroot that is already patched for harfbuzz pthread.h issue.
> [--SNIP--]
>> If look closer the build failure you will see that it’s not Buildroot harfbuzz that fails but a harfbuzz embedded into sdl2_ttf. 
>> So what I should to is to try to make sdl2_ttf drop its internal harfbuzz and use the Buildroot one.
> 
> I think ths might have been fixed with commit e253e41ce2e5 (package/sdl2_ttf:
> add harfbuzz optional dependency)

Peter this is why when you check for autobuilder failure you need to pull Buildroot to latest version :-).

Also, before going to work on something, always check Buildroot patchwork if someone else has already done it.

And last but not least, check the package git repository itself for a fix, like a commit or a pending PR/MR or an issue with a solution explained.

Best regards
Giulio

> 
> Regards,
> Yann E. MORIN.
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] Buildroot Failure 2022-02-16 02:25:21

[Peter Thompson]

[-- Attachment #1.1: Type: text/plain, Size: 1936 bytes --]

 > I think this might have been fixed with commit e253e41ce2e5
(package/sdl2_ttf:
add harfbuzz optional dependency)

Yes - I was just noticing that it was already fixed....   thanks Yann

Peter

On Sat, Feb 19, 2022 at 2:02 AM Yann E. MORIN <yann.morin.1998@free.fr>
wrote:

> Giulio, Peter, All,
>
> On 2022-02-18 22:41 +0100, Giulio Benetti spake thusly:
> > > Il giorno 18 feb 2022, alle ore 20:03, Peter Thompson <
> peter.macleod.thompson@gmail.com> ha scritto:
> > > My bump of sdl2_ttf-2.0.15 to sdl2_ttf-2.0.18  caused an autobuilder
> failure  2022-02-16 02:25:21.      The log indicates the problem is
> pthread.h missing when harfbuzz is specified.    See log below...
> > > Not sure why sdl2_ttf-2.0.15 worked before.....
> > It seems like that between 2.0.15 to 2.0.18(maybe)
> > sdl2_ttf only uses harfbuzz provided by sdl2_ttf itself.
> > This means it’s skipping the one provided from Buildroot that is already
> patched for harfbuzz pthread.h issue.
> [--SNIP--]
> > If look closer the build failure you will see that it’s not Buildroot
> harfbuzz that fails but a harfbuzz embedded into sdl2_ttf.
> > So what I should to is to try to make sdl2_ttf drop its internal
> harfbuzz and use the Buildroot one.
>
> I think ths might have been fixed with commit e253e41ce2e5
> (package/sdl2_ttf:
> add harfbuzz optional dependency)
>
> Regards,
> Yann E. MORIN.
>
> --
>
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
> conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
>      |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is
> no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
>  conspiracy.  |
>
> '------------------------------^-------^------------------^--------------------'
>

[-- Attachment #1.2: Type: text/html, Size: 2550 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] Buildroot Failure 2022-02-16 02:25:21

[Giulio Benetti]

Hi Peter,

+Cc BR ML,

On 19/02/22 17:01, Peter Thompson wrote:
> Hi Giulio,
> 
> When I compared the most recent buildroot via "git clone" and compared 
> it to the "build in cba34..." I noticed the difference in 
> package/sdl2_ttf/ sdl2_ttf.mk <http://sdl2_ttf.mk>.   But I could not 
> find the commit in https://patchwork.ozlabs.org/project/buildroot/ 
> <https://patchwork.ozlabs.org/project/buildroot/> where that was 
> changed.

Pathchwork deals with patches, while you find commits in the git Repository:
https://git.buildroot.net/buildroot/log/

>   I looked for the title package/sdl2_ttf and did not see it?
> 
> Is there an easy way to search patchwork without going through line by 
> line?    I do not have pwclient installed - should I?

You can still use patchwork itself:
1) click on "Show patches with:"
2) use package name as "Search", so sdl2_ttf
3) set State as "any"
4) set Archived as Both

That way you will see all the patches, the New, Accepted, Superseded and 
Reject.

Another method would be by checking Buildroot Repository itself.
You can:
$ cd buildroot/
$ git log --grep=sdl2_ttf
or since you already know the package:
$ git log package/sdl2_ttf
or also:
$ gitk package/sdl2_ttf

That will give you the idea of what is really applied.

Or yes, you can use pwclient, but that and patchwork are really patch 
oriented. Here what you need is to check if the fix is already 
committed, so I(at least) would go for using git most of all.

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

> Thanks so much for your patience and help.
> 
> Peter
> 
> 
> On Sat, Feb 19, 2022 at 4:54 AM Giulio Benetti 
> <giulio.benetti@benettiengineering.com 
> <mailto:giulio.benetti@benettiengineering.com>> wrote:
> 
>     Yes, but probably has been already fixed.
>     Anyway now you know the entire workflow!
> 
>     Giulio
> 
>     Inviato da iPhone
> 
>>     Il giorno 19 feb 2022, alle ore 03:14, Peter Thompson
>>     <peter.macleod.thompson@gmail.com
>>     <mailto:peter.macleod.thompson@gmail.com>> ha scritto:
>>
>>     
>>     Lots for me to work on!!!!   Thanks so much for your help!!
>>     I will let you know when I have success.
>>     Peter
>>
>>     On Fri, Feb 18, 2022 at 2:41 PM Giulio Benetti
>>     <giulio.benetti@benettiengineering.com
>>     <mailto:giulio.benetti@benettiengineering.com>> wrote:
>>
>>         Hi Peter,
>>
>>         I add ML in Cc,
>>
>>>         Il giorno 18 feb 2022, alle ore 20:03, Peter Thompson
>>>         <peter.macleod.thompson@gmail.com
>>>         <mailto:peter.macleod.thompson@gmail.com>> ha scritto:
>>>
>>>         
>>>         Hi  Giulio
>>>
>>>         Whew - that was fast - I am back asking questions already :)....
>>>
>>>         My bump of sdl2_ttf-2.0.15 to sdl2_ttf-2.0.18  caused an
>>>         autobuilder failure  2022-02-16 02:25:21.      The log
>>>         indicates the problem is  pthread.h missing when harfbuzz is
>>>         specified.    See log below...
>>
>>         Here can you please provide me the link like below?
>>         http://autobuild.buildroot.net/results/cba/cba34c431f8d1315e9ca9159274421a8219a701e//
>>         <http://autobuild.buildroot.net/results/cba/cba34c431f8d1315e9ca9159274421a8219a701e//>
>>
>>>
>>>         Not sure why sdl2_ttf-2.0.15 worked before..... 
>>
>>         It seems like that between 2.0.15 to 2.0.18(maybe)
>>         sdl2_ttf only uses harfbuzz provided by sdl2_ttf itself.
>>         This means it’s skipping the one provided from Buildroot that
>>         is already patched for harfbuzz pthread.h issue.
>>
>>>         Anyways, I planned to add
>>>         SDL2_TTF_DEPENDENCIES +=  pthread
>>>         right under
>>>         SDL2_TTF_DEPENDENCIES +=  harfbuzz
>>
>>         I would instead try to make sdl2_ttf to choose external
>>         harfbuzz instead of using the internal one. And also, we’re
>>         not sure that phtread.h is not provided at all.
>>         Sometimes build systems fail to recognize headers and libs(the
>>         way they check if a library does exist or not).
>>
>>>
>>>         But I am having trouble testing.   When I submit
>>>          ./autobuild   91f241b8e96   ( I assume SHA1 is the git id =
>>>         commit id)
>>>         I get
>>>         404 Error Cannot get configuration for build 91f/91f241b8
>>>         Suggestions?
>>
>>         Here you need to pass this sha1:
>>         cba34c431f8d1315e9ca9159274421a8219a701e
>>         that is the autobuilder sha1 and not the git sha1.
>>
>>         Take care to download the right script:
>>         http://git.buildroot.net/buildroot-test/plain/utils/br-reproduce-build
>>         <http://git.buildroot.net/buildroot-test/plain/utils/br-reproduce-build>
>>
>>         Then to:
>>         $ chmod a+x br-reproduce-build
>>         Open it and adjust Buildroot path.
>>         Then execute it with:
>>         $ ./br-reproduce-build cba34c431f8d1315e9ca9159274421a8219a701e
>>
>>         Also remember that if it fails you can:
>>         $ cd cba34c431f8d1315e9ca9159274421a8219a701e/output
>>         $ make sdl2_ttf
>>         or to rebuild package only:
>>         $ make sdl2_ttf-dirclean sdl2_ttf
>>
>>>
>>>         --- ALTERNATE IDEA ---
>>>
>>>         A better way to fix this issue might be to fix
>>>         package/harfbuzz.   It is that dependency which needs pthread
>>>         and which is causing sdl2_ttf to fail AFAIK. 
>>
>>         If look closer the build failure you will see that it’s not
>>         Buildroot harfbuzz that fails but a harfbuzz embedded into
>>         sdl2_ttf.
>>         So what I should to is to try to make sdl2_ttf drop its
>>         internal harfbuzz and use the Buildroot one.
>>
>>>         I see harfbuzz is maintained by you so you are an excellent
>>>         person to ask.
>>>
>>>         I checked harfbuzz and there is
>>>         0001-meson.build-check-for-pthread.h.patch
>>>         from Nov 2020 by Fabrice Fontaine.   Not sure if that patch
>>>         was applied or if it fixes my issue.
>>
>>         That is applied and actually fixes harfbuzz build failure. But
>>         as explained above you’re dealing with the one embedded into
>>         sdl2_ttf package.
>>
>>>
>>>         Should I have copied the mailing list with these questions? 
>>>         I am never sure.
>>
>>         If you’re in doubt put it in Cc :-)
>>
>>>         Anyway - thanks for being there and helping.    It is
>>>         appreciated.
>>
>>         You’re welcome!
>>
>>         Best regards
>>
>>         Giulio
>>
>>>
>>>         Peter
>>>
>>>
>>>         In file included from external/harfbuzz-2.8.0/src/hb.hh:470,
>>>                           from external/harfbuzz-2.8.0/src/hb-aat-layout.cc:28:
>>>         external/harfbuzz-2.8.0/src/hb-mutex.hh:53:10: fatal error: pthread.h: No such file or directory
>>>             53 | #include <pthread.h>
>>>                |          ^~~~~~~~~~~
>>>         compilation terminated.
>>>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot