From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>
Subject: [PATCH 2/3] staging: r8188eu: refactor rtw_ch2freq()
Date: Sun, 20 Feb 2022 16:48:46 +0100 [thread overview]
Message-ID: <20220220154847.7521-3-straube.linux@gmail.com> (raw)
In-Reply-To: <20220220154847.7521-1-straube.linux@gmail.com>
Since we have only channel values from 1 to 14 we can convert the
array ch_freq_map to a simple integer array and use the indices as
channel numbers. This simplifies the code and avoids looping through
the array to get the frequency.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/core/rtw_rf.c | 40 +++++++++++----------------
1 file changed, 16 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_rf.c b/drivers/staging/r8188eu/core/rtw_rf.c
index 51425971782b..945a40e6511a 100644
--- a/drivers/staging/r8188eu/core/rtw_rf.c
+++ b/drivers/staging/r8188eu/core/rtw_rf.c
@@ -8,32 +8,24 @@
#include "../include/recv_osdep.h"
#include "../include/xmit_osdep.h"
-struct ch_freq {
- u32 channel;
- u32 frequency;
+static const u32 ch_freq_map[] = {
+ 2412,
+ 2417,
+ 2422,
+ 2427,
+ 2432,
+ 2437,
+ 2442,
+ 2447,
+ 2452,
+ 2457,
+ 2462,
+ 2467,
+ 2472,
+ 2484
};
-static struct ch_freq ch_freq_map[] = {
- {1, 2412}, {2, 2417}, {3, 2422}, {4, 2427}, {5, 2432},
- {6, 2437}, {7, 2442}, {8, 2447}, {9, 2452}, {10, 2457},
- {11, 2462}, {12, 2467}, {13, 2472}, {14, 2484},
-};
-
-static int ch_freq_map_num = ARRAY_SIZE(ch_freq_map);
-
u32 rtw_ch2freq(u32 channel)
{
- u8 i;
- u32 freq = 0;
-
- for (i = 0; i < ch_freq_map_num; i++) {
- if (channel == ch_freq_map[i].channel) {
- freq = ch_freq_map[i].frequency;
- break;
- }
- }
- if (i == ch_freq_map_num)
- freq = 2412;
-
- return freq;
+ return ch_freq_map[channel - 1];
}
--
2.35.1
next prev parent reply other threads:[~2022-02-20 15:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-20 15:48 [PATCH 0/3] staging: r8188eu: clean up rtw_rf.c Michael Straube
2022-02-20 15:48 ` [PATCH 1/3] staging: r8188eu: remove 5 GHz channels from ch_freq_map Michael Straube
2022-02-21 17:13 ` Greg KH
2022-02-21 19:07 ` Michael Straube
2022-02-21 19:41 ` Larry Finger
2022-02-25 8:57 ` Greg KH
2022-02-20 15:48 ` Michael Straube [this message]
2022-02-20 16:20 ` [PATCH 2/3] staging: r8188eu: refactor rtw_ch2freq() Pavel Skripkin
2022-02-20 16:30 ` Michael Straube
2022-02-21 12:22 ` Dan Carpenter
2022-02-21 19:20 ` Michael Straube
2022-02-21 20:54 ` Pavel Skripkin
2022-02-22 5:40 ` Dan Carpenter
2022-02-22 5:34 ` Dan Carpenter
2022-02-20 15:48 ` [PATCH 3/3] staging: r8188eu: clean up rtw_rf.c Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220220154847.7521-3-straube.linux@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.