All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Michael Straube <straube.linux@gmail.com>,
	phil@philpotter.co.uk, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: r8188eu: remove 5 GHz channels from ch_freq_map
Date: Fri, 25 Feb 2022 09:57:22 +0100	[thread overview]
Message-ID: <YhiZ8lCkQluFeNv8@kroah.com> (raw)
In-Reply-To: <636080dd-ab8d-a572-0f81-5f72b14ec1e4@lwfinger.net>

On Mon, Feb 21, 2022 at 01:41:22PM -0600, Larry Finger wrote:
> On 2/21/22 11:13, Greg KH wrote:
> > On Sun, Feb 20, 2022 at 04:48:45PM +0100, Michael Straube wrote:
> > > This driver is for chips that operate only in the 2.4 GHz band.
> > 
> > How do we know that?
> > 
> > thanks,
> Realtek (https://www.realtek.com/en/products/communications-network-ics/item/rtl8188eus)
> states the following:
> 
> "The Realtek RTL8188EUS is an 802.11bgn 2.4G single-chip that integrates
> Wireless LAN (WLAN) and a network USB interface (USB 1.0/1.1/2.0 compatible)
> controller. It combines a WLAN MAC, a 1T1R capable WLAN baseband, and WLAN
> RF in a single chip. The RTL8188EUS provides a complete solution for
> high-throughput performance and low power consumption integrated wireless
> LAN devices."
> 
> The reason there are 5G snippets in the driver is because Realtek uses the
> base code to generate drivers for other chip families such as RTL8192DU that
> have radios for both 2.4 and 5G bands. The RTL81288EU and variants have only
> a single radio.

Ah, ok, that's good to know.  And should belong in the changelog text so
that we are not confused :)

thanks,

greg k-h

  reply	other threads:[~2022-02-25  8:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-20 15:48 [PATCH 0/3] staging: r8188eu: clean up rtw_rf.c Michael Straube
2022-02-20 15:48 ` [PATCH 1/3] staging: r8188eu: remove 5 GHz channels from ch_freq_map Michael Straube
2022-02-21 17:13   ` Greg KH
2022-02-21 19:07     ` Michael Straube
2022-02-21 19:41     ` Larry Finger
2022-02-25  8:57       ` Greg KH [this message]
2022-02-20 15:48 ` [PATCH 2/3] staging: r8188eu: refactor rtw_ch2freq() Michael Straube
2022-02-20 16:20   ` Pavel Skripkin
2022-02-20 16:30     ` Michael Straube
2022-02-21 12:22       ` Dan Carpenter
2022-02-21 19:20         ` Michael Straube
2022-02-21 20:54           ` Pavel Skripkin
2022-02-22  5:40             ` Dan Carpenter
2022-02-22  5:34           ` Dan Carpenter
2022-02-20 15:48 ` [PATCH 3/3] staging: r8188eu: clean up rtw_rf.c Michael Straube

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhiZ8lCkQluFeNv8@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@philpotter.co.uk \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.