All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/re2: fix build with gcc <= 5
Date: Mon, 21 Feb 2022 21:00:44 +0100	[thread overview]
Message-ID: <20220221200044.GA2166282@scaer> (raw)
In-Reply-To: <20220221172900.1937856-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2022-02-21 18:29 +0100, Fabrice Fontaine spake thusly:
> Fix the following build failure with gcc <= 5 raised since bump to
> version 2022-02-01 in commit d2cf91e0c6a082261cc7ebb06dfdbd7bc2c2956f
> and
> https://github.com/google/re2/commit/a022cc0c55b0519629d64d775e7a5195af34a477
> 
> ./re2/sparse_array.h:266:37: warning: defaulted and deleted functions only available with -std=c++11 or -std=gnu++11
>  SparseArray<Value>::SparseArray() = default;
>                                      ^
> ./re2/sparse_array.h: In copy constructor 're2::SparseArray<Value>::SparseArray(const re2::SparseArray<Value>&)':
> ./re2/sparse_array.h:273:3: error: 'copy_n' is not a member of 'std'
>    std::copy_n(src.sparse_.data(), src.max_size(), sparse_.data());
>    ^
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/8ebbac67f32fe24416a1f72aad0afd42b567b403
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/re2/re2.mk | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/package/re2/re2.mk b/package/re2/re2.mk
> index 41392cb179..cc5fed71fa 100644
> --- a/package/re2/re2.mk
> +++ b/package/re2/re2.mk
> @@ -10,20 +10,25 @@ RE2_LICENSE = BSD-3-Clause
>  RE2_LICENSE_FILES = LICENSE
>  RE2_INSTALL_STAGING = YES
>  
> +RE2_MAKE_OPTS = \
> +	$(TARGET_CONFIGURE_OPTS) \
> +	CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11" \
> +	prefix=/usr

Is there a reason to have 'prefix' be set during the build, instead of
just the install steps?

Regards,
Yann E. MORIN.

>  define RE2_BUILD_CMDS
> -	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
> +	$(TARGET_MAKE_ENV) $(MAKE) $(RE2_MAKE_OPTS) \
>  		-C $(@D) $(if $(BR2_STATIC_LIBS),static)
>  endef
>  
>  define RE2_INSTALL_STAGING_CMDS
> -	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
> -		DESTDIR="$(STAGING_DIR)" prefix=/usr -C $(@D) \
> +	$(TARGET_MAKE_ENV) $(MAKE) $(RE2_MAKE_OPTS) \
> +		DESTDIR="$(STAGING_DIR)" -C $(@D) \
>  		$(if $(BR2_STATIC_LIBS),static-install,install)
>  endef
>  
>  define RE2_INSTALL_TARGET_CMDS
> -	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
> -		DESTDIR="$(TARGET_DIR)" prefix=/usr -C $(@D) \
> +	$(TARGET_MAKE_ENV) $(MAKE) $(RE2_MAKE_OPTS) \
> +		DESTDIR="$(TARGET_DIR)" -C $(@D) \
>  		$(if $(BR2_STATIC_LIBS),static-install,install)
>  endef
>  
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-02-21 20:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21 17:29 [Buildroot] [PATCH 1/1] package/re2: fix build with gcc <= 5 Fabrice Fontaine
2022-02-21 20:00 ` Yann E. MORIN [this message]
2022-02-21 22:05   ` Fabrice Fontaine
2022-02-23 18:51     ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220221200044.GA2166282@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.