* [Buildroot] [PATCH 1/1] package/re2: fix build with gcc <= 5
@ 2022-02-21 17:29 Fabrice Fontaine
2022-02-21 20:00 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Fabrice Fontaine @ 2022-02-21 17:29 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine
Fix the following build failure with gcc <= 5 raised since bump to
version 2022-02-01 in commit d2cf91e0c6a082261cc7ebb06dfdbd7bc2c2956f
and
https://github.com/google/re2/commit/a022cc0c55b0519629d64d775e7a5195af34a477
./re2/sparse_array.h:266:37: warning: defaulted and deleted functions only available with -std=c++11 or -std=gnu++11
SparseArray<Value>::SparseArray() = default;
^
./re2/sparse_array.h: In copy constructor 're2::SparseArray<Value>::SparseArray(const re2::SparseArray<Value>&)':
./re2/sparse_array.h:273:3: error: 'copy_n' is not a member of 'std'
std::copy_n(src.sparse_.data(), src.max_size(), sparse_.data());
^
Fixes:
- http://autobuild.buildroot.org/results/8ebbac67f32fe24416a1f72aad0afd42b567b403
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/re2/re2.mk | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/package/re2/re2.mk b/package/re2/re2.mk
index 41392cb179..cc5fed71fa 100644
--- a/package/re2/re2.mk
+++ b/package/re2/re2.mk
@@ -10,20 +10,25 @@ RE2_LICENSE = BSD-3-Clause
RE2_LICENSE_FILES = LICENSE
RE2_INSTALL_STAGING = YES
+RE2_MAKE_OPTS = \
+ $(TARGET_CONFIGURE_OPTS) \
+ CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11" \
+ prefix=/usr
+
define RE2_BUILD_CMDS
- $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
+ $(TARGET_MAKE_ENV) $(MAKE) $(RE2_MAKE_OPTS) \
-C $(@D) $(if $(BR2_STATIC_LIBS),static)
endef
define RE2_INSTALL_STAGING_CMDS
- $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
- DESTDIR="$(STAGING_DIR)" prefix=/usr -C $(@D) \
+ $(TARGET_MAKE_ENV) $(MAKE) $(RE2_MAKE_OPTS) \
+ DESTDIR="$(STAGING_DIR)" -C $(@D) \
$(if $(BR2_STATIC_LIBS),static-install,install)
endef
define RE2_INSTALL_TARGET_CMDS
- $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
- DESTDIR="$(TARGET_DIR)" prefix=/usr -C $(@D) \
+ $(TARGET_MAKE_ENV) $(MAKE) $(RE2_MAKE_OPTS) \
+ DESTDIR="$(TARGET_DIR)" -C $(@D) \
$(if $(BR2_STATIC_LIBS),static-install,install)
endef
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/re2: fix build with gcc <= 5
2022-02-21 17:29 [Buildroot] [PATCH 1/1] package/re2: fix build with gcc <= 5 Fabrice Fontaine
@ 2022-02-21 20:00 ` Yann E. MORIN
2022-02-21 22:05 ` Fabrice Fontaine
0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2022-02-21 20:00 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
Fabrice, All,
On 2022-02-21 18:29 +0100, Fabrice Fontaine spake thusly:
> Fix the following build failure with gcc <= 5 raised since bump to
> version 2022-02-01 in commit d2cf91e0c6a082261cc7ebb06dfdbd7bc2c2956f
> and
> https://github.com/google/re2/commit/a022cc0c55b0519629d64d775e7a5195af34a477
>
> ./re2/sparse_array.h:266:37: warning: defaulted and deleted functions only available with -std=c++11 or -std=gnu++11
> SparseArray<Value>::SparseArray() = default;
> ^
> ./re2/sparse_array.h: In copy constructor 're2::SparseArray<Value>::SparseArray(const re2::SparseArray<Value>&)':
> ./re2/sparse_array.h:273:3: error: 'copy_n' is not a member of 'std'
> std::copy_n(src.sparse_.data(), src.max_size(), sparse_.data());
> ^
>
> Fixes:
> - http://autobuild.buildroot.org/results/8ebbac67f32fe24416a1f72aad0afd42b567b403
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/re2/re2.mk | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/package/re2/re2.mk b/package/re2/re2.mk
> index 41392cb179..cc5fed71fa 100644
> --- a/package/re2/re2.mk
> +++ b/package/re2/re2.mk
> @@ -10,20 +10,25 @@ RE2_LICENSE = BSD-3-Clause
> RE2_LICENSE_FILES = LICENSE
> RE2_INSTALL_STAGING = YES
>
> +RE2_MAKE_OPTS = \
> + $(TARGET_CONFIGURE_OPTS) \
> + CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11" \
> + prefix=/usr
Is there a reason to have 'prefix' be set during the build, instead of
just the install steps?
Regards,
Yann E. MORIN.
> define RE2_BUILD_CMDS
> - $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
> + $(TARGET_MAKE_ENV) $(MAKE) $(RE2_MAKE_OPTS) \
> -C $(@D) $(if $(BR2_STATIC_LIBS),static)
> endef
>
> define RE2_INSTALL_STAGING_CMDS
> - $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
> - DESTDIR="$(STAGING_DIR)" prefix=/usr -C $(@D) \
> + $(TARGET_MAKE_ENV) $(MAKE) $(RE2_MAKE_OPTS) \
> + DESTDIR="$(STAGING_DIR)" -C $(@D) \
> $(if $(BR2_STATIC_LIBS),static-install,install)
> endef
>
> define RE2_INSTALL_TARGET_CMDS
> - $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
> - DESTDIR="$(TARGET_DIR)" prefix=/usr -C $(@D) \
> + $(TARGET_MAKE_ENV) $(MAKE) $(RE2_MAKE_OPTS) \
> + DESTDIR="$(TARGET_DIR)" -C $(@D) \
> $(if $(BR2_STATIC_LIBS),static-install,install)
> endef
>
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/re2: fix build with gcc <= 5
2022-02-21 20:00 ` Yann E. MORIN
@ 2022-02-21 22:05 ` Fabrice Fontaine
2022-02-23 18:51 ` Arnout Vandecappelle
0 siblings, 1 reply; 4+ messages in thread
From: Fabrice Fontaine @ 2022-02-21 22:05 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: Buildroot Mailing List
Yann,
Le lun. 21 févr. 2022 à 21:00, Yann E. MORIN <yann.morin.1998@free.fr> a écrit :
>
> Fabrice, All,
>
> On 2022-02-21 18:29 +0100, Fabrice Fontaine spake thusly:
> > Fix the following build failure with gcc <= 5 raised since bump to
> > version 2022-02-01 in commit d2cf91e0c6a082261cc7ebb06dfdbd7bc2c2956f
> > and
> > https://github.com/google/re2/commit/a022cc0c55b0519629d64d775e7a5195af34a477
> >
> > ./re2/sparse_array.h:266:37: warning: defaulted and deleted functions only available with -std=c++11 or -std=gnu++11
> > SparseArray<Value>::SparseArray() = default;
> > ^
> > ./re2/sparse_array.h: In copy constructor 're2::SparseArray<Value>::SparseArray(const re2::SparseArray<Value>&)':
> > ./re2/sparse_array.h:273:3: error: 'copy_n' is not a member of 'std'
> > std::copy_n(src.sparse_.data(), src.max_size(), sparse_.data());
> > ^
> >
> > Fixes:
> > - http://autobuild.buildroot.org/results/8ebbac67f32fe24416a1f72aad0afd42b567b403
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > package/re2/re2.mk | 15 ++++++++++-----
> > 1 file changed, 10 insertions(+), 5 deletions(-)
> >
> > diff --git a/package/re2/re2.mk b/package/re2/re2.mk
> > index 41392cb179..cc5fed71fa 100644
> > --- a/package/re2/re2.mk
> > +++ b/package/re2/re2.mk
> > @@ -10,20 +10,25 @@ RE2_LICENSE = BSD-3-Clause
> > RE2_LICENSE_FILES = LICENSE
> > RE2_INSTALL_STAGING = YES
> >
> > +RE2_MAKE_OPTS = \
> > + $(TARGET_CONFIGURE_OPTS) \
> > + CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11" \
> > + prefix=/usr
>
> Is there a reason to have 'prefix' be set during the build, instead of
> just the install steps?
I thought it was better to have it in a single place but I'll send a v2.
>
> Regards,
> Yann E. MORIN.
>
> > define RE2_BUILD_CMDS
> > - $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
> > + $(TARGET_MAKE_ENV) $(MAKE) $(RE2_MAKE_OPTS) \
> > -C $(@D) $(if $(BR2_STATIC_LIBS),static)
> > endef
> >
> > define RE2_INSTALL_STAGING_CMDS
> > - $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
> > - DESTDIR="$(STAGING_DIR)" prefix=/usr -C $(@D) \
> > + $(TARGET_MAKE_ENV) $(MAKE) $(RE2_MAKE_OPTS) \
> > + DESTDIR="$(STAGING_DIR)" -C $(@D) \
> > $(if $(BR2_STATIC_LIBS),static-install,install)
> > endef
> >
> > define RE2_INSTALL_TARGET_CMDS
> > - $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
> > - DESTDIR="$(TARGET_DIR)" prefix=/usr -C $(@D) \
> > + $(TARGET_MAKE_ENV) $(MAKE) $(RE2_MAKE_OPTS) \
> > + DESTDIR="$(TARGET_DIR)" -C $(@D) \
> > $(if $(BR2_STATIC_LIBS),static-install,install)
> > endef
> >
> > --
> > 2.34.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
Best Regards,
Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/re2: fix build with gcc <= 5
2022-02-21 22:05 ` Fabrice Fontaine
@ 2022-02-23 18:51 ` Arnout Vandecappelle
0 siblings, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2022-02-23 18:51 UTC (permalink / raw)
To: Fabrice Fontaine, Yann E. MORIN; +Cc: Buildroot Mailing List
On 21/02/2022 23:05, Fabrice Fontaine wrote:
> Yann,
>
> Le lun. 21 févr. 2022 à 21:00, Yann E. MORIN <yann.morin.1998@free.fr> a écrit :
>>
>> Fabrice, All,
>>
>> On 2022-02-21 18:29 +0100, Fabrice Fontaine spake thusly:
>>> Fix the following build failure with gcc <= 5 raised since bump to
>>> version 2022-02-01 in commit d2cf91e0c6a082261cc7ebb06dfdbd7bc2c2956f
>>> and
>>> https://github.com/google/re2/commit/a022cc0c55b0519629d64d775e7a5195af34a477
>>>
>>> ./re2/sparse_array.h:266:37: warning: defaulted and deleted functions only available with -std=c++11 or -std=gnu++11
>>> SparseArray<Value>::SparseArray() = default;
>>> ^
>>> ./re2/sparse_array.h: In copy constructor 're2::SparseArray<Value>::SparseArray(const re2::SparseArray<Value>&)':
>>> ./re2/sparse_array.h:273:3: error: 'copy_n' is not a member of 'std'
>>> std::copy_n(src.sparse_.data(), src.max_size(), sparse_.data());
>>> ^
>>>
>>> Fixes:
>>> - http://autobuild.buildroot.org/results/8ebbac67f32fe24416a1f72aad0afd42b567b403
>>>
>>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>>> ---
>>> package/re2/re2.mk | 15 ++++++++++-----
>>> 1 file changed, 10 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/package/re2/re2.mk b/package/re2/re2.mk
>>> index 41392cb179..cc5fed71fa 100644
>>> --- a/package/re2/re2.mk
>>> +++ b/package/re2/re2.mk
>>> @@ -10,20 +10,25 @@ RE2_LICENSE = BSD-3-Clause
>>> RE2_LICENSE_FILES = LICENSE
>>> RE2_INSTALL_STAGING = YES
>>>
>>> +RE2_MAKE_OPTS = \
>>> + $(TARGET_CONFIGURE_OPTS) \
>>> + CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11" \
>>> + prefix=/usr
>>
>> Is there a reason to have 'prefix' be set during the build, instead of
>> just the install steps?
> I thought it was better to have it in a single place but I'll send a v2.
Actually, in general it is possible that the prefix is used during the build
to hardcode some paths. Not in this case I think, but it's good practice to keep
these options identical during the build and install steps. The only one that
should not be there in build is DESTDIR.
Regards,
Arnout
>>
>> Regards,
>> Yann E. MORIN.
>>
>>> define RE2_BUILD_CMDS
>>> - $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
>>> + $(TARGET_MAKE_ENV) $(MAKE) $(RE2_MAKE_OPTS) \
>>> -C $(@D) $(if $(BR2_STATIC_LIBS),static)
>>> endef
>>>
>>> define RE2_INSTALL_STAGING_CMDS
>>> - $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
>>> - DESTDIR="$(STAGING_DIR)" prefix=/usr -C $(@D) \
>>> + $(TARGET_MAKE_ENV) $(MAKE) $(RE2_MAKE_OPTS) \
>>> + DESTDIR="$(STAGING_DIR)" -C $(@D) \
>>> $(if $(BR2_STATIC_LIBS),static-install,install)
>>> endef
>>>
>>> define RE2_INSTALL_TARGET_CMDS
>>> - $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
>>> - DESTDIR="$(TARGET_DIR)" prefix=/usr -C $(@D) \
>>> + $(TARGET_MAKE_ENV) $(MAKE) $(RE2_MAKE_OPTS) \
>>> + DESTDIR="$(TARGET_DIR)" -C $(@D) \
>>> $(if $(BR2_STATIC_LIBS),static-install,install)
>>> endef
>>>
>>> --
>>> 2.34.1
>>>
>>> _______________________________________________
>>> buildroot mailing list
>>> buildroot@buildroot.org
>>> https://lists.buildroot.org/mailman/listinfo/buildroot
>>
>> --
>> .-----------------.--------------------.------------------.--------------------.
>> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
>> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
>> | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
>> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
>> '------------------------------^-------^------------------^--------------------'
> Best Regards,
>
> Fabrice
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-23 18:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-21 17:29 [Buildroot] [PATCH 1/1] package/re2: fix build with gcc <= 5 Fabrice Fontaine
2022-02-21 20:00 ` Yann E. MORIN
2022-02-21 22:05 ` Fabrice Fontaine
2022-02-23 18:51 ` Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.