From: Peter Robinson <pbrobinson@gmail.com>
To: Doug Berger <opendmb@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org
Cc: Peter Robinson <pbrobinson@gmail.com>,
Javier Martinez Canillas <javierm@redhat.com>
Subject: [PATCH] net: bcmgenet: Return not supported if we don't have a WoL IRQ
Date: Tue, 22 Feb 2022 09:53:48 +0000 [thread overview]
Message-ID: <20220222095348.2926536-1-pbrobinson@gmail.com> (raw)
The ethtool WoL enable function wasn't checking if the device
has the optional WoL IRQ and hence on platforms such as the
Raspberry Pi 4 which had working ethernet prior to the last
fix regressed with the last fix, so also check if we have a
WoL IRQ there and return ENOTSUPP if not.
Fixes: 9deb48b53e7f ("bcmgenet: add WOL IRQ check")
Fixes: 8562056f267d ("net: bcmgenet: request Wake-on-LAN interrupt")
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
Suggested-by: Javier Martinez Canillas <javierm@redhat.com>
---
drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c | 4 ++++
1 file changed, 4 insertions(+)
We're seeing this crash on the Raspberry Pi 4 series of devices on
Fedora on 5.17-rc with the top Fixes patch and wired ethernet doesn't work.
[173353.733114] bcmgenet fd580000.ethernet eth0: Link is Up - 1Gbps/Full - flow control rx/tx
[173353.741855] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
dm[173356.452622] ------------[ cut here ]------------
[173356.457442] NETDEV WATCHDOG: eth0 (bcmgenet): transmit queue 4 timed out
[173356.464418] WARNING: CPU: 3 PID: 0 at net/sched/sch_generic.c:529 dev_watchdog+0x234/0x240
[173356.472915] Modules linked in: tls nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ip_set nf_tables nfnetlink rtl8xxxu rtl8192cu rtl_usb rtl8192c_common rtlwifi btsdio mac80211 bluetooth cpufreq_dt libarc4 ecdh_generic brcmfmac brcmutil cfg80211 raspberrypi_cpufreq rfkill broadcom snd_soc_hdmi_codec bcm_phy_lib bcm2711_thermal genet iproc_rng200 mdio_bcm_unimac leds_gpio nvmem_rmem vfat fat fuse zram mmc_block vc4 snd_soc_core crct10dif_ce snd_compress gpio_raspberrypi_exp raspberrypi_hwmon dwc2 clk_bcm2711_dvp ac97_bus snd_pcm_dmaengine bcm2835_wdt snd_pcm udc_core snd_timer bcm2835_dma sdhci_iproc snd sdhci_pltfm pcie_brcmstb sdhci phy_generic soundcore drm_cma_helper i2c_dev aes_neon_bs
[173356.546454] CPU: 3 PID: 0 Comm: swapper/3 Not tainted 5.17.0-0.rc4.96.pbr1.fc36.aarch64 #1
[173356.554931] Hardware name: Unknown Unknown Product/Unknown Product, BIOS 2022.04-rc1 04/01/2022
[173356.563843] pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[173356.570997] pc : dev_watchdog+0x234/0x240
[173356.575157] lr : dev_watchdog+0x234/0x240
[173356.579314] sp : ffff8000080b3a40
[173356.582758] x29: ffff8000080b3a40 x28: ffffc6e8711b7000 x27: ffff8000080b3b20
[173356.590096] x26: ffffc6e870c30000 x25: 0000000000000000 x24: ffffc6e8711bec08
[173356.597432] x23: 0000000000000100 x22: ffffc6e8711b7000 x21: ffff38a4c2250000
[173356.604767] x20: 0000000000000004 x19: ffff38a4c22504c8 x18: ffffffffffffffff
[173356.612102] x17: ffff71bd0ab21000 x16: ffff80000801c000 x15: 0000000000000006
[173356.619436] x14: 0000000000000000 x13: 205d323434373534 x12: ffffc6e8712ad5f0
[173356.626769] x11: 712074696d736e61 x10: ffffc6e8712ad5f0 x9 : ffffc6e86edfc78c
[173356.634104] x8 : 00000000ffffdfff x7 : 000000000000003f x6 : 0000000000000000
[173356.641438] x5 : 0000000000000000 x4 : 0000000000000000 x3 : 0000000000001000
[173356.648773] x2 : 0000000000001000 x1 : 0000000000000005 x0 : 000000000000003c
[173356.656107] Call trace:
[173356.658685] dev_watchdog+0x234/0x240
[173356.662493] call_timer_fn+0x3c/0x15c
[173356.666304] __run_timers.part.0+0x288/0x310
[173356.670728] run_timer_softirq+0x48/0x80
[173356.674799] __do_softirq+0x128/0x360
e[173356.678601] __irq_exit_rcu+0x138/0x140
[173356.682661] irq_exit_rcu+0x1c/0x30
[173356.686291] el1_interrupt+0x38/0x54
[173356.690007] el1h_64_irq_handler+0x18/0x24
[173356.694251] el1h_64_irq+0x7c/0x80
[173356.697787] arch_cpu_idle+0x18/0x2c
[173356.701502] default_idle_call+0x4c/0x140
[173356.705657] cpuidle_idle_call+0x14c/0x1a0
[173356.709905] do_idle+0xb0/0x100
[173356.713182] cpu_startup_entry+0x34/0x8c
[173356.717252] secondary_start_kernel+0xe4/0x110
[173356.721852] __secondary_switched+0x94/0x98
[173356.726188] ---[ end trace 0000000000000000 ]---
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c b/drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c
index e31a5a397f11..325f01b916c8 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c
@@ -60,6 +60,10 @@ int bcmgenet_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
if (!device_can_wakeup(kdev))
return -ENOTSUPP;
+ /* We need a WoL IRQ to enable support, not all HW has one setup */
+ if (priv->wol_irq <= 0)
+ return -ENOTSUPP;
+
if (wol->wolopts & ~(WAKE_MAGIC | WAKE_MAGICSECURE | WAKE_FILTER))
return -EINVAL;
--
2.35.1
next reply other threads:[~2022-02-22 9:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 9:53 Peter Robinson [this message]
2022-02-22 10:03 ` [PATCH] net: bcmgenet: Return not supported if we don't have a WoL IRQ Javier Martinez Canillas
2022-02-22 16:42 ` Florian Fainelli
2022-02-22 20:07 ` Peter Robinson
2022-02-22 20:15 ` Florian Fainelli
2022-02-23 11:40 ` Peter Robinson
2022-02-23 17:35 ` Florian Fainelli
2022-02-23 17:41 ` Peter Robinson
2022-02-23 17:45 ` Peter Robinson
2022-02-23 17:54 ` Florian Fainelli
2022-02-23 22:48 ` Jakub Kicinski
2022-02-23 22:58 ` Florian Fainelli
2022-02-23 23:15 ` Jakub Kicinski
2022-03-02 18:02 ` Jakub Kicinski
2022-03-02 18:20 ` Florian Fainelli
2022-03-03 20:00 ` Jeremy Linton
2022-03-03 20:04 ` Javier Martinez Canillas
2022-03-04 17:33 ` Jeremy Linton
2022-03-04 20:12 ` Florian Fainelli
2022-03-07 18:27 ` Jeremy Linton
2022-03-07 18:44 ` Florian Fainelli
2022-03-07 19:23 ` Jeremy Linton
2022-02-24 9:34 ` Peter Robinson
2022-03-02 5:00 ` Jeremy Linton
2022-03-02 9:34 ` Peter Robinson
2022-02-22 23:42 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220222095348.2926536-1-pbrobinson@gmail.com \
--to=pbrobinson@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=javierm@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.